Skip to content

Commit 5a4c8a7

Browse files
authored
Adds parameter completer for -Period in Reports module (#1956)
* Add argument completer for -Period parameter. * Fix missing -OutFile parameter
1 parent e870e48 commit 5a4c8a7

File tree

3 files changed

+41
-0
lines changed

3 files changed

+41
-0
lines changed

src/Reports/Reports.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ require:
1717
1818
``` yaml
1919
directive:
20+
- where:
21+
parameter-name: Period
22+
set:
23+
completer:
24+
name: Period Completer
25+
description: Gets the list of Period values.
26+
script: "'D7', 'D30', 'D90', 'D180'"
2027
# Remove invalid paths.
2128
- remove-path-by-operation: auditLogs\.auditLogRoot.*|reports.reportRoot.*|(auditLogs|reports)_(Create|Delete|Update).*
2229
# Remove cmdlets
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# ------------------------------------------------------------------------------
2+
# Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the MIT License. See License in the project root for license information.
3+
# ------------------------------------------------------------------------------
4+
Describe "Get-MgReportEmailActivityCount" {
5+
BeforeAll {
6+
$GetMgReportEmailActivityCount = Get-Command Get-MgReportEmailActivityCount
7+
}
8+
9+
It "Should support minimum set of parameter sets" {
10+
$GetMgReportEmailActivityCount.ParameterSets.Name | Should -BeIn @("Get", "GetViaIdentity")
11+
$GetMgReportEmailActivityCount.Visibility | Should -Be "Public"
12+
$GetMgReportEmailActivityCount.CommandType | Should -Be "Function"
13+
}
14+
15+
It "Should return a list of applications by default" {
16+
$GetMgReportEmailActivityCount.OutputType | Should -Be "System.Boolean"
17+
$GetMgReportEmailActivityCount.DefaultParameterSet | Should -Be "Get"
18+
}
19+
20+
It 'Should have Get parameterSet' {
21+
$GetParameterSet = $GetMgReportEmailActivityCount.ParameterSets | Where-Object Name -eq "Get"
22+
$GetParameterSet.Parameters.Name | Should -Contain OutFile
23+
$GetParameterSet.Parameters.Name | Should -Contain Period
24+
}
25+
26+
It '-Period parameter should have an argument completer' {
27+
$GetMgReportEmailActivityCount.Parameters.Period.Attributes.ScriptBlock | Should -be "'D7', 'D30', 'D90', 'D180'"
28+
}
29+
}

src/readme.graph.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,11 @@ directive:
492492
- from: openapi-document
493493
where: $..paths.*[?(/(.*_GetCount)/gmi.exec(@.operationId))]..parameters[?(@.name === "ConsistencyLevel")]
494494
transform: $['required'] = true
495+
# Fix binary response definition for AutoREST to generate -OutFile parameter.
496+
- from: openapi-document
497+
where: $..paths..responses['2XX'].content['application/octet-stream'].schema
498+
transform: >-
499+
if ($.type === 'object') { $['format'] = "binary" }
495500
# Modify generated .json.cs model classes.
496501
- from: source-file-csharp
497502
where: $

0 commit comments

Comments
 (0)