Skip to content

Commit 69dd264

Browse files
committed
remove duplicate method
1 parent 333d168 commit 69dd264

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

src/msgraph_core/requests/batch_response_content.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ def response(self, request_id: str) -> 'BatchResponseItem':
5858
return response
5959
raise KeyError(f"Response with request ID {request_id} not found.")
6060

61-
def get_response_by_id(self, request_id: str) -> 'BatchResponseItem':
62-
if self._responses is None:
63-
raise ValueError("Responses list is not initialized.")
64-
for response in self._responses:
65-
if response.request_id == request_id:
66-
return response
67-
raise KeyError(f"Response with request ID {request_id} not found.")
61+
# def get_response_by_id(self, request_id: str) -> 'BatchResponseItem':
62+
# if self._responses is None:
63+
# raise ValueError("Responses list is not initialized.")
64+
# for response in self._responses:
65+
# if response.request_id == request_id:
66+
# return response
67+
# raise KeyError(f"Response with request ID {request_id} not found.")
6868

6969
def response_body(self, request_id: str, type: Type[T]) -> Optional[T]:
7070
"""
@@ -82,7 +82,7 @@ def response_body(self, request_id: str, type: Type[T]) -> Optional[T]:
8282
if not issubclass(type, Parsable):
8383
raise ValueError("Type passed must implement the Parsable interface")
8484

85-
response = self.get_response_by_id(request_id)
85+
response = self.response(request_id)
8686
content_type = response.content_type
8787
if not content_type:
8888
raise RuntimeError("Unable to get content-type header in response item")

tests/requests/test_batch_response_content.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,6 @@ def test_response_method(batch_response_content):
2828
assert batch_response_content.response("12345") == response_item
2929

3030

31-
def test_get_response_by_id_method(batch_response_content):
32-
response_item = Mock(spec=BatchResponseItem)
33-
response_item.request_id = "12345"
34-
batch_response_content.responses = [response_item]
35-
assert batch_response_content.get_response_by_id("12345") == response_item
36-
37-
3831
def test_response_body_method(batch_response_content):
3932
response_item = Mock(spec=BatchResponseItem)
4033
response_item.request_id = "12345"

0 commit comments

Comments
 (0)