Skip to content

Commit 75c76fc

Browse files
committed
Minor adjustments
1 parent a9cf227 commit 75c76fc

File tree

3 files changed

+21
-16
lines changed

3 files changed

+21
-16
lines changed

msgraphcore/graph_client.py

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
from msgraphcore.middleware.request_context import RequestContext
33
from typing import List, Optional
44

5-
from requests import Session
6-
from requests import PreparedRequest
7-
from requests import Request
5+
from requests import Request, Session
6+
87

98
from msgraphcore.client_factory import HTTPClientFactory
109
from msgraphcore.middleware.abc_token_credential import TokenCredential
@@ -15,16 +14,15 @@
1514

1615
def attach_context(func):
1716
def wrapper(*args, **kwargs):
18-
mw_control = dict()
19-
headers = kwargs.pop('headers', {})
20-
17+
middleware_control = dict()
18+
2119
for option in supported_options:
22-
op = kwargs.pop(option, None)
23-
24-
if op:
25-
mw_control.update({option: op})
26-
27-
req_context = RequestContext(mw_control, headers)
20+
value = kwargs.pop(option, None)
21+
if value:
22+
middleware_control.update({option: value})
23+
24+
headers = kwargs.get('headers', {})
25+
req_context = RequestContext(middleware_control, headers)
2826

2927
request = func(*args, **kwargs)
3028
request.context = req_context
@@ -79,7 +77,8 @@ def put(self, url, data=None, **kwargs):
7977
:param \*\*kwargs: Optional arguments that ``request`` takes.
8078
:rtype: requests.Response
8179
"""
82-
return self.graph_session.put(self._graph_url(url), data, **kwargs)
80+
prepped_req = self.prepare_request('PUT', self._graph_url(url), **kwargs)
81+
return self.graph_session.send(prepped_req)
8382

8483
def patch(self, url, data=None, **kwargs):
8584
r"""Sends a PATCH request. Returns :class:`Response` object.
@@ -89,15 +88,17 @@ def patch(self, url, data=None, **kwargs):
8988
:param \*\*kwargs: Optional arguments that ``request`` takes.
9089
:rtype: requests.Response
9190
"""
92-
return self.graph_session.patch(self._graph_url(url), data, **kwargs)
91+
prepped_req = self.prepare_request('PATCH', self._graph_url(url), **kwargs)
92+
return self.graph_session.send(prepped_req)
9393

9494
def delete(self, url, **kwargs):
9595
r"""Sends a DELETE request. Returns :class:`Response` object.
9696
:param url: URL for the new :class:`Request` object.
9797
:param \*\*kwargs: Optional arguments that ``request`` takes.
9898
:rtype: requests.Response
9999
"""
100-
return self.graph_session.delete(self._graph_url(url), **kwargs)
100+
prepped_req = self.prepare_request('DELETE', self._graph_url(url), **kwargs)
101+
return self.graph_session.send(prepped_req)
101102

102103
def _graph_url(self, url: str) -> str:
103104
"""Appends BASE_URL to user provided path

msgraphcore/middleware/middleware.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ def add_middleware(self, middleware):
2525
self._middleware = middleware
2626

2727
def send(self, request, **kwargs):
28+
29+
if not hasattr(request, 'context'):
30+
headers = request.headers
31+
request.context = RequestContext(dict(), headers)
32+
2833
if self._middleware_present():
2934
return self._middleware.send(request, **kwargs)
3035
# No middleware in pipeline, call superclass' send

msgraphcore/middleware/request_context.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,4 @@ def feature_usage(self):
1616

1717
@feature_usage.setter
1818
def set_feature_usage(self, flag: FeatureUsageFlag):
19-
print(type(self._feature_usage))
2019
self._feature_usage = self._feature_usage | flag

0 commit comments

Comments
 (0)