fix: Batch building bugs (#837)

* fix: removed extra slash

* fix: finalise returns the whole BatchRequestContent

* fix: fixed test

---------

Co-authored-by: George Garber <[email protected]>

Author: GeorgeOG

src/msgraph_core/requests/batch_request_builder.py

@@ -31,7 +31,7 @@ def __init__(
         if request_adapter is None:
             raise ValueError("request_adapter cannot be Null.")
         self._request_adapter = request_adapter
-        self.url_template = f"{self._request_adapter.base_url}/$batch"
+        self.url_template = f"{self._request_adapter.base_url.removesuffix('/')}/$batch"
         self.error_map = error_map or {}
 
     async def post(

src/msgraph_core/requests/batch_request_content.py

@@ -125,7 +125,7 @@ def finalize(self):
         Finalizes the batch request content.
         """
         self.is_finalized = True
-        return self._requests
+        return self
 
     def _request_by_id(self, request_id: str) -> Optional[BatchRequestItem]:
         """

tests/requests/test_batch_request_content.py

@@ -88,9 +88,9 @@ def test_add_urllib_request(batch_request_content):
 
 
 def test_finalize(batch_request_content):
-    finalized_requests = batch_request_content.finalize()
+    finalized_batch_request_content = batch_request_content.finalize()
     assert batch_request_content.is_finalized
-    assert finalized_requests == batch_request_content.requests
+    assert finalized_batch_request_content.requests == batch_request_content.requests
 
 
 def test_create_from_discriminator_value():