Graph client's batch request builder POST/PATCH request not working

[chandra447]

Describe the bug

I am trying to create multiple sharepoint list items in a list usign the batch request builder. Bu t throws API 400 error. Below is my implementation in the How to reproduce section

Expected behavior

I expect it to create all the records as it uses the jsonwriter and the method write_object which the actual ListItem also uses

How to reproduce

creds = ClientSecretCredential(
        tenant_id=settings.tenant_id, client_id=settings.app_id, client_secret=settings.client_secret
    )

client = GraphServiceClient(credentials=credentials, scopes=['https://graph.microsoft.com/.default'])

request_body = ListItem(
	fields = FieldValueSet(
		additional_data = {
				"title" : "Widget",
				"color" : "Purple",
				"weight" : 32,
		}
	),
)
request_info1: RequestInformation = client.sites.by_site_id(settings.site_id)
            .lists.by_list_id(settings.list_id)
            .items.to_post_request_information(body=request_body)

batch_request_content: BatchRequestContent = BatchRequestContent()
# using the requests setter
batch_request_content.requests = [
        BatchRequestItem(
            request_information=request_info1,
        ),
    ]

batch_response_content: BatchResponseContent = await client.batch.post(
        batch_request_content=batch_request_content
    )

for response in batch_response_content.responses.values():
        print(response.status)
        print(response.body)
        print(response.headers)

SDK Version

No response

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Click to expand log

```

</details>


### Configuration

_No response_

### Other information

_No response_

[chandra447]

@baywet i have created this issue to continue the conversation
microsoftgraph/msgraph-sdk-python#915 (comment)

[chandra447]

i also want to add that, when returning the batchRequestBuilder it uses the msgraph_core where the url_template is formatted wrong as it adds an additional / based on this line which would result in https://graph.microsoft.com/v1.0//$batch

msgraph-sdk-python-core/src/msgraph_core/requests/batch_request_builder.py

Line 34 in c6c089e

self.url_template = f"{self._request_adapter.base_url}/$batch"

[chandra447]

@baywet this thing was fixed when i manually overide the content of the batchrequest information as follows after this line in msgraph_core/batch_request_builder.

My take would be the serialization of the batchRequestItem needs to be handled

request_info.content = b'{"requests": [{"id": "8fb651a7-8f45-495c-a266-301aa14c91a4", "headers":{"Content-Type": "application/json"},"body":{ "fields": {"title": "widget", "color": "purple", }},"method": "POST", "url": "/sites/{{site_id}}/lists/{{list_id}}/items", "depends_on": []}]}'

[baywet]

Hi @chandra447
Thank you for using the SDK and for reaching out.

i also want to add that, when returning the batchRequestBuilder it uses the msgraph_core where the url_template is formatted wrong as it adds an additional / based on this line which would result in https://graph.microsoft.com/v1.0//$batch

msgraph-sdk-python-core/src/msgraph_core/requests/batch_request_builder.py

Line 34 in c6c089e

self.url_template = f"{self._request_adapter.base_url}/$batch"

Would you mind sending a pull request to check whether the base url ends with a / before adding one please?

@baywet this thing was fixed when i manually overide the content of the batchrequest information as follows after this line in msgraph_core/batch_request_builder.

My take would be the serialization of the batchRequestItem needs to be handled

request_info.content = b'{"requests": [{"id": "8fb651a7-8f45-495c-a266-301aa14c91a4", "headers":{"Content-Type": "application/json"},"body":{ "fields": {"title": "widget", "color": "purple", }},"method": "POST", "url": "/sites/{{site_id}}/lists/{{list_id}}/items", "depends_on": []}]}'

Can you please share the payload you're currently getting for context?

[chandra447]

Hi @baywet ,
this is the actual payload of the POST method of batch_request_builder, which doesn't add the payload and the headers

Content: b'{"requests": [{"id": "1af2c34c-b891-4980-b8b8-4afef91e6086", "method": "POST", "url": "/sites/816366c1-bb5f-474c-b5f0-3ed59438300a/lists/cab71504-42b9-484d-a267-931c86c1ffc2/items", "depends_on": []}]}

[baywet]

Thank you for the additional information.

Tracing what should happen:

1. The call to BatchRequestContent calls add request information
2. Which in turns calls the item constructor
3. Which sets the body

Can you please:

1. double check the request_information1 has a content? (to check the problem is with batch and not the fluent API/models)
2. check that the batch request item has a body when you new it up from a request information with a body?