Skip to content

Commit c4256fc

Browse files
committed
- replaces adal references by msal
1 parent 9c16ecc commit c4256fc

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

constants.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
exports.adalConfiguration = {
1+
exports.msalConfiguration = {
22
authority: 'https://login.microsoftonline.com/common',
33
clientID: 'ENTER_YOUR_CLIENT_ID',
44
clientSecret: 'ENTER_YOUR_SECRET',

helpers/authHelper.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { AuthenticationContext } from 'adal-node';
1+
import * as msal from '@azure/msal-node';
22

3-
import { adalConfiguration } from '../constants';
3+
import { msalConfiguration } from '../constants';
44

55
const resource = 'https://graph.microsoft.com/';
66

@@ -9,10 +9,10 @@ const resource = 'https://graph.microsoft.com/';
99
* @return {string} a fully formed uri with which authentication can be completed.
1010
*/
1111
export function getAuthUrl() {
12-
return adalConfiguration.authority + '/oauth2/authorize'
13-
+ '?client_id=' + adalConfiguration.clientID
12+
return msalConfiguration.authority + '/oauth2/authorize'
13+
+ '?client_id=' + msalConfiguration.clientID
1414
+ '&response_type=code'
15-
+ '&redirect_uri=' + adalConfiguration.redirectUri;
15+
+ '&redirect_uri=' + msalConfiguration.redirectUri;
1616
}
1717

1818
/**
@@ -21,14 +21,14 @@ export function getAuthUrl() {
2121
* @param {AcquireTokenCallback} callback The callback function.
2222
*/
2323
export function getTokenFromCode(code) {
24-
const authContext = new AuthenticationContext(adalConfiguration.authority);
24+
const authContext = new msal.AuthenticationContext(msalConfiguration.authority);
2525
return new Promise((resolve, reject) => {
2626
authContext.acquireTokenWithAuthorizationCode(
2727
code,
28-
adalConfiguration.redirectUri,
28+
msalConfiguration.redirectUri,
2929
resource,
30-
adalConfiguration.clientID,
31-
adalConfiguration.clientSecret,
30+
msalConfiguration.clientID,
31+
msalConfiguration.clientSecret,
3232
(err, token) => {
3333
if (err) {
3434
reject(err);
@@ -41,9 +41,9 @@ export function getTokenFromCode(code) {
4141
}
4242

4343
export function getAppOnlyToken() {
44-
const authContext = new AuthenticationContext(adalConfiguration.authority.replace('common', adalConfiguration.tenantID));
44+
const authContext = new AuthenticationContext(msalConfiguration.authority.replace('common', msalConfiguration.tenantID));
4545
return new Promise((resolve, reject) => {
46-
authContext.acquireTokenWithClientCredentials(resource, adalConfiguration.clientID, adalConfiguration.clientSecret, (err, token) => {
46+
authContext.acquireTokenWithClientCredentials(resource, msalConfiguration.clientID, msalConfiguration.clientSecret, (err, token) => {
4747
if (err) {
4848
reject(err);
4949
} else {

routes/listen.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import escape from 'escape-html';
55
import { ioServer } from '../helpers/socketHelper';
66
import { SubscriptionManagementService } from '../helpers/requestHelper';
77
import { getSubscription } from '../helpers/dbHelper';
8-
import { subscriptionConfiguration, certificateConfiguration, adalConfiguration } from '../constants';
8+
import { subscriptionConfiguration, certificateConfiguration, msalConfiguration } from '../constants';
99
import { decryptSymetricKey, decryptPayload, verifySignature } from '../helpers/certificateHelper';
1010
import { isTokenValid } from '../helpers/tokenHelper';
1111

@@ -43,7 +43,7 @@ listenRouter.post('/', async (req, res, next) => {
4343
// if we're receiving notifications with resource data we have to validate the origin of the request by validating the tokens
4444
let areTokensValid = true;
4545
if (req.body.validationTokens) {
46-
const validationResults = await Promise.all(req.body.validationTokens.map((x) => isTokenValid(x, adalConfiguration.clientID, adalConfiguration.tenantID)));
46+
const validationResults = await Promise.all(req.body.validationTokens.map((x) => isTokenValid(x, msalConfiguration.clientID, msalConfiguration.tenantID)));
4747
areTokensValid = validationResults.reduce((x, y) => x && y);
4848
}
4949

tests/confTest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
var assert = require('assert');
22
var conf = require('../constants');
33

4-
describe('ADAL', function () { // eslint-disable-line no-undef
4+
describe('MSAL', function () { // eslint-disable-line no-undef
55
it( // eslint-disable-line no-undef
66
'Checking clientID, clientSecret and tenantID in constants.js',
77
function () {
88
assert(
9-
isADALConfigured(conf.adalConfiguration),
9+
isMSALConfigured(conf.msalConfiguration),
1010
'\nRegister clientID. clientSecret, tenantID in file constants.js.\n'
1111
+ 'You don\'t have them? Get them by using the Office 365 app registration tool\n'
1212
+ 'http://dev.office.com/app-registration\n'
@@ -32,7 +32,7 @@ describe('NotificationURL', function () { // eslint-disable-line no-undef
3232
});
3333
});
3434

35-
function isADALConfigured(configuration) {
35+
function isMSALConfigured(configuration) {
3636
var clientIDConfigured = typeof (configuration.clientID) !== 'undefined'
3737
&& configuration.clientID !== null
3838
&& configuration.clientID !== ''

0 commit comments

Comments
 (0)