Skip to content

Commit 2484518

Browse files
Copilotrenemadsen
andcommitted
Convert 4 obsolete datetime test overrides in NorthwindWhereQueryMySqlTest
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
1 parent ab30fc9 commit 2484518

File tree

1 file changed

+26
-8
lines changed

1 file changed

+26
-8
lines changed

test/EFCore.MySql.FunctionalTests/Query/NorthwindWhereQueryMySqlTest.cs

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,14 @@ public NorthwindWhereQueryMySqlTest(
2424
}
2525

2626
[ConditionalTheory]
27-
public override async Task Where_datetime_now(bool async)
27+
[MemberData(nameof(IsAsyncData))]
28+
public virtual async Task Where_datetime_now(bool async)
2829
{
29-
await base.Where_datetime_now(async);
30+
var myDatetime = new DateTime(2015, 4, 10);
31+
32+
await AssertQuery(
33+
async,
34+
ss => ss.Set<Customer>().Where(c => DateTime.Now != myDatetime));
3035

3136
AssertSql(
3237
@"@__myDatetime_0='2015-04-10T00:00:00.0000000' (DbType = DateTime)
@@ -37,9 +42,14 @@ public override async Task Where_datetime_now(bool async)
3742
}
3843

3944
[ConditionalTheory]
40-
public override async Task Where_datetime_utcnow(bool async)
45+
[MemberData(nameof(IsAsyncData))]
46+
public virtual async Task Where_datetime_utcnow(bool async)
4147
{
42-
await base.Where_datetime_utcnow(async);
48+
var myDatetime = new DateTime(2015, 4, 10);
49+
50+
await AssertQuery(
51+
async,
52+
ss => ss.Set<Customer>().Where(c => DateTime.UtcNow != myDatetime));
4353

4454
AssertSql(
4555
@"@__myDatetime_0='2015-04-10T00:00:00.0000000' (DbType = DateTime)
@@ -50,9 +60,12 @@ public override async Task Where_datetime_utcnow(bool async)
5060
}
5161

5262
[ConditionalTheory]
53-
public override async Task Where_datetime_today(bool async)
63+
[MemberData(nameof(IsAsyncData))]
64+
public virtual async Task Where_datetime_today(bool async)
5465
{
55-
await base.Where_datetime_today(async);
66+
await AssertQuery(
67+
async,
68+
ss => ss.Set<Employee>().Where(e => DateTime.Now.Date == DateTime.Today));
5669

5770
AssertSql(
5871
@"SELECT `e`.`EmployeeID`, `e`.`City`, `e`.`Country`, `e`.`FirstName`, `e`.`ReportsTo`, `e`.`Title`
@@ -61,9 +74,14 @@ public override async Task Where_datetime_today(bool async)
6174
}
6275

6376
[ConditionalTheory]
64-
public override async Task Where_datetime_date_component(bool async)
77+
[MemberData(nameof(IsAsyncData))]
78+
public virtual async Task Where_datetime_date_component(bool async)
6579
{
66-
await base.Where_datetime_date_component(async);
80+
var myDatetime = new DateTime(1998, 5, 4);
81+
82+
await AssertQuery(
83+
async,
84+
ss => ss.Set<Order>().Where(o => o.OrderDate.Value.Date == myDatetime));
6785

6886
AssertSql(
6987
@"@__myDatetime_0='1998-05-04T00:00:00.0000000' (DbType = DateTime)

0 commit comments

Comments
 (0)