Skip to content

Commit 4ec668d

Browse files
Copilotrenemadsen
andcommitted
Add complete test method overrides with proper SQL assertions
- Added Final_GroupBy_TagWith override to NorthwindGroupByQueryMySqlTest.cs with MySQL SQL - Added Where_simple_closure override to NorthwindWhereQueryMySqlTest.cs with MySQL SQL - Both methods now pass Check_all_tests_overridden validation - All related tests pass successfully Co-authored-by: renemadsen <[email protected]>
1 parent 8efb522 commit 4ec668d

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

test/EFCore.MySql.FunctionalTests/Query/NorthwindGroupByQueryMySqlTest.cs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3796,7 +3796,14 @@ public override async Task Final_GroupBy_TagWith(bool async)
37963796
{
37973797
await base.Final_GroupBy_TagWith(async);
37983798

3799-
AssertSql();
3799+
AssertSql(
3800+
"""
3801+
-- foo
3802+
3803+
SELECT `c`.`City`, `c`.`CustomerID`, `c`.`Address`, `c`.`CompanyName`, `c`.`ContactName`, `c`.`ContactTitle`, `c`.`Country`, `c`.`Fax`, `c`.`Phone`, `c`.`PostalCode`, `c`.`Region`
3804+
FROM `Customers` AS `c`
3805+
ORDER BY `c`.`City`
3806+
""");
38003807
}
38013808

38023809
[ConditionalFact]

test/EFCore.MySql.FunctionalTests/Query/NorthwindWhereQueryMySqlTest.cs

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -513,11 +513,20 @@ public override async Task Where_simple(bool async)
513513

514514
}
515515

516-
public override void Where_simple_closure()
516+
public override async Task<string> Where_simple_closure(bool async)
517517
{
518-
base.Where_simple_closure();
518+
var result = await base.Where_simple_closure(async);
519519

520-
AssertSql();
520+
AssertSql(
521+
"""
522+
@city='London' (Size = 15)
523+
524+
SELECT `c`.`CustomerID`, `c`.`Address`, `c`.`City`, `c`.`CompanyName`, `c`.`ContactName`, `c`.`ContactTitle`, `c`.`Country`, `c`.`Fax`, `c`.`Phone`, `c`.`PostalCode`, `c`.`Region`
525+
FROM `Customers` AS `c`
526+
WHERE `c`.`City` = @city
527+
""");
528+
529+
return result;
521530
}
522531

523532
public override async Task Where_indexer_closure(bool async)

0 commit comments

Comments
 (0)