Skip to content

Commit 581acd2

Browse files
authored
Merge pull request #111 from microting/copilot/fix-test-class-constructors
Fix multiple public constructors for xUnit v3 compatibility
2 parents b87e6f3 + 0ffb2d7 commit 581acd2

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

test/EFCore.MySql.FunctionalTests/Query/EntitySplittingQueryMySqlTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Pomelo.EntityFrameworkCore.MySql.FunctionalTests.Query;
1010

1111
public class EntitySplittingQueryMySqlTest(NonSharedFixture fixture) : EntitySplittingQueryTestBase(fixture)
1212
{
13-
public EntitySplittingQueryMySqlTest(ITestOutputHelper testOutputHelper) : this(new NonSharedFixture())
13+
internal EntitySplittingQueryMySqlTest(ITestOutputHelper testOutputHelper) : this(new NonSharedFixture())
1414
{
1515
// Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
1616
}

test/EFCore.MySql.FunctionalTests/TestUtilities/TestMySqlRetryingExecutionStrategy.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class TestMySqlRetryingExecutionStrategy : MySqlRetryingExecutionStrategy
2020
42019 // CREATE DATABASE operation failed
2121
};
2222

23-
public TestMySqlRetryingExecutionStrategy()
23+
internal TestMySqlRetryingExecutionStrategy()
2424
: base(
2525
new DbContext(
2626
new DbContextOptionsBuilder()
@@ -30,12 +30,12 @@ public TestMySqlRetryingExecutionStrategy()
3030
{
3131
}
3232

33-
public TestMySqlRetryingExecutionStrategy(DbContext context)
33+
internal TestMySqlRetryingExecutionStrategy(DbContext context)
3434
: base(context, DefaultMaxRetryCount, DefaultMaxDelay, _additionalErrorNumbers)
3535
{
3636
}
3737

38-
public TestMySqlRetryingExecutionStrategy(DbContext context, TimeSpan maxDelay)
38+
internal TestMySqlRetryingExecutionStrategy(DbContext context, TimeSpan maxDelay)
3939
: base(context, DefaultMaxRetryCount, maxDelay, _additionalErrorNumbers)
4040
{
4141
}

test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlConditionalFactTestCase.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using System.ComponentModel;
23
using System.Threading;
34
using System.Threading.Tasks;
45
using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
@@ -13,6 +14,7 @@ namespace Pomelo.EntityFrameworkCore.MySql.FunctionalTests.TestUtilities.Xunit
1314
public sealed class MySqlConditionalFactTestCase : XunitTestCase
1415
{
1516
[Obsolete("Called by the de-serializer; should only be called by deriving classes for de-serialization purposes")]
17+
[EditorBrowsable(EditorBrowsableState.Never)]
1618
public MySqlConditionalFactTestCase()
1719
{
1820
}

test/EFCore.MySql.FunctionalTests/TestUtilities/Xunit/MySqlConditionalTheoryTestCase.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using System.ComponentModel;
23
using System.Threading;
34
using System.Threading.Tasks;
45
using Microsoft.EntityFrameworkCore.TestUtilities.Xunit;
@@ -13,6 +14,7 @@ namespace Pomelo.EntityFrameworkCore.MySql.FunctionalTests.TestUtilities.Xunit
1314
public sealed class MySqlConditionalTheoryTestCase : XunitTheoryTestCase
1415
{
1516
[Obsolete("Called by the de-serializer; should only be called by deriving classes for de-serialization purposes")]
17+
[EditorBrowsable(EditorBrowsableState.Never)]
1618
public MySqlConditionalTheoryTestCase()
1719
{
1820
}

0 commit comments

Comments
 (0)