Fix UInt64 enum tests to use consistent MySQL format with MariaDB runtime adjustment

Simplified the test approach:
1. Non-nullable test: Both Max test cases now start with MySQL format {"Prop":-1} and adjust to {"Prop":18446744073709551615} only on MariaDB
2. Nullable test: Changed InlineData from ulong literals to EnumU64 enum values to fix xUnit type conversion error

The key changes:
- Line 64: Changed numeric literal from MariaDB format to MySQL format {"Prop":-1}
- Line 68-77: Simplified logic to only adjust when on MariaDB and JSON is "-1"
- Lines 93-100: Changed from UL literals to EnumU64 enum values (xUnit can convert these to EnumU64?)
- Line 107-111: Simplified condition to match non-nullable version

All 14 test cases (7 for each method) now pass on both MySQL and MariaDB.

Co-authored-by: renemadsen <[email protected]>

Author: Copilot

test/EFCore.MySql.FunctionalTests/Query/JsonTypesRelationalMySqlTest.cs

@@ -57,67 +57,49 @@ public override Task Can_read_write_collection_of_ulong_enum_JSON_values()
         [Theory]
         [InlineData((EnumU64)0, """{"Prop":0}""")]
         [InlineData(EnumU64.Min, """{"Prop":0}""")]
-        [InlineData(EnumU64.Max, """{"Prop":-1}""")]  // This will be adjusted for MariaDB at runtime
+        [InlineData(EnumU64.Max, """{"Prop":-1}""")]  // MySQL format - This will be adjusted for MariaDB at runtime
         [InlineData(EnumU64.Default, """{"Prop":0}""")]
         [InlineData(EnumU64.One, """{"Prop":1}""")]
         [InlineData((EnumU64)8, """{"Prop":8}""")]
-        [InlineData((EnumU64)18446744073709551615, """{"Prop":18446744073709551615}""")]  // UInt64.MaxValue as numeric literal - MariaDB format
+        [InlineData((EnumU64)18446744073709551615, """{"Prop":-1}""")]  // UInt64.MaxValue as numeric literal - MySQL format
         public new async Task Can_read_write_ulong_enum_JSON_values(EnumU64 value, string json)
         {
             // MariaDB serializes UInt64.MaxValue as "18446744073709551615" instead of "-1"
-            // For MySQL, we need to adjust the numeric literal case to expect "-1"
-            // Check if the value is UInt64.MaxValue (works for both enum and numeric literal)
+            // Adjust expectation based on database type
             if (AppConfig.ServerVersion.Type == ServerType.MariaDb)
             {
-                // On MariaDB, both EnumU64.Max and the numeric literal should use the full number format
-                if (value == EnumU64.Max)
+                // On MariaDB, adjust both test cases with -1 to use the full number
+                if (value == EnumU64.Max && json == """{"Prop":-1}""")
                 {
                     json = """{"Prop":18446744073709551615}""";
                 }
             }
-            else
-            {
-                // On MySQL, the numeric literal test case expects the full number but should be -1
-                if (value == EnumU64.Max && json == """{"Prop":18446744073709551615}""")
-                {
-                    json = """{"Prop":-1}""";
-                }
-            }
 
             await base.Can_read_write_ulong_enum_JSON_values(value, json);
         }
 
         // Provide database-aware test for nullable UInt64 enum serialization
         // Same as above but for nullable enums
         [Theory]
-        [InlineData(0UL, """{"Prop":0}""")]
-        [InlineData(0UL, """{"Prop":0}""")]  // Min
-        [InlineData(18446744073709551615UL, """{"Prop":-1}""")]  // Max - This will be adjusted for MariaDB at runtime
-        [InlineData(0UL, """{"Prop":0}""")]  // Default
-        [InlineData(1UL, """{"Prop":1}""")]  // One
-        [InlineData(8UL, """{"Prop":8}""")]
-        [InlineData(18446744073709551615UL, """{"Prop":18446744073709551615}""")]  // UInt64.MaxValue as numeric literal - MariaDB format
+        [InlineData(EnumU64.Min, """{"Prop":0}""")]
+        [InlineData((EnumU64)0, """{"Prop":0}""")]
+        [InlineData(EnumU64.Max, """{"Prop":-1}""")]  // MySQL format - This will be adjusted for MariaDB at runtime
+        [InlineData(EnumU64.Default, """{"Prop":0}""")]
+        [InlineData(EnumU64.One, """{"Prop":1}""")]
+        [InlineData((EnumU64)8, """{"Prop":8}""")]
+        [InlineData((EnumU64)18446744073709551615, """{"Prop":-1}""")]  // UInt64.MaxValue as numeric literal - MySQL format
         public async Task Can_read_write_nullable_ulong_enum_JSON_values(EnumU64? value, string json)
         {
             // MariaDB serializes UInt64.MaxValue as "18446744073709551615" instead of "-1"
-            // For MySQL, we need to adjust the numeric literal case to expect "-1"
-            // Check if the value is UInt64.MaxValue (works for both enum and numeric literal)
+            // Adjust expectation based on database type
             if (AppConfig.ServerVersion.Type == ServerType.MariaDb)
             {
-                // On MariaDB, both EnumU64.Max and the numeric literal should use the full number format
-                if (value.HasValue && (ulong)value.Value == 18446744073709551615UL)
+                // On MariaDB, adjust both test cases with -1 to use the full number
+                if (value.HasValue && value.Value == EnumU64.Max && json == """{"Prop":-1}""")
                 {
                     json = """{"Prop":18446744073709551615}""";
                 }
             }
-            else
-            {
-                // On MySQL, the numeric literal test case expects the full number but should be -1
-                if (value.HasValue && (ulong)value.Value == 18446744073709551615UL && json == """{"Prop":18446744073709551615}""")
-                {
-                    json = """{"Prop":-1}""";
-                }
-            }
 
             await base.Can_read_write_nullable_ulong_enum_JSON_values(value, json);
         }