Skip to content

Commit 67f2390

Browse files
Copilotrenemadsen
andcommitted
Convert 4 additional obsolete test overrides in NonSharedPrimitiveCollectionsQueryMySqlTest
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
1 parent 0f7ee2f commit 67f2390

File tree

1 file changed

+26
-8
lines changed

1 file changed

+26
-8
lines changed

test/EFCore.MySql.FunctionalTests/Query/NonSharedPrimitiveCollectionsQueryMySqlTest.cs

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -524,30 +524,48 @@ await AssertQuery(
524524
""");
525525
}
526526

527-
public override async Task Parameter_collection_Count_with_column_predicate_with_default_constants_EF_Parameter()
527+
[ConditionalTheory]
528+
[MemberData(nameof(IsAsyncData))]
529+
public virtual async Task Parameter_collection_Count_with_column_predicate_with_default_constants_EF_Parameter(bool async)
528530
{
529-
await base.Parameter_collection_Count_with_column_predicate_with_default_constants_EF_Parameter();
531+
await AssertQuery(
532+
async,
533+
ss => ss.Set<TestEntity>().Where(x => new[] { 2, 999 }.Count(i => i > x.Id) == 1));
530534

531535
AssertSql();
532536
}
533537

534-
public override async Task Parameter_collection_of_ints_Contains_int_with_default_constants_EF_Parameter()
538+
[ConditionalTheory]
539+
[MemberData(nameof(IsAsyncData))]
540+
public virtual async Task Parameter_collection_of_ints_Contains_int_with_default_constants_EF_Parameter(bool async)
535541
{
536-
await base.Parameter_collection_of_ints_Contains_int_with_default_constants_EF_Parameter();
542+
await AssertQuery(
543+
async,
544+
ss => ss.Set<TestEntity>().Where(x => new[] { 2, 999 }.Contains(x.Id)));
537545

538546
AssertSql();
539547
}
540548

541-
public override async Task Parameter_collection_Count_with_column_predicate_with_default_parameters()
549+
[ConditionalTheory]
550+
[MemberData(nameof(IsAsyncData))]
551+
public virtual async Task Parameter_collection_Count_with_column_predicate_with_default_parameters(bool async)
542552
{
543-
await base.Parameter_collection_Count_with_column_predicate_with_default_parameters();
553+
var ints = new[] { 2, 999 };
554+
await AssertQuery(
555+
async,
556+
ss => ss.Set<TestEntity>().Where(x => ints.Count(i => i > x.Id) == 1));
544557

545558
AssertSql();
546559
}
547560

548-
public override async Task Parameter_collection_of_ints_Contains_int_with_default_parameters()
561+
[ConditionalTheory]
562+
[MemberData(nameof(IsAsyncData))]
563+
public virtual async Task Parameter_collection_of_ints_Contains_int_with_default_parameters(bool async)
549564
{
550-
await base.Parameter_collection_of_ints_Contains_int_with_default_parameters();
565+
var ints = new[] { 2, 999 };
566+
await AssertQuery(
567+
async,
568+
ss => ss.Set<TestEntity>().Where(x => ints.Contains(x.Id)));
551569

552570
AssertSql();
553571
}

0 commit comments

Comments
 (0)