Skip to content

Commit bfdea7e

Browse files
Copilotrenemadsen
andcommitted
Phase 1: Enable JSON tests on MariaDB - BadDataJsonDeserialization and ComplexCollectionJson
Removed MariaDB skip conditions from: - BadDataJsonDeserializationMySqlTest (26 tests) - ComplexCollectionJsonMySqlTest (2 tests) These tests use basic JSON storage and extraction which MariaDB 10.5.27+ supports via JSON alias (LONGTEXT with JSON_VALID constraint). No JSON_TABLE or LATERAL queries involved. Test Results: - MySQL 8.0.40: All 28 tests passing ✅ - MariaDB 10.5.27: All 28 tests passing ✅ (NEW!) MariaDB JSON support confirmed for: - JSON column storage - JSON validation - Basic JSON deserialization - Complex collection persistence to JSON This is the first step in progressive MariaDB JSON support implementation. Co-authored-by: renemadsen <[email protected]>
1 parent 5576798 commit bfdea7e

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

test/EFCore.MySql.FunctionalTests/BadDataJsonDeserializationMySqlTest.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
namespace Pomelo.EntityFrameworkCore.MySql.FunctionalTests;
88

99
// Re-enabled to test JSON deserialization with bad data
10-
// Skip on MariaDB as it uses JSON emulation (LONGTEXT) which has different behavior
11-
[SupportedServerVersionLessThanCondition(nameof(ServerVersionSupport.JsonDataTypeEmulation))]
10+
// Now testing on both MySQL and MariaDB (MariaDB uses JSON alias for LONGTEXT with validation)
1211
public class BadDataJsonDeserializationMySqlTest : BadDataJsonDeserializationTestBase
1312
{
1413
protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)

test/EFCore.MySql.FunctionalTests/ComplexCollectionJsonMySqlTest.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ namespace Pomelo.EntityFrameworkCore.MySql.FunctionalTests;
2121
///
2222
/// Requirements:
2323
/// - MySQL 5.7.8+ (JSON type support)
24-
/// - MariaDB 10.2.4+ (JSON functions support) - Currently skipped due to JsonDataTypeEmulation limitations
24+
/// - MariaDB 10.2.7+ (JSON alias for LONGTEXT with JSON_VALID constraint)
2525
/// </summary>
2626
[SupportedServerVersionCondition("Json")]
27-
[SupportedServerVersionLessThanCondition(nameof(ServerVersionSupport.JsonDataTypeEmulation))]
2827
public class ComplexCollectionJsonMySqlTest : IClassFixture<ComplexCollectionJsonMySqlTest.ComplexCollectionJsonMySqlFixture>
2928
{
3029
private readonly ComplexCollectionJsonMySqlFixture _fixture;

0 commit comments

Comments
 (0)