Merge branch 'master' into net10

Author: renemadsen

.github/copilot-instructions.md

@@ -0,0 +1,139 @@
+# Pomelo.EntityFrameworkCore.MySql
+
+Pomelo.EntityFrameworkCore.MySql is the most popular Entity Framework Core provider for MySQL compatible databases. It supports EF Core 10.0 and uses MySqlConnector for high-performance database server communication. The repository contains multiple NuGet packages and a comprehensive test suite.
+
+Always reference these instructions first and only fallback to search or bash commands when you encounter unexpected information that does not match the info here.
+
+## Working Effectively
+
+### Prerequisites and Setup
+- Install .NET 10.0.100 SDK: `curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --version 10.0.100`
+- Add to PATH: `export PATH="$HOME/.dotnet:$PATH"`
+- Install EF Core tools: `dotnet tool restore` (takes ~1-2 seconds)
+- **CRITICAL**: Create `/tmp/nuget.config` with clean NuGet sources due to network access issues:
+  ```xml
+  <?xml version="1.0" encoding="utf-8"?>
+  <configuration>
+    <packageSources>
+      <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
+      <add key="dotnet9" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
+    </packageSources>
+    <config>
+      <add key="disableNugetaudit" value="true" />
+    </config>
+  </configuration>
+  ```
+
+### Build Commands (All Validated and Timed)
+- **Package restore**: `dotnet restore --configfile /tmp/nuget.config --disable-parallel --no-cache --property WarningsAsErrors= --property TreatWarningsAsErrors=false` (takes ~2 seconds)
+- **Debug build**: `dotnet build -c Debug --no-restore` (takes ~4 seconds). NEVER CANCEL: Set timeout to 10+ minutes.
+- **Release build**: `dotnet build -c Release --no-restore` (takes ~11 seconds). NEVER CANCEL: Set timeout to 15+ minutes.
+- **Setup test configs**: Required before building - copy example config files:
+  ```bash
+  cp test/EFCore.MySql.FunctionalTests/config.json.example test/EFCore.MySql.FunctionalTests/config.json
+  cp test/EFCore.MySql.IntegrationTests/config.json.example test/EFCore.MySql.IntegrationTests/config.json
+  ```
+
+### Test Suite Overview
+The repository has multiple test projects with different database requirements:
+
+- **EFCore.MySql.Tests** (77 tests): True unit tests, NO database required. Takes ~3 seconds.
+- **EFCore.MySql.FunctionalTests**: Database integration tests. REQUIRES MySQL database.
+- **EFCore.MySql.IntegrationTests**: Full application integration tests with ASP.NET Core. REQUIRES MySQL database and complex setup.
+
+### Database Setup for Tests
+**CRITICAL**: Most tests require MySQL database setup:
+```bash
+# Start MySQL container (matches CI setup)
+docker run --name mysql_test -e MYSQL_ROOT_PASSWORD=Password12! -p 127.0.0.1:3306:3306 -d mysql:8.0.40
+
+# Wait for MySQL to be ready (~30 seconds)
+while ! docker exec mysql_test mysql --protocol=tcp -h localhost -P 3306 -u root -pPassword12! -e 'select 1;' &>/dev/null; do
+  echo "Waiting for MySQL..."
+  sleep 2
+done
+echo "MySQL is ready!"
+```
+
+### Running Tests (Validated Timings)
+- **Unit tests only**: `dotnet test test/EFCore.MySql.Tests -c Debug --no-build --logger "console;verbosity=minimal"` (takes ~3 seconds, 77 tests)
+- **Small functional test subset**: Takes ~8-9 seconds per test class
+- **Full test suites**: NEVER CANCEL - Can take 20-45 minutes. Set timeout to 60+ minutes.
+
+**WARNING**: The full test suite includes hundreds of tests across multiple projects. Each functional/integration test requires database connections and can be slow. Plan accordingly.
+
+### EF Core Tools
+- **Verify tools**: `dotnet ef --version` (should show version 10.0.0)
+- **Scaffolding**: `dotnet ef dbcontext scaffold "<connection-string>" "Pomelo.EntityFrameworkCore.MySql" --output-dir <dir> --context <ContextName> --force`
+- **Migration commands**: Available but require properly configured DbContext
+
+### Integration Test Setup
+The integration tests require additional setup:
+```bash
+# Integration tests have setup scripts (PowerShell)
+./test/EFCore.MySql.IntegrationTests/scripts/rebuild.ps1
+```
+**NOTE**: Integration test setup takes ~45+ seconds and may have complex dependencies.
+
+## Validation
+- **Always run unit tests** after making changes: `dotnet test test/EFCore.MySql.Tests` (~3 seconds)
+- **Test database connectivity** before running functional tests: Ensure MySQL container is running and accessible
+- **Never run full test suite** unless specifically needed - it takes 20-45+ minutes
+- **Build verification**: Always build both Debug and Release configurations to ensure compatibility
+
+## Common Issues and Workarounds
+- **Package restore failures**: Default NuGet.config references unreachable MyGet sources. Use the clean config provided above.
+- **Package vulnerability warnings**: Treated as errors. Disable with `--property TreatWarningsAsErrors=false`
+- **Test failures without database**: Functional and integration tests will fail if MySQL is not running
+- **Network restrictions**: If external package sources are blocked, use `--ignore-failed-sources` with dotnet restore
+
+## Repository Structure
+Key projects:
+- `src/EFCore.MySql/`: Main Entity Framework provider library
+- `src/EFCore.MySql.Json.Microsoft/`: Microsoft System.Text.Json support
+- `src/EFCore.MySql.Json.Newtonsoft/`: Newtonsoft.Json support  
+- `src/EFCore.MySql.NTS/`: NetTopologySuite spatial support
+- `test/EFCore.MySql.Tests/`: Unit tests (77 tests, ~3 seconds)
+- `test/EFCore.MySql.FunctionalTests/`: Database integration tests
+- `test/EFCore.MySql.IntegrationTests/`: Full ASP.NET Core integration tests
+
+## Key Commands Reference (Copy-Paste Ready)
+```bash
+# Complete setup from fresh clone
+export PATH="$HOME/.dotnet:$PATH"
+curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --version 10
+export PATH="$HOME/.dotnet:$PATH"
+
+# Create clean NuGet config
+cat > /tmp/nuget.config << 'EOF'
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <packageSources>
+    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
+  </packageSources>
+  <config>
+    <add key="disableNugetaudit" value="true" />
+  </config>
+</configuration>
+EOF
+
+# Install tools and restore packages
+dotnet tool restore
+dotnet restore --configfile /tmp/nuget.config --disable-parallel --no-cache --property WarningsAsErrors= --property TreatWarningsAsErrors=false
+
+# Setup test configurations
+cp test/EFCore.MySql.FunctionalTests/config.json.example test/EFCore.MySql.FunctionalTests/config.json
+cp test/EFCore.MySql.IntegrationTests/config.json.example test/EFCore.MySql.IntegrationTests/config.json
+
+# Build (NEVER CANCEL - set 15+ minute timeout)
+dotnet build -c Debug --no-restore
+dotnet build -c Release --no-restore
+
+# Quick validation (unit tests only)
+dotnet test test/EFCore.MySql.Tests -c Debug --no-build --logger "console;verbosity=minimal"
+
+# For database tests, setup MySQL first:
+docker run --name mysql_test -e MYSQL_ROOT_PASSWORD=Password12! -p 127.0.0.1:3306:3306 -d mysql:8.0.40
+```
+
+Always use these exact commands for consistent results. Never skip the NuGet configuration step as it resolves critical network access issues.

.github/workflows/build.yml

@@ -23,19 +23,83 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        dbVersion:
-          - 8.4.3-mysql
-          - 8.0.40-mysql
-          - 11.6.2-mariadb
-          - 11.5.2-mariadb
-          - 11.4.4-mariadb
-          - 11.3.2-mariadb
-          - 10.11.10-mariadb
-          - 10.6.20-mariadb
-          - 10.5.27-mariadb
-        os:
-          - ubuntu-latest
-          - windows-latest
+        include:
+          # MySQL 9.5.x - Ubuntu only (Windows package not available yet)
+          - dbVersion: 9.5.0-mysql
+            os: ubuntu-latest
+          # MySQL 9.x - Both platforms
+          - dbVersion: 9.4.0-mysql
+            os: ubuntu-latest
+          - dbVersion: 9.4.0-mysql
+            os: windows-latest
+          - dbVersion: 9.3.0-mysql
+            os: ubuntu-latest
+          - dbVersion: 9.3.0-mysql
+            os: windows-latest
+          - dbVersion: 9.2.0-mysql
+            os: ubuntu-latest
+          - dbVersion: 9.2.0-mysql
+            os: windows-latest
+          - dbVersion: 9.1.0-mysql
+            os: ubuntu-latest
+          - dbVersion: 9.1.0-mysql
+            os: windows-latest
+          - dbVersion: 9.0.1-mysql
+            os: ubuntu-latest
+          - dbVersion: 9.0.1-mysql
+            os: windows-latest
+          # MySQL 8.x - Both platforms
+          - dbVersion: 8.4.3-mysql
+            os: ubuntu-latest
+          - dbVersion: 8.4.3-mysql
+            os: windows-latest
+          - dbVersion: 8.0.40-mysql
+            os: ubuntu-latest
+          - dbVersion: 8.0.40-mysql
+            os: windows-latest
+          # MariaDB 11.8+ - Ubuntu only (Windows package not available yet)
+          - dbVersion: 11.8.5-mariadb
+            os: ubuntu-latest
+          # MariaDB 11.7.x - Both platforms (different patch versions)
+          - dbVersion: 11.7.2-mariadb
+            os: ubuntu-latest
+          - dbVersion: 11.7.1-mariadb
+            os: windows-latest
+          # MariaDB 11.x - Both platforms
+          - dbVersion: 11.6.2-mariadb
+            os: ubuntu-latest
+          - dbVersion: 11.6.2-mariadb
+            os: windows-latest
+          - dbVersion: 11.5.2-mariadb
+            os: ubuntu-latest
+          - dbVersion: 11.5.2-mariadb
+            os: windows-latest
+          - dbVersion: 11.4.4-mariadb
+            os: ubuntu-latest
+          - dbVersion: 11.4.4-mariadb
+            os: windows-latest
+          - dbVersion: 11.3.2-mariadb
+            os: ubuntu-latest
+          - dbVersion: 11.3.2-mariadb
+            os: windows-latest
+          # MariaDB 10.x - Both platforms
+          - dbVersion: 10.11.10-mariadb
+            os: ubuntu-latest
+          - dbVersion: 10.11.10-mariadb
+            os: windows-latest
+          - dbVersion: 10.6.20-mariadb
+            os: ubuntu-latest
+          - dbVersion: 10.6.20-mariadb
+            os: windows-latest
+          - dbVersion: 10.5.27-mariadb
+            os: ubuntu-latest
+          - dbVersion: 10.5.27-mariadb
+            os: windows-latest
+          # MariaDB 12.x - Ubuntu only (Windows packages not available yet)
+          - dbVersion: 12.1.2-mariadb
+            os: ubuntu-latest
+          - dbVersion: 12.0.2-mariadb
+            os: ubuntu-latest
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout
@@ -104,6 +168,12 @@ jobs:
         with:
           path: ${{ env.windowsUserTempLocation }}\Pomelo.Chocolatey.${{ env.databaseServerType }}.Server
           key: database-windows-${{ env.databaseServerType }}-${{ env.databaseServerVersion }}-v3
+      - name: Prepare certs & NuGet env
+        if: ${{ env.os == 'linux' }}
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y ca-certificates
+          echo "NUGET_CERT_REVOCATION_MODE=offline" >> $GITHUB_ENV
       - name: Install Database Server - Linux
         if: ${{ env.os == 'linux' }}
         shell: pwsh
@@ -213,6 +283,78 @@ jobs:
         shell: pwsh
         run: |
           dotnet --info
+      - name: Fix MSB4276 - Create missing WorkloadAutoImportPropsLocator SDK
+        shell: pwsh
+        run: |
+          $sdkPath = dotnet --info | Select-String "Base Path:\s+(.+)" | ForEach-Object { $_.Matches.Groups[1].Value.Trim() }
+          $workloadSdkPath = Join-Path $sdkPath "Sdks/Microsoft.NET.SDK.WorkloadAutoImportPropsLocator"
+          
+          if (-not (Test-Path $workloadSdkPath)) {
+            Write-Host "Creating missing WorkloadAutoImportPropsLocator SDK at: $workloadSdkPath"
+            New-Item -ItemType Directory -Path "$workloadSdkPath/Sdk" -Force | Out-Null
+            
+            # Create Sdk.props
+            $sdkPropsContent = @'
+          <!--
+          ***********************************************************************************************
+          Sdk.props
+          
+          WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and have
+                    created a backup copy.  Incorrect changes to this file will make it
+                    impossible to load or build your projects from the command-line or the IDE.
+          
+          Copyright (c) .NET Foundation. All rights reserved.
+          ***********************************************************************************************
+          -->
+          <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+          </Project>
+          '@
+            $sdkPropsContent | Out-File -FilePath "$workloadSdkPath/Sdk/Sdk.props" -Encoding UTF8 -NoNewline
+            
+            # Create Sdk.targets
+            $sdkTargetsContent = @'
+          <!--
+          ***********************************************************************************************
+          Sdk.targets
+          
+          WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and have
+                    created a backup copy.  Incorrect changes to this file will make it
+                    impossible to load or build your projects from the command-line or the IDE.
+          
+          Copyright (c) .NET Foundation. All rights reserved.
+          ***********************************************************************************************
+          -->
+          <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+          </Project>
+          '@
+            $sdkTargetsContent | Out-File -FilePath "$workloadSdkPath/Sdk/Sdk.targets" -Encoding UTF8 -NoNewline
+            
+            # Create AutoImport.props
+            $autoImportContent = @'
+          <!--
+          ***********************************************************************************************
+          AutoImport.props
+          
+          WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and have
+                    created a backup copy.  Incorrect changes to this file will make it
+                    impossible to load or build your projects from the command-line or the IDE.
+          
+          This file is auto-imported by Microsoft.NET.Sdk.ImportWorkloads.props
+          to import workload-specific props files.
+          
+          Copyright (c) .NET Foundation. All rights reserved.
+          ***********************************************************************************************
+          -->
+          <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+            <!-- This file imports workload props. For now it's empty as no workloads require auto-import props. -->
+          </Project>
+          '@
+            $autoImportContent | Out-File -FilePath "$workloadSdkPath/Sdk/AutoImport.props" -Encoding UTF8 -NoNewline
+            
+            Write-Host "Successfully created WorkloadAutoImportPropsLocator SDK"
+          } else {
+            Write-Host "WorkloadAutoImportPropsLocator SDK already exists at: $workloadSdkPath"
+          }
       - name: Install EF Core Tools
         shell: pwsh
         run: |