Address code review feedback: make icon optional and use CSS class

Co-authored-by: renemadsen <[email protected]>

Author: Copilot

eform-client/src/app/common/models/navigation-menu/navigation-menu.model.ts

@@ -18,7 +18,7 @@ export class NavigationMenuTemplateItemModel {
   link: string;
   collapsed: boolean;
   translations: NavigationMenuTranslationModel[];
-  icon: string;
+  icon?: string;
 }
 
 export class NavigationMenuItemModel {
@@ -35,7 +35,7 @@ export class NavigationMenuItemModel {
   securityGroupsIds: number[];
   translations: NavigationMenuTranslationModel[];
   isInternalLink: boolean = true;
-  icon: string;
+  icon?: string;
 }
 
 export class NavigationMenuTranslationModel {

eform-client/src/app/components/navigation/navigation.component.html

@@ -39,7 +39,7 @@
             matTreeNodeToggle
             [id]="node.e2EId"
           >
-            <mat-icon *ngIf="node.icon" class="menu-icon" style="vertical-align: middle; margin-right: 8px;">{{ node.icon }}</mat-icon>
+            <mat-icon *ngIf="node.icon" class="menu-icon">{{ node.icon }}</mat-icon>
             <span style="">{{node.name}}</span>
           </a>
         </mat-expansion-panel-header>

eform-client/src/app/components/navigation/navigation.component.scss

@@ -60,3 +60,8 @@ mat-tree {
     line-height: 18px
   }
 }
+
+.menu-icon {
+  vertical-align: middle;
+  margin-right: 8px;
+}