Skip to content

Commit 6ccf392

Browse files
renemadsenrenemadsen
authored
Merge pull request #7273 from microting/copilot/fix-delete-drag-edit
Fix HTTP method mismatch and remove unnecessary intercepts in navigation menu Cypress tests
2 parents ed47679 + 26575df commit 6ccf392

File tree

3 files changed

+10
-20
lines changed

3 files changed

+10
-20
lines changed

‎eform-client/cypress/e2e/c/navigation-menu.delete-item.spec.cy.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ describe('Navigation menu - Delete item', function () {
4141
navigationMenuPage.getDropdownBodyChilds(currentCount - 1).should('have.length', 3);
4242

4343
// Save menu
44-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
44+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
4545
navigationMenuPage.clickSaveMenuBtn();
4646
cy.wait('@saveMenu', { timeout: 30000 });
4747
});
@@ -58,7 +58,7 @@ describe('Navigation menu - Delete item', function () {
5858
navigationMenuPage.deleteElementFromDropdown(menuItemsCount - 1, 0);
5959
navigationMenuPage.deleteElementFromDropdown(menuItemsCount - 1, 0);
6060

61-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu1');
61+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu1');
6262
navigationMenuPage.clickSaveMenuBtn();
6363
cy.wait('@saveMenu1', { timeout: 30000 });
6464

@@ -72,7 +72,7 @@ describe('Navigation menu - Delete item', function () {
7272
navigationMenuPage.getMenuItems().its('length').then(currentCount => {
7373
navigationMenuPage.deleteElementFromMenuItems(currentCount - 1); // delete created dropdown
7474

75-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu2');
75+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu2');
7676
navigationMenuPage.clickSaveMenuBtn();
7777
cy.wait('@saveMenu2', { timeout: 30000 });
7878

‎eform-client/cypress/e2e/c/navigation-menu.drag-item.spec.cy.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ describe('Navigation menu - Drag item', function () {
5858
navigationMenuPage.editTranslationsOnDropdownBodyChilds(data);
5959
});
6060

61-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
61+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
6262
navigationMenuPage.clickSaveMenuBtn();
6363
cy.wait('@saveMenu', { timeout: 30000 });
6464

@@ -74,9 +74,7 @@ describe('Navigation menu - Drag item', function () {
7474
.should('have.value', translation);
7575
});
7676

77-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
7877
navigationMenuPage.editItemSave();
79-
cy.wait('@saveMenuEdit', { timeout: 30000 });
8078
});
8179
});
8280
});
@@ -86,7 +84,7 @@ describe('Navigation menu - Drag item', function () {
8684
// Swap elements within dropdown
8785
navigationMenuPage.dragAndDropElementOfDropdown(menuCount, 2, 0);
8886

89-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
87+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
9088
navigationMenuPage.clickSaveMenuBtn();
9189
cy.wait('@saveMenu', { timeout: 30000 });
9290

‎eform-client/cypress/e2e/c/navigation-menu.edit-item.spec.cy.ts‎

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('Navigation menu - Edit item', function () {
2323

2424
navigationMenuPage.getMenuItems().should('have.length', initialCount + 1);
2525

26-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
26+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
2727
navigationMenuPage.clickSaveMenuBtn();
2828
cy.wait('@saveMenu', { timeout: 30000 });
2929
});
@@ -41,7 +41,7 @@ describe('Navigation menu - Edit item', function () {
4141
navigationMenuPage.getMenuItems().its('length').then(count => {
4242
navigationMenuPage.editCustomLink(customLink, count - 1);
4343

44-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
44+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
4545
navigationMenuPage.clickSaveMenuBtn();
4646
cy.wait('@saveMenu', { timeout: 30000 });
4747

@@ -60,9 +60,7 @@ describe('Navigation menu - Edit item', function () {
6060
cy.get(`#editItemTranslation${count - 1}_0_${i}`).should('have.value', translation);
6161
});
6262

63-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
6463
navigationMenuPage.editItemSave();
65-
cy.wait('@saveMenuEdit', { timeout: 30000 });
6664
});
6765
});
6866

@@ -78,7 +76,7 @@ describe('Navigation menu - Edit item', function () {
7876

7977
navigationMenuPage.getMenuItems().should('have.length', initialCount + 1);
8078

81-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
79+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
8280
navigationMenuPage.clickSaveMenuBtn();
8381
cy.wait('@saveMenu', { timeout: 30000 });
8482
});
@@ -93,7 +91,7 @@ describe('Navigation menu - Edit item', function () {
9391
navigationMenuPage.getMenuItems().its('length').then(count => {
9492
navigationMenuPage.editCustomDropdown(dropdown, count - 1);
9593

96-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
94+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
9795
navigationMenuPage.clickSaveMenuBtn();
9896
cy.wait('@saveMenu', { timeout: 30000 });
9997

@@ -109,9 +107,7 @@ describe('Navigation menu - Edit item', function () {
109107
cy.get(`#editItemTranslation${count - 1}_0_${i}`).should('have.value', translation);
110108
});
111109

112-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
113110
navigationMenuPage.editItemSave();
114-
cy.wait('@saveMenuEdit', { timeout: 30000 });
115111
});
116112
});
117113

@@ -122,7 +118,7 @@ describe('Navigation menu - Edit item', function () {
122118

123119
navigationMenuPage.getMenuItems().should('have.length', initialCount + 1);
124120

125-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenu');
121+
cy.intercept('PUT', '**/api/navigation-menu').as('saveMenu');
126122
navigationMenuPage.clickSaveMenuBtn();
127123
cy.wait('@saveMenu', { timeout: 30000 });
128124

@@ -142,9 +138,7 @@ describe('Navigation menu - Edit item', function () {
142138

143139
cy.get('#editLinkInput').should('have.value', data.link);
144140

145-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
146141
navigationMenuPage.editItemSave();
147-
cy.wait('@saveMenuEdit', { timeout: 30000 });
148142
});
149143

150144
it('element must be updated on translation fields', () => {
@@ -164,9 +158,7 @@ describe('Navigation menu - Edit item', function () {
164158
}
165159
});
166160

167-
cy.intercept('POST', '**/api/navigation-menu').as('saveMenuEdit');
168161
navigationMenuPage.editItemSave();
169-
cy.wait('@saveMenuEdit', { timeout: 30000 });
170162
});
171163

172164
afterEach(() => {

0 commit comments

Comments
 (0)