Replace spinner waits with API intercepts in device-users and workers tests

Co-authored-by: renemadsen <[email protected]>

Author: Copilot

eform-client/cypress/e2e/d/device-users.add.spec.cy.ts

@@ -28,8 +28,10 @@ describe('Device users page - Add new device user', function () {
       cy.get('#newDeviceUserBtn').should('be.visible').click();
       cy.get('#firstName').should('be.visible').type(nameDeviceUser);
       cy.get('#lastName').should('be.visible').type(surname);
+      
+      cy.intercept('POST', '**/api/device-users/create').as('createUser');
       cy.get('#saveCreateBtn').should('be.visible').should('be.enabled').click();
-      cy.get('#spinner-animation').should('not.exist');
+      cy.wait('@createUser', { timeout: 30000 });
       cy.get('#newDeviceUserBtn').should('be.visible');
 
       // Verify the user was created
@@ -116,9 +118,10 @@ describe('Device users page - Should not add new device user', function () {
     // Find and delete the test user
     cy.get('#deviceUserFirstName').each(($el, index) => {
       if ($el.text() === nameDeviceUser) {
+        cy.intercept('POST', '**/api/device-users/delete').as('deleteUser');
         cy.get('#deleteDeviceUserBtn').eq(index).click();
         cy.get('#saveDeleteBtn').should('be.visible').click();
-        cy.get('#spinner-animation').should('not.exist');
+        cy.wait('@deleteUser', { timeout: 30000 });
         cy.get('#newDeviceUserBtn').should('be.visible');
         return false; // break the loop
       }

eform-client/cypress/e2e/d/device-users.delete.spec.cy.ts

@@ -17,8 +17,10 @@ describe('Device users page - Delete device user', function () {
     cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible').click();
     cy.get('#firstName').should('be.visible').type(firstName);
     cy.get('#lastName').should('be.visible').type(lastName);
+    
+    cy.intercept('POST', '**/api/device-users/create').as('createUser');
     cy.get('#saveCreateBtn').should('be.visible').click();
-    cy.get('#spinner-animation').should('not.exist');
+    cy.wait('@createUser', { timeout: 30000 });
     cy.get('#newDeviceUserBtn').should('be.visible');
   });
 
@@ -47,9 +49,10 @@ describe('Device users page - Delete device user', function () {
       cy.get('#deviceUserId').should('be.visible');
 
       // Click delete button on last row
+      cy.intercept('POST', '**/api/device-users/delete').as('deleteUser');
       cy.get('#deleteDeviceUserBtn').last().should('be.visible').click();
       cy.get('#saveDeleteBtn').should('be.visible').click();
-      cy.get('#spinner-animation').should('not.exist');
+      cy.wait('@deleteUser', { timeout: 30000 });
 
       // Navigate back to device users page
       deviceUsersPage.Navbar.goToDeviceUsersPage();

eform-client/cypress/e2e/d/device-users.edit.spec.cy.ts

@@ -17,8 +17,10 @@ describe('Device users page - Edit device user', function () {
     cy.get('#newDeviceUserBtn', { timeout: 10000 }).should('be.visible').click();
     cy.get('#firstName').should('be.visible').type(firstName);
     cy.get('#lastName').should('be.visible').type(lastName);
+    
+    cy.intercept('POST', '**/api/device-users/create').as('createUser');
     cy.get('#saveCreateBtn').should('be.visible').click();
-    cy.get('#spinner-animation').should('not.exist');
+    cy.wait('@createUser', { timeout: 30000 });
     cy.get('#newDeviceUserBtn').should('be.visible');
   });
 
@@ -37,8 +39,10 @@ describe('Device users page - Edit device user', function () {
 
         // Edit first name
         cy.get('#firstName').clear().type(newName);
+        
+        cy.intercept('POST', '**/api/device-users/update').as('updateUser');
         cy.get('#saveEditBtn').should('be.visible').click();
-        cy.get('#spinner-animation').should('not.exist');
+        cy.wait('@updateUser', { timeout: 30000 });
         cy.get('#newDeviceUserBtn').should('be.visible');
 
         // Verify changes
@@ -62,8 +66,10 @@ describe('Device users page - Edit device user', function () {
 
       // Edit last name
       cy.get('#lastName').clear().type(newSurname);
+      
+      cy.intercept('POST', '**/api/device-users/update').as('updateUser');
       cy.get('#saveEditBtn').should('be.visible').click();
-      cy.get('#spinner-animation').should('not.exist');
+      cy.wait('@updateUser', { timeout: 30000 });
       cy.get('#newDeviceUserBtn').should('be.visible');
 
       // Verify changes
@@ -85,8 +91,10 @@ describe('Device users page - Edit device user', function () {
     // Edit both fields
     cy.get('#firstName').clear().type(newName);
     cy.get('#lastName').clear().type(newSurname);
+    
+    cy.intercept('POST', '**/api/device-users/update').as('updateUser');
     cy.get('#saveEditBtn').should('be.visible').click();
-    cy.get('#spinner-animation').should('not.exist');
+    cy.wait('@updateUser', { timeout: 30000 });
     cy.get('#newDeviceUserBtn').should('be.visible');
 
     // Verify changes

eform-client/cypress/e2e/h/workers.add.spec.cy.ts

@@ -50,8 +50,10 @@ describe('Workers page - Add new worker', function () {
       cy.get('#firstName').should('be.visible').type(firstName);
       cy.get('#lastName').should('be.visible').type(lastName);
       cy.wait(500);
+      
+      cy.intercept('POST', '**/api/workers/create').as('createWorker');
       cy.get('#workerSaveBtn').should('be.visible').should('be.enabled').click();
-      cy.get('#spinner-animation').should('not.exist');
+      cy.wait('@createWorker', { timeout: 30000 });
       cy.get('#workerCreateBtn').should('be.visible');
 
       // Verify the worker was created
@@ -87,8 +89,10 @@ describe('Workers page - Add new worker', function () {
       cy.get('#firstName').should('be.visible').type(firstName);
       cy.get('#lastName').should('be.visible').type(lastName);
       cy.wait(500);
+      
+      cy.intercept('POST', '**/api/workers/create').as('createWorker');
       cy.get('#workerSaveBtn').should('be.visible').should('be.enabled').click();
-      cy.get('#spinner-animation').should('not.exist');
+      cy.wait('@createWorker', { timeout: 30000 });
       cy.get('#workerCreateBtn').should('be.visible');
 
       // Verify the worker was created
@@ -112,9 +116,10 @@ describe('Workers page - Add new worker', function () {
 
       for (let i = 0; i < workersToDelete; i++) {
         // Always delete the last worker
+        cy.intercept('POST', '**/api/workers/delete').as('deleteWorker');
         cy.get('#workerDeleteBtn').last().should('be.visible').click();
         cy.get('#saveDeleteBtn').should('be.visible').click();
-        cy.get('#spinner-animation').should('not.exist');
+        cy.wait('@deleteWorker', { timeout: 30000 });
         cy.wait(500);
       }
 
@@ -130,9 +135,10 @@ describe('Workers page - Add new worker', function () {
 
     cy.get('#deviceUserFirstName').each(($el, index) => {
       if ($el.text() === deviceUserFirstName) {
+        cy.intercept('POST', '**/api/device-users/delete').as('deleteUser');
         cy.get('#deleteDeviceUserBtn').eq(index).click();
         cy.get('#saveDeleteBtn').should('be.visible').click();
-        cy.get('#spinner-animation').should('not.exist');
+        cy.wait('@deleteUser', { timeout: 30000 });
         cy.get('#newDeviceUserBtn').should('be.visible');
         return false; // break the loop
       }