Skip to content

Commit a358dea

Browse files
Copilotrenemadsen
andcommitted
Remove cdkDragHandle to match working reference implementation
Co-authored-by: renemadsen <[email protected]>
1 parent a125b5a commit a358dea

File tree

6 files changed

+3
-17
lines changed

6 files changed

+3
-17
lines changed

eform-client/e2e/Page objects/EformVisualEditor.page.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -727,8 +727,8 @@ export class ChecklistFieldRowObj {
727727
}
728728

729729
async changePosition(targetField: ChecklistFieldRowObj) {
730-
// For CDK drag-drop: drag from the field element itself to the target field element
731-
await this.element.dragAndDrop(targetField.element);
730+
// For CDK drag-drop: drag from the move button to the target field element
731+
await this.moveFieldBtn.dragAndDrop(targetField.element);
732732
}
733733
}
734734

eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-item/navigation-menu-item/navigation-menu-item.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<mat-card class="mb-2 mt-2" id="menuItemTemplate">
22
<mat-card-header class="py-2 d-flex align-items-center justify-content-start">
33
<mat-icon
4-
cdkDragHandle
54
style="cursor: all-scroll"
65
id="drag_handle{{firstLevelIndex}}_{{secondLevelIndex}}"
76
class="md-36 dragula-handle align-middle"

eform-client/src/app/modules/advanced/modules/navigation-menu/components/menu-item/navigation-menu-template-item/navigation-menu-template-item.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<mat-card class="mb-2 mt-2">
22
<mat-card-header class="py-3 d-flex align-items-center justify-content-start">
33
<mat-icon
4-
cdkDragHandle
54
id="dragHandle{{templateIndex}}_{{itemIndex}}"
65
class="dragula-handle align-middle"
76
style="cursor: all-scroll">

eform-client/src/app/modules/advanced/modules/navigation-menu/components/navigation-menu-page/navigation-menu-page.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@
7575
<mat-expansion-panel-header>
7676
<mat-panel-title>
7777
<mat-icon
78-
cdkDragHandle
7978
class="dragula-handle align-middle"
8079
style="cursor: all-scroll">
8180
menu

eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/checklist/visual-editor-checklist/visual-editor-checklist.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
<div class="d-flex justify-content-between align-items-center">
66
<div style="display: flex; flex-grow: 2; align-items: center;">
77
<mat-icon
8-
cdkDragHandle
98
class="dragula-handle align-middle"
109
style="cursor: pointer"
1110
id="moveBtn"

eform-client/src/app/modules/eforms/eform-visual-editor/components/eform-visual-editor-elements/field/visual-editor-field/visual-editor-field.component.html

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,9 @@
1111
>
1212
<div style="display: flex; flex-grow: 6; align-items: center;">
1313
<mat-icon
14-
*ngIf="!fieldIsNested"
1514
class="dragula-handle align-middle"
1615
style="cursor: pointer"
17-
id="moveFieldBtn"
18-
>
19-
menu
20-
</mat-icon>
21-
<mat-icon
22-
*ngIf="fieldIsNested"
23-
cdkDragHandle
24-
class="dragula-handle align-middle"
25-
style="cursor: pointer"
26-
id="moveNestedFieldBtn"
16+
[id]="fieldIsNested ? 'moveNestedFieldBtn' : 'moveFieldBtn'"
2717
>
2818
menu
2919
</mat-icon>

0 commit comments

Comments
 (0)