Skip to content

Commit d3a92b4

Browse files
authored
Merge pull request #201 from Gid733/master
Minor bugfixing
2 parents 9df8520 + e2ecf92 commit d3a92b4

File tree

4 files changed

+11
-17
lines changed

4 files changed

+11
-17
lines changed

eFormAPI/eFormAPI.Web/Services/AdminService.cs

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ public async Task<OperationResult> UpdateUser(UserRegisterModel userRegisterMode
134134
_localizationService.GetString("UserNotFoundUserName", userRegisterModel.UserName));
135135
}
136136

137-
if (!_dbContext.SecurityGroups.Any(x => x.Id == userRegisterModel.GroupId))
137+
var isAdmin = await _userManager.IsInRoleAsync(user, EformRole.Admin);
138+
if (!_dbContext.SecurityGroups.Any(x => x.Id == userRegisterModel.GroupId) && !isAdmin)
138139
{
139140
return new OperationResult(false,
140141
_localizationService.GetString("SecurityGroupNotFound"));
@@ -145,8 +146,7 @@ public async Task<OperationResult> UpdateUser(UserRegisterModel userRegisterMode
145146
return new OperationResult(false, _localizationService.GetString("RoleIsRequired"));
146147
}
147148

148-
if (await _userManager.IsInRoleAsync(user, EformRole.Admin)
149-
&& _userService.Role != EformRole.Admin)
149+
if (isAdmin && _userService.Role != EformRole.Admin)
150150
{
151151
return new OperationResult(false, _localizationService.GetString("YouCantViewChangeOrDeleteAdmin"));
152152
}
@@ -297,10 +297,7 @@ public async Task<OperationResult> EnableTwoFactorAuthForce()
297297
{
298298
try
299299
{
300-
await _appSettings.UpdateDb((options) =>
301-
{
302-
options.IsTwoFactorForced = true;
303-
}, _dbContext);
300+
await _appSettings.UpdateDb((options) => { options.IsTwoFactorForced = true; }, _dbContext);
304301
}
305302
catch (Exception)
306303
{
@@ -314,10 +311,7 @@ public async Task<OperationResult> DisableTwoFactorAuthForce()
314311
{
315312
try
316313
{
317-
await _appSettings.UpdateDb((options) =>
318-
{
319-
options.IsTwoFactorForced = false;
320-
}, _dbContext);
314+
await _appSettings.UpdateDb((options) => { options.IsTwoFactorForced = false; }, _dbContext);
321315
}
322316
catch (Exception)
323317
{

eFormAPI/eFormAPI.Web/eFormAPI.Web.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="2.1.4" />
2929
<PackageReference Include="SharpZipLib.NETStandard" Version="1.0.7" />
3030
<PackageReference Include="SixLabors.ImageSharp" Version="1.0.0-beta0005" />
31-
<PackageReference Include="Swashbuckle.AspNetCore" Version="4.0.1" />
31+
<PackageReference Include="Swashbuckle.AspNetCore" Version="1.0.0" />
3232
<PackageReference Include="McMaster.NETCore.Plugins" Version="0.2.1" />
3333
<PackageReference Include="OtpSharp.Core" Version="1.0.0" />
3434
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="2.2.0" />

eform-client/src/app/common/services/auth/locale.service.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,16 @@ export class LocaleService extends BaseService {
7070
} else {
7171
culture = this.buildCookieValue('en-US');
7272
}
73-
this.cookieService.set('culture', culture);
74-
this.cookieService.set('locale', locale);
73+
this.cookieService.set('culture', culture, 9999999, '/');
74+
this.cookieService.set('locale', locale, 9999999, '/');
7575
}
7676

7777
buildCookieValue(locale: string) {
7878
return 'c=' + locale + '|uic=' + locale;
7979
}
8080

8181
updateCookies(locale: string) {
82-
this.cookieService.set('locale', locale);
83-
this.cookieService.set('culture', this.buildCookieValue(locale));
82+
this.cookieService.set('locale', locale, 9999999, '/');
83+
this.cookieService.set('culture', this.buildCookieValue(locale), 9999999, '/');
8484
}
8585
}

eform-client/src/app/modules/account-management/components/profile/profile-settings/profile-settings.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export class ProfileSettingsComponent implements OnInit {
8686
this.userSettingsService.updateUserSettings(this.userSettingsModel).subscribe(((data) => {
8787
this.localeService.updateUserLocale(this.userSettingsModel.locale);
8888
this.spinnerStatus = false;
89-
this.eventBrokerService.emit<void>('get-navigation-menu', null);
89+
window.location.reload();
9090
}), error => {
9191
this.spinnerStatus = false;
9292
});

0 commit comments

Comments
 (0)