Add unit tests for services and dialog components

Co-authored-by: renemadsen <[email protected]>

Author: Copilot

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts

@@ -0,0 +1,147 @@
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { DownloadExcelDialogComponent } from './download-excel-dialog.component';
+import { MAT_DIALOG_DATA } from '@angular/material/dialog';
+import { TimePlanningPnWorkingHoursService } from '../../../../services';
+import { ToastrService } from 'ngx-toastr';
+import { of, throwError } from 'rxjs';
+import { format } from 'date-fns';
+
+describe('DownloadExcelDialogComponent', () => {
+  let component: DownloadExcelDialogComponent;
+  let fixture: ComponentFixture<DownloadExcelDialogComponent>;
+  let mockWorkingHoursService: jasmine.SpyObj<TimePlanningPnWorkingHoursService>;
+  let mockToastrService: jasmine.SpyObj<ToastrService>;
+
+  beforeEach(async () => {
+    mockWorkingHoursService = jasmine.createSpyObj('TimePlanningPnWorkingHoursService', [
+      'downloadReport',
+      'downloadReportAllWorkers'
+    ]);
+    mockToastrService = jasmine.createSpyObj('ToastrService', ['error', 'success']);
+
+    await TestBed.configureTestingModule({
+      declarations: [DownloadExcelDialogComponent],
+      providers: [
+        { provide: MAT_DIALOG_DATA, useValue: [] },
+        { provide: TimePlanningPnWorkingHoursService, useValue: mockWorkingHoursService },
+        { provide: ToastrService, useValue: mockToastrService }
+      ]
+    }).compileComponents();
+
+    fixture = TestBed.createComponent(DownloadExcelDialogComponent);
+    component = fixture.componentInstance;
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+  });
+
+  describe('Site Selection', () => {
+    it('should update siteId when onSiteChanged is called', () => {
+      const testSiteId = 123;
+      
+      component.onSiteChanged(testSiteId);
+
+      expect(component.siteId).toBe(testSiteId);
+    });
+  });
+
+  describe('Date Updates', () => {
+    it('should update dateFrom when updateDateFrom is called', () => {
+      const testDate = new Date(2024, 0, 15);
+      const event = { value: testDate } as any;
+
+      component.updateDateFrom(event);
+
+      expect(component.dateFrom).toBe(testDate);
+    });
+
+    it('should update dateTo when updateDateTo is called', () => {
+      const testDate = new Date(2024, 0, 21);
+      const event = { value: testDate } as any;
+
+      component.updateDateTo(event);
+
+      expect(component.dateTo).toBe(testDate);
+    });
+  });
+
+  describe('Excel Report Download', () => {
+    beforeEach(() => {
+      component.dateFrom = new Date(2024, 0, 15);
+      component.dateTo = new Date(2024, 0, 21);
+      component.siteId = 123;
+    });
+
+    it('should call downloadReport with correct model', () => {
+      const mockBlob = new Blob(['test'], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
+      mockWorkingHoursService.downloadReport.and.returnValue(of(mockBlob));
+
+      component.onDownloadExcelReport();
+
+      expect(mockWorkingHoursService.downloadReport).toHaveBeenCalledWith({
+        dateFrom: '2024-01-15',
+        dateTo: '2024-01-21',
+        siteId: 123
+      });
+    });
+
+    it('should show error toast when download fails', (done) => {
+      mockWorkingHoursService.downloadReport.and.returnValue(
+        throwError(() => new Error('Download failed'))
+      );
+
+      component.onDownloadExcelReport();
+
+      // Wait a bit for async operations
+      setTimeout(() => {
+        expect(mockToastrService.error).toHaveBeenCalledWith('Error downloading report');
+        done();
+      }, 100);
+    });
+  });
+
+  describe('Excel Report All Workers Download', () => {
+    beforeEach(() => {
+      component.dateFrom = new Date(2024, 0, 15);
+      component.dateTo = new Date(2024, 0, 21);
+    });
+
+    it('should call downloadReportAllWorkers with correct model', () => {
+      const mockBlob = new Blob(['test'], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
+      mockWorkingHoursService.downloadReportAllWorkers.and.returnValue(of(mockBlob));
+
+      component.onDownloadExcelReportAllWorkers();
+
+      expect(mockWorkingHoursService.downloadReportAllWorkers).toHaveBeenCalledWith({
+        dateFrom: '2024-01-15',
+        dateTo: '2024-01-21'
+      });
+    });
+
+    it('should show error toast when download all workers fails', (done) => {
+      mockWorkingHoursService.downloadReportAllWorkers.and.returnValue(
+        throwError(() => new Error('Download failed'))
+      );
+
+      component.onDownloadExcelReportAllWorkers();
+
+      // Wait a bit for async operations
+      setTimeout(() => {
+        expect(mockToastrService.error).toHaveBeenCalledWith('Error downloading report');
+        done();
+      }, 100);
+    });
+
+    it('should not include siteId in all workers report model', () => {
+      const mockBlob = new Blob(['test'], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
+      mockWorkingHoursService.downloadReportAllWorkers.and.returnValue(of(mockBlob));
+      component.siteId = 999; // Should not be included
+
+      component.onDownloadExcelReportAllWorkers();
+
+      const callArgs = mockWorkingHoursService.downloadReportAllWorkers.calls.mostRecent().args[0];
+      expect(callArgs).not.toHaveProperty('siteId');
+    });
+  });
+});

eform-client/src/app/plugins/modules/time-planning-pn/services/time-planning-pn-plannings.service.spec.ts

@@ -0,0 +1,102 @@
+import { TestBed } from '@angular/core/testing';
+import { TimePlanningPnPlanningsService } from './time-planning-pn-plannings.service';
+import { ApiBaseService } from 'src/app/common/services';
+import { of } from 'rxjs';
+
+describe('TimePlanningPnPlanningsService', () => {
+  let service: TimePlanningPnPlanningsService;
+  let mockApiBaseService: jasmine.SpyObj<ApiBaseService>;
+
+  beforeEach(() => {
+    mockApiBaseService = jasmine.createSpyObj('ApiBaseService', ['post', 'put', 'get']);
+
+    TestBed.configureTestingModule({
+      providers: [
+        TimePlanningPnPlanningsService,
+        { provide: ApiBaseService, useValue: mockApiBaseService }
+      ]
+    });
+
+    service = TestBed.inject(TimePlanningPnPlanningsService);
+  });
+
+  it('should be created', () => {
+    expect(service).toBeTruthy();
+  });
+
+  describe('getPlannings', () => {
+    it('should call apiBaseService.post with correct parameters', () => {
+      const mockRequest = {
+        dateFrom: '2024-01-01',
+        dateTo: '2024-01-07',
+        sort: 'Date',
+        isSortDsc: true,
+        siteId: 1,
+        showResignedSites: false
+      };
+      const mockResponse = { success: true, model: [] };
+      mockApiBaseService.post.and.returnValue(of(mockResponse as any));
+
+      service.getPlannings(mockRequest).subscribe(result => {
+        expect(result).toEqual(mockResponse as any);
+      });
+
+      expect(mockApiBaseService.post).toHaveBeenCalledWith(
+        'api/time-planning-pn/plannings/index',
+        mockRequest
+      );
+    });
+
+    it('should handle empty response', () => {
+      const mockRequest = {
+        dateFrom: '2024-01-01',
+        dateTo: '2024-01-07',
+        sort: 'Date',
+        isSortDsc: true,
+        siteId: 0,
+        showResignedSites: false
+      };
+      const mockResponse = { success: true, model: [] };
+      mockApiBaseService.post.and.returnValue(of(mockResponse as any));
+
+      service.getPlannings(mockRequest).subscribe(result => {
+        expect(result.model).toEqual([]);
+      });
+    });
+  });
+
+  describe('updatePlanning', () => {
+    it('should call apiBaseService.put with correct parameters', () => {
+      const mockPlanningModel = {
+        id: 123,
+        planHours: 8,
+        message: 1,
+        planText: 'Test planning'
+      } as any;
+      const mockResponse = { success: true };
+      mockApiBaseService.put.and.returnValue(of(mockResponse as any));
+
+      service.updatePlanning(mockPlanningModel, 123).subscribe(result => {
+        expect(result).toEqual(mockResponse as any);
+      });
+
+      expect(mockApiBaseService.put).toHaveBeenCalledWith(
+        'api/time-planning-pn/plannings/123',
+        mockPlanningModel
+      );
+    });
+
+    it('should construct correct URL with id parameter', () => {
+      const mockPlanningModel = { id: 456 } as any;
+      const mockResponse = { success: true };
+      mockApiBaseService.put.and.returnValue(of(mockResponse as any));
+
+      service.updatePlanning(mockPlanningModel, 456).subscribe();
+
+      expect(mockApiBaseService.put).toHaveBeenCalledWith(
+        'api/time-planning-pn/plannings/456',
+        mockPlanningModel
+      );
+    });
+  });
+});