Skip to content

Commit 58397ff

Browse files
Copilotrenemadsen
andcommitted
Remove continue-on-error from unit test steps and fix TypeScript error in test
Co-authored-by: renemadsen <[email protected]>
1 parent c935728 commit 58397ff

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

.github/workflows/dotnet-core-master.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,13 @@ jobs:
9191
# Try different test commands based on what's available in package.json
9292
if grep -q '"test:ci"' package.json 2>/dev/null; then
9393
echo "Running with test:ci script..."
94-
npm run test:ci -- --include='**/time-planning-pn/**/*.spec.ts' || true
94+
npm run test:ci -- --include='**/time-planning-pn/**/*.spec.ts'
9595
elif grep -q '"test"' package.json 2>/dev/null; then
9696
echo "Running with test script..."
97-
npm run test -- --watch=false --browsers=ChromeHeadless --include='**/time-planning-pn/**/*.spec.ts' || true
97+
npm run test -- --watch=false --browsers=ChromeHeadless --include='**/time-planning-pn/**/*.spec.ts'
9898
else
9999
echo "No test script found in package.json, skipping unit tests"
100100
fi
101-
continue-on-error: true
102101
pn-test:
103102
needs: build
104103
runs-on: ubuntu-latest

.github/workflows/dotnet-core-pr.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,13 @@ jobs:
8585
# Try different test commands based on what's available in package.json
8686
if grep -q '"test:ci"' package.json 2>/dev/null; then
8787
echo "Running with test:ci script..."
88-
npm run test:ci -- --include='**/time-planning-pn/**/*.spec.ts' || true
88+
npm run test:ci -- --include='**/time-planning-pn/**/*.spec.ts'
8989
elif grep -q '"test"' package.json 2>/dev/null; then
9090
echo "Running with test script..."
91-
npm run test -- --watch=false --browsers=ChromeHeadless --include='**/time-planning-pn/**/*.spec.ts' || true
91+
npm run test -- --watch=false --browsers=ChromeHeadless --include='**/time-planning-pn/**/*.spec.ts'
9292
else
9393
echo "No test script found in package.json, skipping unit tests"
9494
fi
95-
continue-on-error: true
9695
pn-test:
9796
needs: build
9897
runs-on: ubuntu-22.04

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe('AssignedSiteDialogComponent', () => {
5959

6060
mockStore.select.and.returnValue(of(true));
6161
mockSettingsService.getGlobalAutoBreakCalculationSettings.and.returnValue(
62-
of({ success: true, model: {} as any })
62+
of({ success: true, model: {} }) as any
6363
);
6464

6565
await TestBed.configureTestingModule({

0 commit comments

Comments
 (0)