Eliminate all remaining C# warnings

Co-authored-by: renemadsen <[email protected]>

Author: Copilot

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn.Test/TestBaseSetup.cs

@@ -9,9 +9,10 @@
 using NUnit.Framework;
 using Testcontainers.MariaDb;
 
+#nullable enable
 namespace BackendConfiguration.Pn.Integration.Test;
 
-public class TestBaseSetup
+public abstract class TestBaseSetup
 {
     private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
         .WithDatabase(

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Infrastructure/Helpers/GoogleSheetHelper.cs

@@ -167,7 +167,6 @@ public static async Task PullEverythingFromGoogleSheet(Core core, TimePlanningPn
         }
 
         var applicationName = "Google Sheets API Integration";
-        var sheetName = "PlanTimer";
 
         //var core = await coreHelper.GetCore();
         await using var sdkDbContext = core.DbContextHelper.GetDbContext();

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Infrastructure/Helpers/PlanRegistrationHelper.cs

@@ -1886,7 +1886,7 @@ await dbContext.PlanRegistrations.AsNoTracking()
                     await planRegistration.Update(dbContext).ConfigureAwait(false);
                 }
             }
-            catch (Exception e)
+            catch (Exception)
             {
                 SentrySdk.CaptureMessage(
                     $"Could not parse PlanText for planning with id: {planRegistration.Id} the PlanText was: {planRegistration.PlanText}");

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningPlanningService/TimePlanningPlanningService.cs

@@ -298,6 +298,13 @@ public async Task<OperationDataResult<TimePlanningPlanningModel>> IndexByCurrent
             .Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
             .FirstOrDefaultAsync(x => x.SiteId == site.MicrotingUid);
 
+        if (dbAssignedSite == null)
+        {
+            return new OperationDataResult<TimePlanningPlanningModel>(
+                false,
+                localizationService.GetString("AssignedSiteNotFound"));
+        }
+
         var datesInPeriod = new List<DateTime>();
         var midnightOfDateFrom = new DateTime(model.DateFrom!.Value.Year, model.DateFrom.Value.Month, model.DateFrom.Value.Day, 0, 0, 0);
         var midnightOfDateTo = new DateTime(model.DateTo!.Value.Year, model.DateTo.Value.Month, model.DateTo.Value.Day, 23, 59, 59);
@@ -318,7 +325,8 @@ public async Task<OperationDataResult<TimePlanningPlanningModel>> IndexByCurrent
 
         try
         {
-            siteModel.SoftwareVersionIsValid = int.Parse(currentUser.TimeRegistrationSoftwareVersion.Replace(".", "")) >= 3114;
+            siteModel.SoftwareVersionIsValid = currentUser.TimeRegistrationSoftwareVersion != null && 
+                int.Parse(currentUser.TimeRegistrationSoftwareVersion.Replace(".", "")) >= 3114;
         }
         catch (Exception)
         {
@@ -896,6 +904,8 @@ await dbContext.PlanRegistrations.AsNoTracking()
                         .OrderByDescending(x => x.Date)
                         .FirstOrDefaultAsync();
 
+                if (preTimePlanningAfterThisPlanning == null) continue;
+
                 planningAfterThisPlanning.SumFlexStart = preTimePlanningAfterThisPlanning.SumFlexEnd;
                 if (planningAfterThisPlanning.NettoHoursOverrideActive)
                 {
@@ -1367,6 +1377,8 @@ await dbContext.PlanRegistrations.AsNoTracking()
                         .OrderByDescending(x => x.Date)
                         .FirstOrDefaultAsync();
 
+                if (preTimePlanningAfterThisPlanning == null) continue;
+
                 planningAfterThisPlanning.SumFlexStart = preTimePlanningAfterThisPlanning.SumFlexEnd;
                 planningAfterThisPlanning.SumFlexEnd = preTimePlanningAfterThisPlanning.SumFlexEnd +
                                                        planningAfterThisPlanning.NettoHours -

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningSettingService/TimeSettingService.cs

@@ -56,7 +56,7 @@ public class TimeSettingService(
     IEFormCoreService core)
     : ISettingService
 {
-    public async Task<OperationDataResult<TimePlanningSettingsModel>> GetSettings()
+    public Task<OperationDataResult<TimePlanningSettingsModel>> GetSettings()
     {
         try
         {
@@ -93,16 +93,16 @@ public async Task<OperationDataResult<TimePlanningSettingsModel>> GetSettings()
             };
 
             //timePlanningSettingsModel.AssignedSites = assignedSites;
-            return new OperationDataResult<TimePlanningSettingsModel>(true, timePlanningSettingsModel);
+            return Task.FromResult(new OperationDataResult<TimePlanningSettingsModel>(true, timePlanningSettingsModel));
         }
         catch (Exception e)
         {
             SentrySdk.CaptureException(e);
             Console.WriteLine(e);
             logger.LogError(e.Message);
-            return new OperationDataResult<TimePlanningSettingsModel>(
+            return Task.FromResult(new OperationDataResult<TimePlanningSettingsModel>(
                 false,
-                localizationService.GetString("ErrorWhileObtainingSettings"));
+                localizationService.GetString("ErrorWhileObtainingSettings")));
         }
     }
 

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningWorkingHoursService/TimePlanningWorkingHoursService.cs

@@ -2699,10 +2699,14 @@ public async Task<OperationResult> Import(IFormFile file)
                         return new OperationResult(false, localizationService.GetString("FileFormatError"));
                     }
                     var sheets = workbookPart.Workbook.Sheets;
+                    if (sheets == null)
+                    {
+                        return new OperationResult(false, localizationService.GetString("FileFormatError"));
+                    }
 
                     foreach (Sheet sheet in sheets)
                     {
-                        if (sheet.Name?.Value == null || sheet.Id == null)
+                        if (sheet.Name?.Value == null || sheet.Id?.Value == null)
                         {
                             continue;
                         }
@@ -2712,7 +2716,7 @@ public async Task<OperationResult> Import(IFormFile file)
                             continue;
                         }
 
-                        var worksheetPart = (WorksheetPart)workbookPart.GetPartById(sheet.Id);
+                        var worksheetPart = (WorksheetPart)workbookPart.GetPartById(sheet.Id.Value);
                         var sheetData = worksheetPart.Worksheet.Elements<SheetData>().First();
 
                         var rows = sheetData.Elements<Row>();
@@ -2885,7 +2889,7 @@ private string GetCellValue(WorkbookPart workbookPart, Row row, int columnIndex)
         if (cell.StyleIndex != null)
         {
             var stylesPart = workbookPart.WorkbookStylesPart;
-            if (stylesPart != null)
+            if (stylesPart?.Stylesheet?.CellFormats != null)
             {
                 var cellFormat = stylesPart.Stylesheet.CellFormats.ElementAt((int)cell.StyleIndex.Value) as CellFormat;
                 var isDate = IsDateFormat(stylesPart, cellFormat);
@@ -2922,8 +2926,8 @@ private bool IsDateFormat(WorkbookStylesPart stylesPart, CellFormat? cellFormat)
         var numberFormats = stylesPart.Stylesheet.NumberingFormats?.Elements<NumberingFormat>();
         if (numberFormats != null)
         {
-            var format = numberFormats.FirstOrDefault(nf => nf.NumberFormatId.Value == cellFormat.NumberFormatId.Value);
-            if (format != null && format.FormatCode != null)
+            var format = numberFormats.FirstOrDefault(nf => nf.NumberFormatId?.Value == cellFormat.NumberFormatId.Value);
+            if (format?.FormatCode?.Value != null)
             {
                 // Check if the custom format code looks like a date format
                 var formatCode = format.FormatCode.Value.ToLower();