Skip to content

Commit 64c960a

Browse files
committed
Improving the lookup, so we use the email instead of full name.
1 parent ee581e6 commit 64c960a

File tree

2 files changed

+23
-14
lines changed

2 files changed

+23
-14
lines changed

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningPlanningService/TimePlanningPlanningService.cs

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -280,19 +280,21 @@ public async Task<OperationDataResult<TimePlanningPlanningModel>> IndexByCurrent
280280
await baseDbContext.SaveChangesAsync();
281281
}
282282

283-
var fullName = currentUser.FirstName.Trim() + " " + currentUser.LastName.Trim();
284-
285-
var site = await sdkDbContext.Sites
283+
var worker = await sdkDbContext.Workers
284+
.Include(x => x.SiteWorkers)
285+
.ThenInclude(x => x.Site)
286286
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
287-
.FirstOrDefaultAsync(x => x.Name.Replace(" ", "") == fullName.Replace(" ", ""));
287+
.FirstOrDefaultAsync(x => x.Email == currentUser.Email);
288288

289-
if (site == null)
289+
if (worker == null)
290290
{
291291
return new OperationDataResult<TimePlanningPlanningModel>(
292292
false,
293293
localizationService.GetString("SiteNotFound"));
294294
}
295295

296+
var site = worker.SiteWorkers.First().Site;
297+
296298
var dbAssignedSite = await dbContext.AssignedSites
297299
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
298300
.FirstOrDefaultAsync(x => x.SiteId == site.MicrotingUid);
@@ -941,21 +943,24 @@ public async Task<OperationResult> UpdateByCurrentUserNam(
941943
var currentUserAsync = await userService.GetCurrentUserAsync();
942944
var currentUser = baseDbContext.Users
943945
.Single(x => x.Id == currentUserAsync.Id);
944-
var fullName = currentUser.FirstName.Trim() + " " + currentUser.LastName.Trim();
945-
var sdkSite = await sdkDbContext.Sites
946+
var worker = await sdkDbContext.Workers
947+
.Include(x => x.SiteWorkers)
948+
.ThenInclude(x => x.Site)
946949
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
947-
.FirstOrDefaultAsync(x => x.Name.Replace(" ", "") == fullName.Replace(" ", ""));
950+
.FirstOrDefaultAsync(x => x.Email == currentUser.Email);
948951

949-
if (sdkSite == null)
952+
if (worker == null)
950953
{
951954
return new OperationDataResult<TimePlanningPlanningModel>(
952955
false,
953956
localizationService.GetString("SiteNotFound"));
954957
}
955958

959+
var mcrotingUid = worker.SiteWorkers.First().Site.MicrotingUid;
960+
956961
var assignedSite = await dbContext.AssignedSites
957962
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
958-
.FirstOrDefaultAsync(x => x.SiteId == sdkSite.MicrotingUid);
963+
.FirstOrDefaultAsync(x => x.SiteId == mcrotingUid);
959964

960965
if (assignedSite == null)
961966
{

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningSettingService/TimeSettingService.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -356,16 +356,20 @@ planRegistrationForToday is
356356
var currentUserAsync = await userService.GetCurrentUserAsync();
357357
var currentUser = baseDbContext.Users
358358
.Single(x => x.Id == currentUserAsync.Id);
359-
var fullName = currentUser.FirstName.Trim() + " " + currentUser.LastName.Trim();
360-
var sdkSite = await sdkContext.Sites
359+
360+
var worker = await sdkContext.Workers
361+
.Include(x => x.SiteWorkers)
362+
.ThenInclude(x => x.Site)
361363
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
362-
.FirstOrDefaultAsync(x => x.Name.Replace(" ", "") == fullName.Replace(" ", ""));
364+
.FirstOrDefaultAsync(x => x.Email == currentUser.Email);
363365

364-
if (sdkSite == null)
366+
if (worker == null)
365367
{
366368
return new OperationDataResult<Infrastructure.Models.Settings.AssignedSite>(false, "Site not found");
367369
}
368370

371+
var sdkSite = worker.SiteWorkers.First().Site;
372+
369373
Infrastructure.Models.Settings.AssignedSite dbAssignedSite = await dbContext.AssignedSites
370374
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
371375
.AsNoTracking()

0 commit comments

Comments
 (0)