Merge pull request #1076 from microting/copilot/fix-broken-unit-tests

Fix broken unit tests by converting Jasmine to Jest syntax

Author: renemadsen

JEST_CONVERSION.md

@@ -0,0 +1,114 @@
+# Jest Conversion Summary
+
+## Overview
+All unit test spec files in the time-planning-pn plugin have been converted from Jasmine to Jest syntax to fix broken unit tests.
+
+## Files Converted
+
+### Component Specs
+1. **time-plannings-container.component.spec.ts**
+   - Converted all Jasmine spy objects to Jest mocked objects
+   - Updated mock creation from `jasmine.createSpyObj` to manual object creation with `jest.fn()`
+   - Changed `spyOn` to `jest.spyOn`
+   - Changed `.and.returnValue()` to `.mockReturnValue()`
+
+2. **time-plannings-table.component.spec.ts**
+   - Converted Jasmine SpyObj to Jest Mocked types
+   - Updated all mock methods to use Jest syntax
+   - Converted spy creation and return value setting
+
+3. **assigned-site-dialog.component.spec.ts**
+   - Converted service and store mocks to Jest syntax
+   - Updated mock return value patterns
+
+4. **workday-entity-dialog.component.spec.ts**
+   - Converted large component spec with extensive time conversion tests
+   - Updated all mock patterns to Jest
+
+5. **download-excel-dialog.component.spec.ts**
+   - Converted service mocks to Jest
+   - Updated Jasmine's `.calls.mostRecent().args[0]` to Jest's `.mock.calls[.mock.calls.length - 1][0]`
+
+### Service Specs
+1. **time-planning-pn-plannings.service.spec.ts**
+   - Already using Jest syntax (no changes needed)
+
+## Conversion Patterns
+
+### Type Declarations
+```typescript
+// Before (Jasmine)
+let mockService: jasmine.SpyObj<ServiceType>;
+
+// After (Jest)
+let mockService: jest.Mocked<ServiceType>;
+```
+
+### Mock Creation
+```typescript
+// Before (Jasmine)
+mockService = jasmine.createSpyObj('ServiceType', ['method1', 'method2']);
+
+// After (Jest)
+mockService = {
+  method1: jest.fn(),
+  method2: jest.fn(),
+} as any;
+```
+
+### Return Values
+```typescript
+// Before (Jasmine)
+mockService.method1.and.returnValue(of(data));
+
+// After (Jest)
+mockService.method1.mockReturnValue(of(data));
+```
+
+### Spying on Methods
+```typescript
+// Before (Jasmine)
+spyOn(component, 'methodName');
+
+// After (Jest)
+jest.spyOn(component, 'methodName');
+```
+
+### Accessing Call Arguments
+```typescript
+// Before (Jasmine)
+const args = mockService.method.calls.mostRecent().args[0];
+
+// After (Jest)
+const args = mockService.method.mock.calls[mockService.method.mock.calls.length - 1][0];
+```
+
+## Testing Command
+To run the unit tests for the time-planning-pn plugin, use:
+
+```bash
+npm run test:unit -- --testPathPatterns=time-planning-pn --coverage --collectCoverageFrom='src/app/plugins/modules/time-planning-pn/**/*.ts' --coveragePathIgnorePatterns='\.spec\.ts'
+```
+
+## Benefits of Jest Conversion
+
+1. **Consistency**: All test files now use the same testing framework (Jest)
+2. **Modern Syntax**: Jest is more commonly used in modern JavaScript/TypeScript projects
+3. **Better Performance**: Jest offers better performance with parallel test execution
+4. **Built-in Mocking**: Jest has powerful built-in mocking capabilities without additional libraries
+
+## Verification
+
+All files have been verified to:
+- ✅ Use Jest mocking syntax exclusively
+- ✅ Have no remaining Jasmine patterns (jasmine.SpyObj, jasmine.createSpyObj, .and.returnValue)
+- ✅ Use proper Jest spy and mock patterns
+- ✅ Maintain all original test logic and assertions
+- ✅ Preserve test coverage for time conversion utilities, component interactions, and service calls
+
+## Notes
+
+- No test logic was changed during conversion
+- All assertions remain identical
+- Test descriptions and structure are preserved
+- The conversion maintains 100% backward compatibility with the original test intent

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.spec.ts

@@ -9,8 +9,8 @@ import { of } from 'rxjs';
 describe('AssignedSiteDialogComponent', () => {
   let component: AssignedSiteDialogComponent;
   let fixture: ComponentFixture<AssignedSiteDialogComponent>;
-  let mockSettingsService: jasmine.SpyObj<TimePlanningPnSettingsService>;
-  let mockStore: jasmine.SpyObj<Store>;
+  let mockSettingsService: jest.Mocked<TimePlanningPnSettingsService>;
+  let mockStore: jest.Mocked<Store>;
 
   const mockAssignedSiteData = {
     id: 1,
@@ -50,15 +50,17 @@ describe('AssignedSiteDialogComponent', () => {
   };
 
   beforeEach(async () => {
-    mockSettingsService = jasmine.createSpyObj('TimePlanningPnSettingsService', [
-      'getGlobalAutoBreakCalculationSettings',
-      'updateAssignedSite',
-      'getAssignedSite'
-    ]);
-    mockStore = jasmine.createSpyObj('Store', ['select']);
+    mockSettingsService = {
+      getGlobalAutoBreakCalculationSettings: jest.fn(),
+      updateAssignedSite: jest.fn(),
+      getAssignedSite: jest.fn(),
+    } as any;
+    mockStore = {
+      select: jest.fn(),
+    } as any;
 
-    mockStore.select.and.returnValue(of(true));
-    mockSettingsService.getGlobalAutoBreakCalculationSettings.and.returnValue(
+    mockStore.select.mockReturnValue(of(true));
+    mockSettingsService.getGlobalAutoBreakCalculationSettings.mockReturnValue(
       of({ success: true, model: {} }) as any
     );
 
@@ -207,7 +209,7 @@ describe('AssignedSiteDialogComponent', () => {
   describe('Break Settings', () => {
     beforeEach(() => {
       component.ngOnInit();
-      mockSettingsService.getGlobalAutoBreakCalculationSettings.and.returnValue(
+      mockSettingsService.getGlobalAutoBreakCalculationSettings.mockReturnValue(
         of({
           success: true,
           model: {

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts

@@ -9,15 +9,18 @@ import { format } from 'date-fns';
 describe('DownloadExcelDialogComponent', () => {
   let component: DownloadExcelDialogComponent;
   let fixture: ComponentFixture<DownloadExcelDialogComponent>;
-  let mockWorkingHoursService: jasmine.SpyObj<TimePlanningPnWorkingHoursService>;
-  let mockToastrService: jasmine.SpyObj<ToastrService>;
+  let mockWorkingHoursService: jest.Mocked<TimePlanningPnWorkingHoursService>;
+  let mockToastrService: jest.Mocked<ToastrService>;
 
   beforeEach(async () => {
-    mockWorkingHoursService = jasmine.createSpyObj('TimePlanningPnWorkingHoursService', [
-      'downloadReport',
-      'downloadReportAllWorkers'
-    ]);
-    mockToastrService = jasmine.createSpyObj('ToastrService', ['error', 'success']);
+    mockWorkingHoursService = {
+      downloadReport: jest.fn(),
+      downloadReportAllWorkers: jest.fn(),
+    } as any;
+    mockToastrService = {
+      error: jest.fn(),
+      success: jest.fn(),
+    } as any;
 
     await TestBed.configureTestingModule({
       declarations: [DownloadExcelDialogComponent],
@@ -75,7 +78,7 @@ describe('DownloadExcelDialogComponent', () => {
 
     it('should call downloadReport with correct model', () => {
       const mockBlob = new Blob(['test'], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
-      mockWorkingHoursService.downloadReport.and.returnValue(of(mockBlob));
+      mockWorkingHoursService.downloadReport.mockReturnValue(of(mockBlob));
 
       component.onDownloadExcelReport();
 
@@ -87,7 +90,7 @@ describe('DownloadExcelDialogComponent', () => {
     });
 
     it('should show error toast when download fails', (done) => {
-      mockWorkingHoursService.downloadReport.and.returnValue(
+      mockWorkingHoursService.downloadReport.mockReturnValue(
         throwError(() => new Error('Download failed'))
       );
 
@@ -109,7 +112,7 @@ describe('DownloadExcelDialogComponent', () => {
 
     it('should call downloadReportAllWorkers with correct model', () => {
       const mockBlob = new Blob(['test'], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
-      mockWorkingHoursService.downloadReportAllWorkers.and.returnValue(of(mockBlob));
+      mockWorkingHoursService.downloadReportAllWorkers.mockReturnValue(of(mockBlob));
 
       component.onDownloadExcelReportAllWorkers();
 
@@ -120,7 +123,7 @@ describe('DownloadExcelDialogComponent', () => {
     });
 
     it('should show error toast when download all workers fails', (done) => {
-      mockWorkingHoursService.downloadReportAllWorkers.and.returnValue(
+      mockWorkingHoursService.downloadReportAllWorkers.mockReturnValue(
         throwError(() => new Error('Download failed'))
       );
 
@@ -135,12 +138,12 @@ describe('DownloadExcelDialogComponent', () => {
 
     it('should not include siteId in all workers report model', () => {
       const mockBlob = new Blob(['test'], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
-      mockWorkingHoursService.downloadReportAllWorkers.and.returnValue(of(mockBlob));
+      mockWorkingHoursService.downloadReportAllWorkers.mockReturnValue(of(mockBlob));
       component.siteId = 999; // Should not be included
 
       component.onDownloadExcelReportAllWorkers();
 
-      const callArgs = mockWorkingHoursService.downloadReportAllWorkers.calls.mostRecent().args[0];
+      const callArgs = mockWorkingHoursService.downloadReportAllWorkers.mock.calls[mockWorkingHoursService.downloadReportAllWorkers.mock.calls.length - 1][0];
       expect('siteId' in callArgs).toBe(false);
     });
   });

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/workday-entity/workday-entity-dialog.component.spec.ts

@@ -10,8 +10,8 @@ import { of } from 'rxjs';
 describe('WorkdayEntityDialogComponent', () => {
   let component: WorkdayEntityDialogComponent;
   let fixture: ComponentFixture<WorkdayEntityDialogComponent>;
-  let mockPlanningsService: jasmine.SpyObj<TimePlanningPnPlanningsService>;
-  let mockTranslateService: jasmine.SpyObj<TranslateService>;
+  let mockPlanningsService: jest.Mocked<TimePlanningPnPlanningsService>;
+  let mockTranslateService: jest.Mocked<TranslateService>;
 
   const mockData = {
     planningPrDayModels: {
@@ -82,13 +82,17 @@ describe('WorkdayEntityDialogComponent', () => {
   };
 
   beforeEach(async () => {
-    mockPlanningsService = jasmine.createSpyObj('TimePlanningPnPlanningsService', ['updatePlanning']);
-    mockTranslateService = jasmine.createSpyObj('TranslateService', ['instant', 'stream'], {
-      onLangChange: of({ lang: 'en' })
-    });
-
-    mockTranslateService.instant.and.returnValue('Translated');
-    mockTranslateService.stream.and.returnValue(of('Translated'));
+    mockPlanningsService = {
+      updatePlanning: jest.fn(),
+    } as any;
+    mockTranslateService = {
+      instant: jest.fn(),
+      stream: jest.fn(),
+      onLangChange: of({ lang: 'en' }),
+    } as any;
+
+    mockTranslateService.instant.mockReturnValue('Translated');
+    mockTranslateService.stream.mockReturnValue(of('Translated'));
 
     await TestBed.configureTestingModule({
       declarations: [WorkdayEntityDialogComponent],

eform-client/src/app/plugins/modules/time-planning-pn/components/plannings/time-plannings-container/time-plannings-container.component.spec.ts

@@ -10,20 +10,32 @@ import { format } from 'date-fns';
 describe('TimePlanningsContainerComponent', () => {
   let component: TimePlanningsContainerComponent;
   let fixture: ComponentFixture<TimePlanningsContainerComponent>;
-  let mockPlanningsService: jasmine.SpyObj<TimePlanningPnPlanningsService>;
-  let mockSettingsService: jasmine.SpyObj<TimePlanningPnSettingsService>;
-  let mockDialog: jasmine.SpyObj<MatDialog>;
-  let mockStore: jasmine.SpyObj<Store>;
+  let mockPlanningsService: jest.Mocked<TimePlanningPnPlanningsService>;
+  let mockSettingsService: jest.Mocked<TimePlanningPnSettingsService>;
+  let mockDialog: jest.Mocked<MatDialog>;
+  let mockStore: jest.Mocked<Store>;
 
   beforeEach(async () => {
-    mockPlanningsService = jasmine.createSpyObj('TimePlanningPnPlanningsService', ['getPlannings', 'updatePlanning']);
-    mockSettingsService = jasmine.createSpyObj('TimePlanningPnSettingsService', ['getAvailableSites', 'getResignedSites', 'getAssignedSite', 'updateAssignedSite']);
-    mockDialog = jasmine.createSpyObj('MatDialog', ['open']);
-    mockStore = jasmine.createSpyObj('Store', ['select']);
-
-    mockStore.select.and.returnValue(of('en-US'));
-    mockSettingsService.getAvailableSites.and.returnValue(of({ success: true, model: [] }) as any);
-    mockPlanningsService.getPlannings.and.returnValue(of({ success: true, model: [] }) as any);
+    mockPlanningsService = {
+      getPlannings: jest.fn(),
+      updatePlanning: jest.fn(),
+    } as any;
+    mockSettingsService = {
+      getAvailableSites: jest.fn(),
+      getResignedSites: jest.fn(),
+      getAssignedSite: jest.fn(),
+      updateAssignedSite: jest.fn(),
+    } as any;
+    mockDialog = {
+      open: jest.fn(),
+    } as any;
+    mockStore = {
+      select: jest.fn(),
+    } as any;
+
+    mockStore.select.mockReturnValue(of('en-US'));
+    mockSettingsService.getAvailableSites.mockReturnValue(of({ success: true, model: [] }) as any);
+    mockPlanningsService.getPlannings.mockReturnValue(of({ success: true, model: [] }) as any);
 
     await TestBed.configureTestingModule({
       declarations: [TimePlanningsContainerComponent],
@@ -105,23 +117,23 @@ describe('TimePlanningsContainerComponent', () => {
 
   describe('Event Handlers', () => {
     it('should call getPlannings when onTimePlanningChanged is triggered', () => {
-      spyOn(component, 'getPlannings');
+      jest.spyOn(component, 'getPlannings');
 
       component.onTimePlanningChanged({});
 
       expect(component.getPlannings).toHaveBeenCalled();
     });
 
     it('should call getPlannings when onAssignedSiteChanged is triggered', () => {
-      spyOn(component, 'getPlannings');
+      jest.spyOn(component, 'getPlannings');
 
       component.onAssignedSiteChanged({});
 
       expect(component.getPlannings).toHaveBeenCalled();
     });
 
     it('should update siteId and call getPlannings when onSiteChanged is triggered', () => {
-      spyOn(component, 'getPlannings');
+      jest.spyOn(component, 'getPlannings');
       const testSiteId = 123;
 
       component.onSiteChanged(testSiteId);
@@ -135,7 +147,7 @@ describe('TimePlanningsContainerComponent', () => {
     it('should open download excel dialog with available sites', () => {
       component.availableSites = [{ id: 1, name: 'Test Site' } as any];
       const mockDialogRef = { afterClosed: () => of(null) };
-      mockDialog.open.and.returnValue(mockDialogRef as any);
+      mockDialog.open.mockReturnValue(mockDialogRef as any);
 
       component.openDownloadExcelDialog();
 
@@ -145,7 +157,7 @@ describe('TimePlanningsContainerComponent', () => {
 
   describe('Show Resigned Sites', () => {
     it('should load resigned sites when showResignedSites is true', () => {
-      mockSettingsService.getResignedSites.and.returnValue(of({ success: true, model: [{ id: 1, name: 'Resigned Site' }] } as any));
+      mockSettingsService.getResignedSites.mockReturnValue(of({ success: true, model: [{ id: 1, name: 'Resigned Site' }] } as any));
 
       component.onShowResignedSitesChanged({ checked: true });
 
@@ -155,7 +167,7 @@ describe('TimePlanningsContainerComponent', () => {
 
     it('should load available sites when showResignedSites is false', () => {
       component.showResignedSites = true;
-      mockSettingsService.getAvailableSites.and.returnValue(of({ success: true, model: [{ id: 1, name: 'Available Site' }] } as any));
+      mockSettingsService.getAvailableSites.mockReturnValue(of({ success: true, model: [{ id: 1, name: 'Available Site' }] } as any));
 
       component.onShowResignedSitesChanged({ checked: false });