Skip to content

Commit b70f7da

Browse files
committed
Reverting broken merge.
1 parent a082c53 commit b70f7da

File tree

2 files changed

+24
-28
lines changed

2 files changed

+24
-28
lines changed

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningPlanningService/TimePlanningPlanningService.cs

Lines changed: 17 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -281,30 +281,25 @@ public async Task<OperationDataResult<TimePlanningPlanningModel>> IndexByCurrent
281281
await baseDbContext.SaveChangesAsync();
282282
}
283283

284-
var fullName = currentUser.FirstName.Trim() + " " + currentUser.LastName.Trim();
285-
286-
var site = await sdkDbContext.Sites
284+
var worker = await sdkDbContext.Workers
285+
.Include(x => x.SiteWorkers)
286+
.ThenInclude(x => x.Site)
287287
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
288-
.FirstOrDefaultAsync(x => x.Name.Replace(" ", "") == fullName.Replace(" ", ""));
288+
.FirstOrDefaultAsync(x => x.Email == currentUser.Email);
289289

290-
if (site == null)
290+
if (worker == null)
291291
{
292292
return new OperationDataResult<TimePlanningPlanningModel>(
293293
false,
294294
localizationService.GetString("SiteNotFound"));
295295
}
296296

297+
var site = worker.SiteWorkers.First().Site;
298+
297299
var dbAssignedSite = await dbContext.AssignedSites
298300
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
299301
.FirstOrDefaultAsync(x => x.SiteId == site.MicrotingUid);
300302

301-
if (dbAssignedSite == null)
302-
{
303-
return new OperationDataResult<TimePlanningPlanningModel>(
304-
false,
305-
localizationService.GetString("AssignedSiteNotFound"));
306-
}
307-
308303
var datesInPeriod = new List<DateTime>();
309304
var midnightOfDateFrom = new DateTime(model.DateFrom!.Value.Year, model.DateFrom.Value.Month, model.DateFrom.Value.Day, 0, 0, 0);
310305
var midnightOfDateTo = new DateTime(model.DateTo!.Value.Year, model.DateTo.Value.Month, model.DateTo.Value.Day, 23, 59, 59);
@@ -325,8 +320,8 @@ public async Task<OperationDataResult<TimePlanningPlanningModel>> IndexByCurrent
325320

326321
try
327322
{
328-
siteModel.SoftwareVersionIsValid = currentUser.TimeRegistrationSoftwareVersion != null &&
329-
int.Parse(currentUser.TimeRegistrationSoftwareVersion.Replace(".", "")) >= 3114;
323+
siteModel.SoftwareVersionIsValid = currentUser.TimeRegistrationSoftwareVersion != null &&
324+
int.Parse(currentUser.TimeRegistrationSoftwareVersion.Replace(".", "")) >= 3114;
330325
}
331326
catch (Exception)
332327
{
@@ -904,8 +899,6 @@ await dbContext.PlanRegistrations.AsNoTracking()
904899
.OrderByDescending(x => x.Date)
905900
.FirstOrDefaultAsync();
906901

907-
if (preTimePlanningAfterThisPlanning == null) continue;
908-
909902
planningAfterThisPlanning.SumFlexStart = preTimePlanningAfterThisPlanning.SumFlexEnd;
910903
if (planningAfterThisPlanning.NettoHoursOverrideActive)
911904
{
@@ -952,21 +945,24 @@ public async Task<OperationResult> UpdateByCurrentUserNam(
952945
var currentUserAsync = await userService.GetCurrentUserAsync();
953946
var currentUser = baseDbContext.Users
954947
.Single(x => x.Id == currentUserAsync.Id);
955-
var fullName = currentUser.FirstName.Trim() + " " + currentUser.LastName.Trim();
956-
var sdkSite = await sdkDbContext.Sites
948+
var worker = await sdkDbContext.Workers
949+
.Include(x => x.SiteWorkers)
950+
.ThenInclude(x => x.Site)
957951
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
958-
.FirstOrDefaultAsync(x => x.Name.Replace(" ", "") == fullName.Replace(" ", ""));
952+
.FirstOrDefaultAsync(x => x.Email == currentUser.Email);
959953

960-
if (sdkSite == null)
954+
if (worker == null)
961955
{
962956
return new OperationDataResult<TimePlanningPlanningModel>(
963957
false,
964958
localizationService.GetString("SiteNotFound"));
965959
}
966960

961+
var mcrotingUid = worker.SiteWorkers.First().Site.MicrotingUid;
962+
967963
var assignedSite = await dbContext.AssignedSites
968964
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
969-
.FirstOrDefaultAsync(x => x.SiteId == sdkSite.MicrotingUid);
965+
.FirstOrDefaultAsync(x => x.SiteId == mcrotingUid);
970966

971967
if (assignedSite == null)
972968
{
@@ -1377,8 +1373,6 @@ await dbContext.PlanRegistrations.AsNoTracking()
13771373
.OrderByDescending(x => x.Date)
13781374
.FirstOrDefaultAsync();
13791375

1380-
if (preTimePlanningAfterThisPlanning == null) continue;
1381-
13821376
planningAfterThisPlanning.SumFlexStart = preTimePlanningAfterThisPlanning.SumFlexEnd;
13831377
planningAfterThisPlanning.SumFlexEnd = preTimePlanningAfterThisPlanning.SumFlexEnd +
13841378
planningAfterThisPlanning.NettoHours -

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningSettingService/TimeSettingService.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public class TimeSettingService(
5656
IEFormCoreService core)
5757
: ISettingService
5858
{
59-
public Task<OperationDataResult<TimePlanningSettingsModel>> GetSettings()
59+
public async Task<OperationDataResult<TimePlanningSettingsModel>> GetSettings()
6060
{
6161
try
6262
{
@@ -93,16 +93,16 @@ public Task<OperationDataResult<TimePlanningSettingsModel>> GetSettings()
9393
};
9494

9595
//timePlanningSettingsModel.AssignedSites = assignedSites;
96-
return Task.FromResult(new OperationDataResult<TimePlanningSettingsModel>(true, timePlanningSettingsModel));
96+
return new OperationDataResult<TimePlanningSettingsModel>(true, timePlanningSettingsModel);
9797
}
9898
catch (Exception e)
9999
{
100100
SentrySdk.CaptureException(e);
101101
Console.WriteLine(e);
102102
logger.LogError(e.Message);
103-
return Task.FromResult(new OperationDataResult<TimePlanningSettingsModel>(
103+
return new OperationDataResult<TimePlanningSettingsModel>(
104104
false,
105-
localizationService.GetString("ErrorWhileObtainingSettings")));
105+
localizationService.GetString("ErrorWhileObtainingSettings"));
106106
}
107107
}
108108

@@ -362,11 +362,13 @@ planRegistrationForToday is
362362
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
363363
.FirstOrDefaultAsync(x => x.Email == currentUser.Email);
364364

365-
if (sdkSite == null)
365+
if (worker == null)
366366
{
367367
return new OperationDataResult<Infrastructure.Models.Settings.AssignedSite>(false, "Site not found");
368368
}
369369

370+
var sdkSite = worker.SiteWorkers.First().Site;
371+
370372
Infrastructure.Models.Settings.AssignedSite dbAssignedSite = await dbContext.AssignedSites
371373
.Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
372374
.AsNoTracking()

0 commit comments

Comments
 (0)