Skip to content

Commit 012b917

Browse files
Copilotrenemadsen
andcommitted
Fix code review issues: unique menu button IDs and remove invalid color attribute
Co-authored-by: renemadsen <[email protected]>
1 parent 047e6e8 commit 012b917

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

eform-client/e2e/Page objects/Workflow/WorkflowCases.page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ export class WorkflowCaseRowObject {
246246
this.actionPlan = await (await $$('tbody > tr > td.mat-column-actionPlan'))[rowNum].getText();
247247
this.toBeSolvedBy = await (await $$('tbody > tr > td.mat-column-solvedBy'))[rowNum].getText();
248248
this.status = await (await $$('tbody > tr > td.mat-column-status'))[rowNum].getText();
249-
this.menuBtn = await $(`#action-items-${rowNum} #actionMenu`);
249+
this.menuBtn = await $(`#actionMenu-${rowNum}`);
250250
this.updateBtn = await $(`#editWorkflowCaseBtn-${rowNum}`);
251251
this.deleteBtn = await $(`#deleteBtn-${rowNum}`);
252252
}

eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-cases-page/workflow-cases-page.component.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
<ng-template #actionsTpl let-row let-i="index">
4848
<div class="workflow-case-actions" id="action-items-{{i}}">
49-
<button id="actionMenu" mat-icon-button [matMenuTriggerFor]="menu" matTooltip="{{ 'Actions' | translate }}">
49+
<button id="actionMenu-{{i}}" mat-icon-button [matMenuTriggerFor]="menu" matTooltip="{{ 'Actions' | translate }}">
5050
<mat-icon>more_vert</mat-icon>
5151
</button>
5252

@@ -77,7 +77,6 @@
7777
</button>
7878
<button
7979
mat-menu-item
80-
color="warn"
8180
id="deleteBtn-{{i}}"
8281
(click)="showDeleteWorkflowCaseModal(row)"
8382
>

0 commit comments

Comments
 (0)