Skip to content

Commit 843db2b

Browse files
renemadsenrenemadsen
authored
Merge pull request #4413 from microting/copilot/remove-code-warnings
Remove obsolete API warnings for MariaDbBuilder and TranslateParameterizedCollectionsToConstants
2 parents c799549 + 111a6fb commit 843db2b

File tree

10 files changed

+18
-27
lines changed

10 files changed

+18
-27
lines changed

‎eFormCore/Infrastructure/Factories/MicrotingDbContextFactory.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public MicrotingDbContext CreateDbContext(string[] args)
4040
optionsBuilder.UseMySql(args.Any() ? args[0] : defaultCs, new MariaDbServerVersion(
4141
ServerVersion.AutoDetect(args.Any() ? args[0] : defaultCs)),
4242
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
43-
builder.TranslateParameterizedCollectionsToConstants();
43+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
4444
});
4545

4646
return new MicrotingDbContext(optionsBuilder.Options);

‎eFormSDK.Base.Tests/DbTestFixture.cs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,9 @@ namespace eFormSDK.Base.Tests;
4040
public abstract class DbTestFixture
4141
{
4242
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
43-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
43+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4444
.WithDatabase(
4545
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
46-
.WithImage("mariadb:11.0.2")
4746
.Build();
4847
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
4948

‎eFormSDK.CheckLists.Tests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.CheckLists.Tests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.InSight.Tests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.InSight.Tests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.Integration.Base.CoreTests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.Integration.Base.CoreTests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.Integration.Base.SqlControllerTests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.Integration.Base.SqlControllerTests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.Integration.Case.CoreTests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.Integration.Case.CoreTests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.Integration.Case.SqlControllerTests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.Integration.Case.SqlControllerTests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.Integration.CheckLists.CoreTests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.Integration.CheckLists.CoreTests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

‎eFormSDK.Integration.CheckLists.SqlControllerTests/DbTestFixture.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ namespace eFormSDK.Integration.CheckLists.SqlControllerTests;
4343
public abstract class DbTestFixture
4444
{
4545
#pragma warning disable NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
46-
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder()
46+
private readonly MariaDbContainer _mariadbTestcontainer = new MariaDbBuilder("mariadb:11.0.2")
4747
.WithDatabase(
4848
"eformsdk-tests").WithUsername("bla").WithPassword("secretpassword")
49-
.WithImage("mariadb:11.0.2")
5049
.Build();
5150
#pragma warning restore NUnit1032 // An IDisposable field/property should be Disposed in a TearDown method
5251

@@ -61,7 +60,7 @@ private MicrotingDbContext GetContext(string connectionStr)
6160
dbContextOptionsBuilder.UseMySql(connectionStr, new MariaDbServerVersion(
6261
ServerVersion.AutoDetect(connectionStr)),
6362
mySqlOptionsAction: builder => { builder.EnableRetryOnFailure();
64-
builder.TranslateParameterizedCollectionsToConstants();
63+
builder.UseParameterizedCollectionMode(ParameterTranslationMode.Constant);
6564
});
6665
var microtingDbContext = new MicrotingDbContext(dbContextOptionsBuilder.Options);
6766
string file = Path.Combine("SQL", "eformsdk-tests.sql");

0 commit comments

Comments
 (0)