Skip to content

Commit 2ae08de

Browse files
committed
Revert "qemu: support notify sockets"
This reverts commit 3910e65. See #313 (comment)
1 parent 3910e65 commit 2ae08de

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

lib/runners/qemu.nix

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ let
146146
then "console=ttyAMA0"
147147
else "";
148148

149-
supportsNotifySocket = vsock.cid != null;
150149

151150
in
152151
lib.warnIf (mem == 2048) ''
@@ -155,16 +154,7 @@ lib.warnIf (mem == 2048) ''
155154
<https://github.com/astro/microvm.nix/issues/171>
156155
''
157156
{
158-
inherit tapMultiQueue supportsNotifySocket;
159-
160-
preStart = ''
161-
${microvmConfig.preStart}
162-
'' + lib.optionalString supportsNotifySocket ''
163-
# Start socat to forward systemd notify socket over vsock
164-
if [ -n "''${NOTIFY_SOCKET-}" ]; then
165-
${pkgs.socat}/bin/socat VSOCK-LISTEN:8888,fork UNIX-SENDTO:$NOTIFY_SOCKET &
166-
fi
167-
'';
157+
inherit tapMultiQueue;
168158

169159
command = lib.escapeShellArgs (
170160
[
@@ -310,11 +300,6 @@ lib.warnIf (mem == 2048) ''
310300
lib.optionals (vsock.cid != null) [
311301
"-device"
312302
"vhost-vsock-${devType},guest-cid=${toString vsock.cid}"
313-
# We are *supposed* to use SMBIOS here. But somehow, no matter how much I
314-
# tried, SMBIOS Type 11 entries simply don't work. It looks like it might
315-
# be broken on QEMU side. Why? I don't know.
316-
"-fw_cfg"
317-
"name=opt/io.systemd.credentials/vmm.notify_socket,string=vsock-stream:2:8888"
318303
]
319304
++
320305
extraArgs

0 commit comments

Comments
 (0)