Skip to content

Commit a90edd5

Browse files
Apply suggestions from code review
1 parent 1b3e2e9 commit a90edd5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/runners/cloud-hypervisor.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ let
1212

1313
hasUserConsole = (extractOptValues "--console" extraArgs).values != [];
1414
hasUserSerial = (extractOptValues "--serial" extraArgs).values != [];
15-
userSerial = if hasUserSerial then (extractOptValues "--serial" extraArgs).values else "";
15+
userSerial = lib.optionalString hasUserSerial (extractOptValues "--serial" extraArgs).values;
1616

1717
kernelPath = {
1818
x86_64-linux = "${kernel.dev}/vmlinux";
@@ -26,7 +26,7 @@ let
2626
then "console=ttyAMA0"
2727
else "";
2828

29-
kernelConsole = if (!hasUserSerial || userSerial == "tty") then kernelConsoleDefault else "";
29+
kernelConsole = lib.optionalString (!hasUserSerial || userSerial == "tty") kernelConsoleDefault;
3030

3131
kernelCmdLine = "${kernelConsole} reboot=t panic=-1 ${builtins.unsafeDiscardStringContext (toString microvmConfig.kernelParams)}";
3232

0 commit comments

Comments
 (0)