qemu: dont set mq=on,vectors=N for virtio-net-device

sarcasticadmin · astro · commit f0d8f6d5b4aa · 2024-02-08T16:38:27.000+01:00
Setting vcpu &gt; 1 for qemu guests would result in the following error
during guest startup:

  qemu-system-x86_64: -device virtio-net-device,netdev=host1, \
    mac=02:00:00:00:00:01,mq=on,vectors=6: Property \
    'virtio-net-device.vectors' not found
diff --git a/lib/runners/qemu.nix b/lib/runners/qemu.nix
@@ -250,7 +250,7 @@ in {
             (microvmConfig.cpu == null && system != "x86_64-linux")
           ) ",romfile="
         }${
-          lib.optionalString tapMultiQueue ",mq=on,vectors=${toString (2 * vcpu + 2)}"
+          lib.optionalString (tapMultiQueue && requirePci) ",mq=on,vectors=${toString (2 * vcpu + 2)}"
         }"
       ]) interfaces
     )

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ in {`
`250`	`250`	`(microvmConfig.cpu == null && system != "x86_64-linux")`
`251`	`251`	`) ",romfile="`
`252`	`252`	`}${`
`253`		`- lib.optionalString tapMultiQueue ",mq=on,vectors=${toString (2 * vcpu + 2)}"`
	`253`	`+ lib.optionalString (tapMultiQueue && requirePci) ",mq=on,vectors=${toString (2 * vcpu + 2)}"`
`254`	`254`	`}"`
`255`	`255`	`]) interfaces`
`256`	`256`	`)`