Skip to content

Commit 232ec41

Browse files
ilya-fedinjohn-preston
authored andcommitted
Fix absl link for libwebrtcbuild
1 parent 8c233a4 commit 232ec41

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

cmake/external.cmake

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,17 @@ endfunction()
9898
# libabsl
9999
# HINT: System abseil should be built with -DCMAKE_CXX_STANDARD=20
100100
function(link_libabsl target_name)
101+
set(scope PRIVATE)
102+
get_target_property(target_type ${target_name} TYPE)
103+
if (${target_type} STREQUAL "INTERFACE_LIBRARY")
104+
set(scope INTERFACE)
105+
endif()
101106
if (TG_OWT_PACKAGED_BUILD)
102107
find_package(absl)
103108
set(absl_FOUND ${absl_FOUND} PARENT_SCOPE)
104109
if (absl_FOUND)
105110
target_link_libraries(${target_name}
106-
PUBLIC
111+
${scope}
107112
absl::algorithm_container
108113
absl::bind_front
109114
absl::config
@@ -123,7 +128,7 @@ function(link_libabsl target_name)
123128
endif()
124129
endif()
125130
if (NOT absl_FOUND)
126-
target_link_libraries(${target_name} PRIVATE tg_owt::libabsl)
131+
target_link_libraries(${target_name} ${scope} tg_owt::libabsl)
127132
endif()
128133
endfunction()
129134

cmake/libwebrtcbuild.cmake

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ target_link_libraries(libwebrtcbuild
55
INTERFACE
66
tg_owt::libyuv
77
)
8-
if (NOT absl_FOUND)
9-
target_link_libraries(libwebrtcbuild INTERFACE tg_owt::libabsl)
10-
endif()
8+
link_libabsl(libwebrtcbuild)
119

1210
target_compile_definitions(libwebrtcbuild
1311
INTERFACE

0 commit comments

Comments
 (0)