Skip to content

Commit ad9e68e

Browse files
midd stories: update menu code to usability issue
1 parent c58cb5a commit ad9e68e

File tree

5 files changed

+20
-14
lines changed

5 files changed

+20
-14
lines changed

src/js/drawer.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,5 @@ Micromodal.init({
99
Micromodal.init({
1010
openTrigger: 'data-drawer-midd-hub',
1111
closeTrigger: 'data-drawer-close',
12-
disableScroll: false,
13-
onShow: () => {
14-
document.body.classList.add('has-toggled-elem');
15-
},
16-
onClose: () => {
17-
document.body.classList.remove('has-toggled-elem');
18-
}
12+
disableScroll: false
1913
});

src/scss/components/_drawer.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@
6666
@include breakpoints.breakpoint(lg) {
6767
margin-right: -#{variables.$spacing-5};
6868
}
69+
70+
&.is-open {
71+
display: none;
72+
}
6973
}
7074

7175
.drawer__overlay {

src/scss/components/_school-nav.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,14 @@
3131
}
3232
}
3333

34+
.site-header--midd-hub {
35+
.school-nav:focus-within {
36+
.drawer--midd-hub.is-open {
37+
display: block;
38+
}
39+
}
40+
}
41+
3442
.school-nav__menu {
3543
nav:first-child {
3644
margin-top: variables.$spacing-3;

src/templates/partials/midd-hub-header.twig

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@
4848
<span class="d-none d-lg-inline mr-2">Sections</span>
4949
{% include 'partials/icon.twig' with { name: 'bars' } %}
5050
</button>
51-
51+
52+
{% embed 'partials/midd-hub-nav.twig'
53+
with {
54+
title: 'Navigation'
55+
}
56+
%}
5257
</div>
5358

54-
{% embed 'partials/midd-hub-nav.twig'
55-
with {
56-
title: 'Navigation'
57-
}
58-
%}
5959
{% endembed %}
6060
</div>
6161
</div>

src/templates/partials/midd-hub-nav.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
{% for item in site_nav.items %}
1919
<li class="drawer-nav__item">
2020

21-
<a href="" class="drawer-nav__link drawer-nav__link--top">{{item.text}}</a>
21+
<a href="#section-label" class="drawer-nav__link drawer-nav__link--top">{{item.text}}</a>
2222

2323
{% if item.items %}
2424
<button

0 commit comments

Comments
 (0)