script for automatic music download

[Krak9n]

hey everyone.
have a question. i use this script for automatic music download from youtube, but there are some improvements that could be made. main issue is that when being in queue name of the artist, title and album art won't be displayed. i thought about maybe doing some automatic .cue sheet but im not sure about that. and i dont quite understand how mpd/rmpc treats cover arts. like, does it get it from the same directory as the track, or what.
sorry.

  #!/bin/zsh
  yt-dlp "$1"
  wait $?
  
  LAST=$(ls -t $HOME/Videos/ | head -n1)
  NEW=$(echo "$LAST")
  CUT=$(echo "$LAST" | tr -d " \t\n\r" )
  NAME=$(echo $CUT | rev | cut -f 2- -d '.' | rev)
  
  if [[ $? -eq 0 ]]; then
    ffmpeg -i $HOME/Videos/$NEW -q:a 0 -map a $NAME".flac"
  fi
  
  if [[ $? -eq 0 ]]; then
    LOCATION=$(pwd)
    mv $LOCATION/$NAME".flac" $HOME/music/$NAME".flac"
  fi

[mierak]

The cover arts are read from embedded images in the music file itself or a cover.png/jpg/webp in the files directory. You need to instruct yt-dlp to download the image alongside the music data, see what rmpc does with its yt dlp integration for example

rmpc/src/shared/ytdlp/downloader.rs

Lines 102 to 117 in c8698ec

	let mut command = Command::new("yt-dlp");
	command.arg("-x");
	command.arg("--embed-thumbnail");
	command.arg("--embed-metadata");
	command.arg("-f");
	command.arg("bestaudio");
	command.arg("--convert-thumbnails");
	command.arg("jpg");
	for arg in &self.extra_args {
	command.arg(arg);
	}
	command.arg("--output");
	command.arg(cache);
	command.arg(id.to_url());

the metadata embedding is also done with --embed-metadata

[Krak9n]

The cover arts are read from embedded images in the music file itself or a cover.png/jpg/webp in the files directory. You need to instruct yt-dlp to download the image alongside the music data, see what rmpc does with its yt dlp integration for example

rmpc/src/shared/ytdlp/downloader.rs

Lines 102 to 117 in c8698ec

	let mut command = Command::new("yt-dlp");
	command.arg("-x");
	command.arg("--embed-thumbnail");
	command.arg("--embed-metadata");
	command.arg("-f");
	command.arg("bestaudio");
	command.arg("--convert-thumbnails");
	command.arg("jpg");
	for arg in &self.extra_args {
	command.arg(arg);
	}
	command.arg("--output");
	command.arg(cache);
	command.arg(id.to_url());

the metadata embedding is also done with --embed-metadata

ye that was it..
now everything works just fine :))
script is now just few moving commands lmao

  #!/bin/zsh
  yt-dlp -x --embed-thumbnail --embed-metadata -f bestaudio --convert-thumbnails jpg "$1"
  
  LAST=$(ls -t $HOME/Videos/ | head -n1)
  NEW=$(echo "$LAST")
  
  if [[ $? -eq 0 ]]; then
    LOCATION=$(pwd)
    mv $HOME/Videos/$NEW $HOME/music/
  fi