-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Problem
macOS CI builds provide false confidence. They miss real compilation errors because:
#[cfg(target_os = "linux")]gated code is skipped entirely — overlay, resize watcher, nsenter, and other Linux-only code is never compiled- Type resolution differs — controller feature types like
OwnerReferenceandObjectMetaresolve fromkube::apion macOS but needk8s_openapi::apimachinery::...on Linux - Reaper only runs on Linux — it's a container runtime that uses Linux-specific syscalls (unshare, pivot_root, setns, etc.)
Evidence
- PR feat: ReaperDaemonJob CRD for node configuration tasks #58:
OwnerReferencenot found error only surfaced in Linux CI, not macOS clippy - This pattern has repeated multiple times with
#[cfg(target_os = "linux")]gated code
Proposal
- Remove macOS build/test jobs from CI workflows
- Keep only Linux builds (native or cross-compilation)
- This saves CI minutes and eliminates false-green builds
Impact
- Faster CI (fewer jobs)
- No more "passes locally on macOS, fails in CI on Linux" surprises
- Developers on macOS should use
cargo clippy --target x86_64-unknown-linux-gnulocally
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels