Move numpy dense vector to a subclass

Author: miguelgrinberg

elasticsearch/dsl/field.py

@@ -1555,8 +1555,6 @@ class DenseVector(Field):
     :arg dynamic:
     :arg fields:
     :arg synthetic_source_keep:
-    :arg use_numpy: if set to ``True``, deserialize as a numpy array.
-    :arg dtype: The numpy data type to use as a string, when ``use_numpy`` is ``True``. The default is "float32".
     """
 
     name = "dense_vector"
@@ -1589,8 +1587,6 @@ def __init__(
         synthetic_source_keep: Union[
             Literal["none", "arrays", "all"], "DefaultType"
         ] = DEFAULT,
-        use_numpy: bool = False,
-        dtype: str = "float32",
         **kwargs: Any,
     ):
         if dims is not DEFAULT:
@@ -1618,8 +1614,6 @@ def __init__(
         self._element_type = kwargs.get("element_type", "float")
         if self._element_type in ["float", "byte"]:
             kwargs["multi"] = True
-        self._use_numpy = use_numpy
-        self._dtype = dtype
         super().__init__(*args, **kwargs)
 
 

utils/templates/field.py.tpl

@@ -217,10 +217,6 @@ class {{ k.name }}({{ k.parent }}):
             {% endfor %}
         {% endfor %}
     {% endif %}
-    {% if k.field == "dense_vector" %}
-    :arg use_numpy: if set to ``True``, deserialize as a numpy array.
-    :arg dtype: The numpy data type to use as a string, when ``use_numpy`` is ``True``. The default is "float32".
-    {% endif %}
     """
     name = "{{ k.field }}"
     {% if k.coerced %}
@@ -250,10 +246,6 @@ class {{ k.name }}({{ k.parent }}):
         {{ arg.name }}: {{ arg.type }} = DEFAULT,
             {% endif %}
         {% endfor %}
-        {% if k.field == "dense_vector" %}
-        use_numpy: bool = False,
-        dtype: str = "float32",
-        {% endif %}
         **kwargs: Any
     ):
         {% for arg in k.args %}
@@ -424,8 +416,6 @@ class {{ k.name }}({{ k.parent }}):
         self._element_type = kwargs.get("element_type", "float")
         if self._element_type in ["float", "byte"]:
             kwargs["multi"] = True
-        self._use_numpy = use_numpy
-        self._dtype = dtype
         super().__init__(*args, **kwargs)
 
 class NumpyDenseVector(DenseVector):