Redundant url parse in asyncio driver

[PaulWasTaken]

Greetings, I'd like to ask about this line of code urlsplit. Here we parse request path, but the request already has it parsed in request.url.query_string and request.url.path.

aiohttp==3.12.13
python-engineio==4.12.2
python-socketio==5.13.0

Do I miss something or PR is welcome?)

[miguelgrinberg]

Do I miss something

The code you reference was written 9 years ago, and to my knowledge has worked with all the releases of aiohttp since those days. If you are going to change it you need to research which versions you are breaking, or better said, how far back into aiohttp versions your proposed change works. Only after knowing that I can tell you if it makes sense to make the change or not.

[PaulWasTaken]

After a small investigation I found out that we don't even need to call request.url, we can call request.path/request.query_string directly since they are just proxies.

Engineio requires python>=3.6, according to pypi the least supported aiohttp version is 1.3.2 and this API is already introduced, but with deprecation warning. In 2.0 it was moved to web_request
Another one "participant" is yarl library. In 2.3.7 it it >=0.11 and was updated to >=1.0.0 only in 2.3.8.

I managed to launch test usign python 3.6.0, aiohttp==1.3.2, python-engineio==4.12.2, python-socketio==5.5.1 and it worked. request.path and request.query_string are available.

By the way engineio has some troubles with this configuration, at least for me. I got

  File "/work/venv/test/lib/python3.6/site-packages/engineio/async_client.py", line 112, in connect
    asyncio.get_running_loop().add_signal_handler(
AttributeError: module 'asyncio' has no attribute 'get_running_loop'

  File "/work/venv/test/lib/python3.6/site-packages/engineio/async_client.py", line 341, in _connect_websocket
    except (aiohttp.client_exceptions.WSServerHandshakeError,
AttributeError: module 'aiohttp' has no attribute 'client_exceptions'

  File "/work/venv/test/lib/python3.6/site-packages/engineio/async_drivers/aiohttp.py", line 93, in __call__
    self._sock = WebSocketResponse(max_msg_size=0)
TypeError: __init__() got an unexpected keyword argument 'max_msg_size'

Server

import socketio
from aiohttp import web

sio = socketio.AsyncServer()
app = web.Application()
sio.attach(app)

@sio.event
def connect(sid, environ):
    print("connect ", sid)


@sio.event
def disconnect(sid):
    print('disconnect ', sid)


if __name__ == '__main__':
    web.run_app(app)

Client

import asyncio

import socketio


async def main():
    test_client = socketio.AsyncClient(reconnection=False)
    await test_client.connect(
        'http://localhost:8080',
        transports=['websocket'],
        wait=True,
        wait_timeout=15,
    )
    await asyncio.sleep(2)
    await test_client.disconnect()


if __name__ == '__main__':
    loop = asyncio.get_event_loop()
    loop.run_until_complete(main())

As far as I understand there should't be any trouble with aiohttp

[miguelgrinberg]

Okay, please submit the PR with the change. Thanks!

I should have raised the minimum version of Python to 3.8, I'm not surprised it fails on 3.6 because there were some changes in how you obtain the async loop. Also note that the minimum aiohttp version is 3.4, so you went back beyond what is needed, which is good. Thanks!

[miguelgrinberg]

#419 is merged. Thanks!