Skip to content

Commit 23556fb

Browse files
Fixed transport property of the simple clients to be a string as documented (Fixes #1499)
1 parent e59acf1 commit 23556fb

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/socketio/async_simple_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def transport(self):
105105
The transport is returned as a string and can be one of ``polling``
106106
and ``websocket``.
107107
"""
108-
return self.client.transport if self.client else ''
108+
return self.client.transport() if self.client else ''
109109

110110
async def emit(self, event, data=None):
111111
"""Emit an event to the server.

src/socketio/simple_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ def transport(self):
103103
The transport is returned as a string and can be one of ``polling``
104104
and ``websocket``.
105105
"""
106-
return self.client.transport if self.client else ''
106+
return self.client.transport() if self.client else ''
107107

108108
def emit(self, event, data=None):
109109
"""Emit an event to the server.

tests/async/test_simple_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ async def test_connect_twice(self):
7272

7373
async def test_properties(self):
7474
client = AsyncSimpleClient()
75-
client.client = mock.MagicMock(transport='websocket')
75+
client.client = mock.MagicMock(transport=lambda: 'websocket')
7676
client.client.get_sid.return_value = 'sid'
7777
client.connected_event.set()
7878
client.connected = True

tests/common/test_simple_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def test_connect_twice(self):
6464

6565
def test_properties(self):
6666
client = SimpleClient()
67-
client.client = mock.MagicMock(transport='websocket')
67+
client.client = mock.MagicMock(transport=lambda: 'websocket')
6868
client.client.get_sid.return_value = 'sid'
6969
client.connected_event.set()
7070
client.connected = True

0 commit comments

Comments
 (0)