Skip to content

Commit 608a82f

Browse files
committed
fix: add warnings
1 parent 30b67dd commit 608a82f

File tree

1 file changed

+21
-4
lines changed

1 file changed

+21
-4
lines changed

src/socketio/msgpack_packet.py

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
1+
import logging
12
import msgpack
23
from . import packet
34

5+
logger = logging.getLogger('socketio')
6+
47

58
class MsgPackPacket(packet.Packet):
69
uses_binary_events = False
710

811
def encode(self):
912
"""Encode the packet for transmission."""
1013
return self._encode()
11-
14+
1215
def _encode(self, **kwargs):
1316
return _msgpack.dumps(self._to_dict(), **kwargs)
1417

1518
def decode(self, encoded_packet):
1619
"""Decode a transmitted package."""
1720
return self._decode(encoded_packet)
18-
21+
1922
def _decode(self, encoded_packet, **kwargs):
2023
decoded = msgpack.loads(encoded_packet, **kwargs)
2124
self.packet_type = decoded['type']
@@ -28,12 +31,26 @@ def _configure(cls, *args, **kwargs):
2831
dumps_default = kwargs.pop('dumps_default', None)
2932
ext_hook = kwargs.pop('ext_hook', msgpack.ExtType)
3033

34+
if args:
35+
logger.warning(
36+
'Some positional arguments to MsgPackPacket.configure() are '
37+
'not used: %s',
38+
args,
39+
)
40+
if kwargs:
41+
logger.warning(
42+
'Some keyword arguments to MsgPackPacket.configure() are '
43+
'not used: %s',
44+
kwargs,
45+
)
46+
3147
class ConfiguredMsgPackPacket(cls):
3248
def _encode(self, **kwargs):
3349
kwargs.setdefault('default', dumps_default)
3450
return super()._encode(**kwargs)
51+
3552
def _decode(self, encoded_packet, **kwargs):
3653
kwargs.setdefault('ext_hook', ext_hook)
3754
return super()._decode(encoded_packet, **kwargs)
38-
39-
return ConfiguredMsgPackPacket
55+
56+
return ConfiguredMsgPackPacket

0 commit comments

Comments
 (0)