Data validation

Author: Miguel Targa

package.json

@@ -2,7 +2,7 @@
   "name": "ssh-control",
   "displayName": "SSH Control",
   "description": "Manage SSH connections directly from VSCode.",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "publisher": "migueltarga",
   "author": {
     "name": "Miguel Targa",

src/remoteHostsService.ts

@@ -101,9 +101,15 @@ export class RemoteHostsService {
       if (Array.isArray(jsonData)) {
         return { hosts: jsonData };
       } else if (jsonData.hosts || jsonData.groups) {
+        // Ensure remote groups have required properties
+        const normalizedGroups = (jsonData.groups || []).map((group: any) => ({
+          ...group,
+          hosts: group.hosts || []
+        }));
+        
         return {
           hosts: jsonData.hosts || [],
-          groups: jsonData.groups || []
+          groups: normalizedGroups
         };
       } else if (jsonData.hosts && Array.isArray(jsonData.hosts)) {
         return { hosts: jsonData.hosts };

src/sshConfigManager.ts

@@ -51,13 +51,43 @@ export class SSHConfigManager {
 
     try {
       const configData = fs.readFileSync(this.configPath, 'utf8');
-      return JSON.parse(configData);
+      const config = JSON.parse(configData);
+      return this.validateAndNormalizeConfig(config);
     } catch (error) {
       vscode.window.showErrorMessage(`Failed to load SSH config: ${error}`);
       return { groups: [] };
     }
   }
 
+  private validateAndNormalizeConfig(config: any): SSHConfig {
+    if (!config || typeof config !== 'object') {
+      return { groups: [] };
+    }
+
+    const normalizedConfig: SSHConfig = {
+      groups: Array.isArray(config.groups) ? config.groups.map(this.validateAndNormalizeGroup) : []
+    };
+
+    return normalizedConfig;
+  }
+
+  private validateAndNormalizeGroup = (group: any): SSHGroup => {
+    if (!group || typeof group !== 'object' || !group.name) {
+      throw new Error('Invalid group structure');
+    }
+
+    return {
+      name: group.name,
+      defaultUser: group.defaultUser,
+      defaultPort: group.defaultPort,
+      defaultIdentityFile: group.defaultIdentityFile,
+      defaultPreferredAuthentication: group.defaultPreferredAuthentication,
+      hosts: Array.isArray(group.hosts) ? group.hosts : [],
+      groups: Array.isArray(group.groups) ? group.groups.map(this.validateAndNormalizeGroup) : undefined,
+      remoteHosts: group.remoteHosts
+    };
+  };
+
   async saveConfig(config: SSHConfig): Promise<void> {
     try {
       const configData = JSON.stringify(config, null, 2);

src/sshTreeDataProvider.ts

@@ -59,6 +59,9 @@ export class SSHTreeDataProvider implements vscode.TreeDataProvider<SSHTreeItem>
     if (!element) {
       // Root level - return top-level groups
       const config = await this.configManager.loadConfig();
+      if (!config || !config.groups || !Array.isArray(config.groups)) {
+        return [];
+      }
       return config.groups.map((group, index) => ({
         type: 'group',
         group,