Check if shots exist before mapping them

Author: miharekar

app/jobs/refresh_token_job.rb

@@ -7,7 +7,8 @@ class RefreshTokenJob < ApplicationJob
 
   def perform(identity)
     identity.refresh_token!
+    return unless identity.airtable?
 
-    AirtableShotUploadAllJob.set(wait: 2.minutes).perform_later(identity.user) if identity.airtable?
+    AirtableShotUploadAllJob.set(wait: 2.minutes).perform_later(identity.user)
   end
 end

app/models/airtable/shots.rb

@@ -20,12 +20,14 @@ def upload(shot)
       if shot.airtable_id
         update_record(shot.airtable_id, prepare_record(shot))
       else
-        upload_multiple(::Shot.where(id: shot.id))
+        upload_multiple(::Shot.where(user:, id: shot.id))
       end
     end
 
     def upload_multiple(shots)
-      records = shots.where(user:).with_attached_image.map { |shot| prepare_record(shot) }
+      return unless shots.exists?
+
+      records = shots.with_attached_image.map { |shot| prepare_record(shot) }
       update_records(records) do |response|
         response["records"].each do |record|
           shot = shots.find_by(id: record["fields"]["ID"])