Skip to content

Commit fa8caad

Browse files
buslabryantbiggs
andauthored
fix: Ignore tags_all for aws_appautoscaling_target (terraform-aws-modules#431)
* fix: added enable_appautoscaling_tags variable * fix: dynamically set aws_appautoscaling_target tags * chore: revert variable changes * fix: set lifecycle ignore_changes on tags_all * fix: Correct pre-commit checks --------- Co-authored-by: Bryant Biggs <[email protected]>
1 parent cf30ef7 commit fa8caad

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
repos:
22
- repo: https://github.com/antonbabenko/pre-commit-terraform
3-
rev: v1.83.6
3+
rev: v1.86.0
44
hooks:
55
- id: terraform_fmt
66
- id: terraform_validate
@@ -27,3 +27,4 @@ repos:
2727
hooks:
2828
- id: check-merge-conflict
2929
- id: end-of-file-fixer
30+
- id: trailing-whitespace

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ All notable changes to this project will be documented in this file
538538
- Add cluster ARN output as 'this_rds_cluster_arn' ([#48](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/48))
539539
- Upgraded module to support Terraform 0.12 ([#45](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/45))
540540

541-
###
541+
###
542542

543543
on ../../modules/aws-rds-aurora/main.tf line 4, in locals:
544544

@@ -586,7 +586,7 @@ when calling import with this module in the configuration.
586586
- Add cluster ARN output as 'this_rds_cluster_arn' ([#48](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/48))
587587
- Upgraded module to support Terraform 0.12 ([#45](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/45))
588588

589-
###
589+
###
590590

591591
on ../../modules/aws-rds-aurora/main.tf line 4, in locals:
592592

main.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,12 @@ resource "aws_appautoscaling_target" "this" {
278278
service_namespace = "rds"
279279

280280
tags = var.tags
281+
282+
lifecycle {
283+
ignore_changes = [
284+
tags_all,
285+
]
286+
}
281287
}
282288

283289
resource "aws_appautoscaling_policy" "this" {

0 commit comments

Comments
 (0)