Skip to content

Commit be3ea2c

Browse files
authored
Fix linting, husky preventing from committing (#112)
* Update husky * [EsLint] Use dev dependency * [EsLint] Globally disable jsx-props-no-spreading
1 parent 99b673c commit be3ea2c

File tree

9 files changed

+9
-116
lines changed

9 files changed

+9
-116
lines changed

.eslintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
]
4343
}
4444
],
45+
"react/jsx-props-no-spreading": "off",
4546
"no-multi-assign": 0,
4647
"arrow-body-style": [
4748
"error",

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"build": "yarn clean & cross-env NODE_ENV=production rollup -c && packito",
1414
"build-storybook": "build-storybook -c .storybook -o public",
1515
"storybook": "start-storybook -p 9005 -c .storybook",
16-
"lint": "$(yarn bin)/eslint src",
16+
"lint": "eslint src",
1717
"test": "cross-env NODE_ENV=test jest",
1818
"coverage": "cross-env NODE_ENV=test jest --coverage --colors",
1919
"prepublishOnly": "yarn build"
@@ -48,7 +48,7 @@
4848
"eslint-plugin-prettier": "^3.1.2",
4949
"eslint-plugin-react": "^7.18.3",
5050
"eslint-plugin-react-hooks": "^2.3.0",
51-
"husky": "^4.2.1",
51+
"husky": "^5.1.3",
5252
"jest": "^25.1.0",
5353
"jest-css-modules": "^2.1.0",
5454
"jest-styled-components": "^7.0.0",

src/components/ColorBox/AlphaSlider.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ function AlphaSlider({ color, ...props }) {
5656

5757
return (
5858
<Slider
59-
// eslint-disable-next-line react/jsx-props-no-spreading
6059
{...props}
6160
classes={{
6261
root: classes.root,

src/components/ColorBox/HSVGradient.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable react/jsx-props-no-spreading */
21
/**
32
* Copyright (c) Mik BRY
43

src/components/ColorBox/HueSlider.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ function HueSlider(props) {
5050

5151
return (
5252
<Slider
53-
// eslint-disable-next-line react/jsx-props-no-spreading
5453
{...props}
5554
classes={{
5655
root: classes.root,

src/components/ColorBox/index.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable react/jsx-props-no-spreading */
21
/**
32
* Copyright (c) Mik BRY
43

src/components/ColorButton.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable react/jsx-props-no-spreading */
21
/**
32
* Copyright (c) Mik BRY
43

src/components/ColorPicker.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/* eslint-disable jsx-a11y/interactive-supports-focus */
22
/* eslint-disable jsx-a11y/click-events-have-key-events */
3-
/* eslint-disable react/jsx-props-no-spreading */
43
/**
54
* Copyright (c) Mik BRY
65

yarn.lock

Lines changed: 6 additions & 108 deletions
Original file line numberDiff line numberDiff line change
@@ -4510,11 +4510,6 @@ compare-func@^1.3.1:
45104510
array-ify "^1.0.0"
45114511
dot-prop "^3.0.0"
45124512

4513-
compare-versions@^3.6.0:
4514-
version "3.6.0"
4515-
resolved "https://registry.yarnpkg.com/compare-versions/-/compare-versions-3.6.0.tgz#1a5689913685e5a87637b8d3ffca75514ec41d62"
4516-
integrity sha512-W6Af2Iw1z4CB7q4uU4hv646dW9GQuBM+YpC0UvUCWSD8w90SJjp+ujJuXaEMtAXBtSqGfMPuFOVn4/+FlaqfBA==
4517-
45184513
component-emitter@^1.2.1:
45194514
version "1.3.0"
45204515
resolved "https://registry.yarnpkg.com/component-emitter/-/component-emitter-1.3.0.tgz#16e4070fba8ae29b679f2215853ee181ab2eabc0"
@@ -4720,17 +4715,6 @@ cosmiconfig@^6.0.0:
47204715
path-type "^4.0.0"
47214716
yaml "^1.7.2"
47224717

4723-
cosmiconfig@^7.0.0:
4724-
version "7.0.0"
4725-
resolved "https://registry.yarnpkg.com/cosmiconfig/-/cosmiconfig-7.0.0.tgz#ef9b44d773959cae63ddecd122de23853b60f8d3"
4726-
integrity sha512-pondGvTuVYDk++upghXJabWzL6Kxu6f26ljFw64Swq9v6sQPUL3EUlVDV56diOjpCayKihL6hVe8exIACU4XcA==
4727-
dependencies:
4728-
"@types/parse-json" "^4.0.0"
4729-
import-fresh "^3.2.1"
4730-
parse-json "^5.0.0"
4731-
path-type "^4.0.0"
4732-
yaml "^1.10.0"
4733-
47344718
create-ecdh@^4.0.0:
47354719
version "4.0.4"
47364720
resolved "https://registry.yarnpkg.com/create-ecdh/-/create-ecdh-4.0.4.tgz#d6e7f4bffa66736085a0762fd3a632684dabcc4e"
@@ -6232,21 +6216,6 @@ find-up@^4.0.0, find-up@^4.1.0:
62326216
locate-path "^5.0.0"
62336217
path-exists "^4.0.0"
62346218

6235-
find-up@^5.0.0:
6236-
version "5.0.0"
6237-
resolved "https://registry.yarnpkg.com/find-up/-/find-up-5.0.0.tgz#4c92819ecb7083561e4f4a240a86be5198f536fc"
6238-
integrity sha512-78/PXT1wlLLDgTzDs7sjq9hzz0vXD+zn+7wypEe4fXQxCmdmqfGsEPQxmiCSQI3ajFV91bVSsvNtrJRiW6nGng==
6239-
dependencies:
6240-
locate-path "^6.0.0"
6241-
path-exists "^4.0.0"
6242-
6243-
find-versions@^4.0.0:
6244-
version "4.0.0"
6245-
resolved "https://registry.yarnpkg.com/find-versions/-/find-versions-4.0.0.tgz#3c57e573bf97769b8cb8df16934b627915da4965"
6246-
integrity sha512-wgpWy002tA+wgmO27buH/9KzyEOQnKsG/R0yrcjPT9BOFm0zRBVQbZ95nRGXWMywS8YR5knRbpohio0bcJABxQ==
6247-
dependencies:
6248-
semver-regex "^3.1.2"
6249-
62506219
flat-cache@^2.0.1:
62516220
version "2.0.1"
62526221
resolved "https://registry.yarnpkg.com/flat-cache/-/flat-cache-2.0.1.tgz#5d296d6f04bda44a4630a301413bdbc2ec085ec0"
@@ -7050,21 +7019,10 @@ human-signals@^1.1.1:
70507019
resolved "https://registry.yarnpkg.com/human-signals/-/human-signals-1.1.1.tgz#c5b1cd14f50aeae09ab6c59fe63ba3395fe4dfa3"
70517020
integrity sha512-SEQu7vl8KjNL2eoGBLF3+wAjpsNfA9XMlXAYj/3EdaNfAlxKthD1xjEQfGOUhllCGGJVNY34bRr6lPINhNjyZw==
70527021

7053-
husky@^4.2.1:
7054-
version "4.3.7"
7055-
resolved "https://registry.yarnpkg.com/husky/-/husky-4.3.7.tgz#ca47bbe6213c1aa8b16bbd504530d9600de91e88"
7056-
integrity sha512-0fQlcCDq/xypoyYSJvEuzbDPHFf8ZF9IXKJxlrnvxABTSzK1VPT2RKYQKrcgJ+YD39swgoB6sbzywUqFxUiqjw==
7057-
dependencies:
7058-
chalk "^4.0.0"
7059-
ci-info "^2.0.0"
7060-
compare-versions "^3.6.0"
7061-
cosmiconfig "^7.0.0"
7062-
find-versions "^4.0.0"
7063-
opencollective-postinstall "^2.0.2"
7064-
pkg-dir "^5.0.0"
7065-
please-upgrade-node "^3.2.0"
7066-
slash "^3.0.0"
7067-
which-pm-runs "^1.0.0"
7022+
husky@^5.1.3:
7023+
version "5.1.3"
7024+
resolved "https://registry.yarnpkg.com/husky/-/husky-5.1.3.tgz#1a0645a4fe3ffc006c4d0d8bd0bcb4c98787cc9d"
7025+
integrity sha512-fbNJ+Gz5wx2LIBtMweJNY1D7Uc8p1XERi5KNRMccwfQA+rXlxWNSdUxswo0gT8XqxywTIw7Ywm/F4v/O35RdMg==
70687026

70697027
hyphenate-style-name@^1.0.3:
70707028
version "1.0.4"
@@ -7154,7 +7112,7 @@ import-fresh@^2.0.0:
71547112
caller-path "^2.0.0"
71557113
resolve-from "^3.0.0"
71567114

7157-
import-fresh@^3.0.0, import-fresh@^3.1.0, import-fresh@^3.2.1:
7115+
import-fresh@^3.0.0, import-fresh@^3.1.0:
71587116
version "3.3.0"
71597117
resolved "https://registry.yarnpkg.com/import-fresh/-/import-fresh-3.3.0.tgz#37162c25fcb9ebaa2e6e53d5b4d88ce17d9e0c2b"
71607118
integrity sha512-veYYhQa+D1QBKznvhUHxb8faxlrwUnxseDAbAp457E0wLNio2bOSKnjYDhMj+YiAq61xrMGhQk9iXVk5FzgQMw==
@@ -8722,13 +8680,6 @@ locate-path@^5.0.0:
87228680
dependencies:
87238681
p-locate "^4.1.0"
87248682

8725-
locate-path@^6.0.0:
8726-
version "6.0.0"
8727-
resolved "https://registry.yarnpkg.com/locate-path/-/locate-path-6.0.0.tgz#55321eb309febbc59c4801d931a72452a681d286"
8728-
integrity sha512-iPZK6eYjbxRu3uB4/WZ3EsEIMJFMqAoopl3R+zuq0UjcAm/MO6KCweDgPfP3elTztoKP3KtnVHxTn2NHBSDVUw==
8729-
dependencies:
8730-
p-locate "^5.0.0"
8731-
87328683
lodash-es@^4.17.15:
87338684
version "4.17.20"
87348685
resolved "https://registry.yarnpkg.com/lodash-es/-/lodash-es-4.17.20.tgz#29f6332eefc60e849f869c264bc71126ad61e8f7"
@@ -9727,11 +9678,6 @@ open@^7.0.0:
97279678
is-docker "^2.0.0"
97289679
is-wsl "^2.1.1"
97299680

9730-
opencollective-postinstall@^2.0.2:
9731-
version "2.0.3"
9732-
resolved "https://registry.yarnpkg.com/opencollective-postinstall/-/opencollective-postinstall-2.0.3.tgz#7a0fff978f6dbfa4d006238fbac98ed4198c3259"
9733-
integrity sha512-8AV/sCtuzUeTo8gQK5qDZzARrulB3egtLzFgteqB2tcT4Mw7B8Kt7JcDHmltjz6FOAHsvTevk70gZEbhM4ZS9Q==
9734-
97359681
optionator@^0.8.1, optionator@^0.8.3:
97369682
version "0.8.3"
97379683
resolved "https://registry.yarnpkg.com/optionator/-/optionator-0.8.3.tgz#84fa1d036fe9d3c7e21d99884b601167ec8fb495"
@@ -9790,13 +9736,6 @@ p-limit@^2.0.0, p-limit@^2.2.0, p-limit@^2.3.0:
97909736
dependencies:
97919737
p-try "^2.0.0"
97929738

9793-
p-limit@^3.0.2:
9794-
version "3.1.0"
9795-
resolved "https://registry.yarnpkg.com/p-limit/-/p-limit-3.1.0.tgz#e1daccbe78d0d1388ca18c64fea38e3e57e3706b"
9796-
integrity sha512-TYOanM3wGwNGsZN2cVTYPArw454xnXj5qmWF1bEoAc4+cU/ol7GVh7odevjp1FNHduHc3KZMcFduxU5Xc6uJRQ==
9797-
dependencies:
9798-
yocto-queue "^0.1.0"
9799-
98009739
p-locate@^2.0.0:
98019740
version "2.0.0"
98029741
resolved "https://registry.yarnpkg.com/p-locate/-/p-locate-2.0.0.tgz#20a0103b222a70c8fd39cc2e580680f3dde5ec43"
@@ -9818,13 +9757,6 @@ p-locate@^4.1.0:
98189757
dependencies:
98199758
p-limit "^2.2.0"
98209759

9821-
p-locate@^5.0.0:
9822-
version "5.0.0"
9823-
resolved "https://registry.yarnpkg.com/p-locate/-/p-locate-5.0.0.tgz#83c8315c6785005e3bd021839411c9e110e6d834"
9824-
integrity sha512-LaNjtRWUBY++zB5nE/NwcaoMylSPk+S+ZHNB1TzdbMJMny6dynpAGt7X/tl/QYq3TIeE6nxHppbo2LGymrG5Pw==
9825-
dependencies:
9826-
p-limit "^3.0.2"
9827-
98289760
p-map@^3.0.0:
98299761
version "3.0.0"
98309762
resolved "https://registry.yarnpkg.com/p-map/-/p-map-3.0.0.tgz#d704d9af8a2ba684e2600d9a215983d4141a979d"
@@ -10096,27 +10028,13 @@ pkg-dir@^4.1.0, pkg-dir@^4.2.0:
1009610028
dependencies:
1009710029
find-up "^4.0.0"
1009810030

10099-
pkg-dir@^5.0.0:
10100-
version "5.0.0"
10101-
resolved "https://registry.yarnpkg.com/pkg-dir/-/pkg-dir-5.0.0.tgz#a02d6aebe6ba133a928f74aec20bafdfe6b8e760"
10102-
integrity sha512-NPE8TDbzl/3YQYY7CSS228s3g2ollTFnc+Qi3tqmqJp9Vg2ovUpixcJEo2HJScN2Ez+kEaal6y70c0ehqJBJeA==
10103-
dependencies:
10104-
find-up "^5.0.0"
10105-
1010610031
1010710032
version "2.0.0"
1010810033
resolved "https://registry.yarnpkg.com/pkg-up/-/pkg-up-2.0.0.tgz#c819ac728059a461cab1c3889a2be3c49a004d7f"
1010910034
integrity sha1-yBmscoBZpGHKscOImivjxJoATX8=
1011010035
dependencies:
1011110036
find-up "^2.1.0"
1011210037

10113-
please-upgrade-node@^3.2.0:
10114-
version "3.2.0"
10115-
resolved "https://registry.yarnpkg.com/please-upgrade-node/-/please-upgrade-node-3.2.0.tgz#aeddd3f994c933e4ad98b99d9a556efa0e2fe942"
10116-
integrity sha512-gQR3WpIgNIKwBMVLkpMUeR3e1/E1y42bqDQZfql+kDeXd8COYfM8PQA4X6y7a8u9Ua9FHmsrrmirW2vHs45hWg==
10117-
dependencies:
10118-
semver-compare "^1.0.0"
10119-
1012010038
pn@^1.1.0:
1012110039
version "1.1.0"
1012210040
resolved "https://registry.yarnpkg.com/pn/-/pn-1.1.0.tgz#e2f4cef0e219f463c179ab37463e4e1ecdccbafb"
@@ -11650,16 +11568,6 @@ select@^1.1.2:
1165011568
resolved "https://registry.yarnpkg.com/select/-/select-1.1.2.tgz#0e7350acdec80b1108528786ec1d4418d11b396d"
1165111569
integrity sha1-DnNQrN7ICxEIUoeG7B1EGNEbOW0=
1165211570

11653-
semver-compare@^1.0.0:
11654-
version "1.0.0"
11655-
resolved "https://registry.yarnpkg.com/semver-compare/-/semver-compare-1.0.0.tgz#0dee216a1c941ab37e9efb1788f6afc5ff5537fc"
11656-
integrity sha1-De4hahyUGrN+nvsXiPavxf9VN/w=
11657-
11658-
semver-regex@^3.1.2:
11659-
version "3.1.2"
11660-
resolved "https://registry.yarnpkg.com/semver-regex/-/semver-regex-3.1.2.tgz#34b4c0d361eef262e07199dbef316d0f2ab11807"
11661-
integrity sha512-bXWyL6EAKOJa81XG1OZ/Yyuq+oT0b2YLlxx7c+mrdYPaPbnj6WgVULXhinMIeZGufuUBu/eVRqXEhiv4imfwxA==
11662-
1166311571
"semver@2 || 3 || 4 || 5", semver@^5.4.1, semver@^5.5.0, semver@^5.6.0:
1166411572
version "5.7.1"
1166511573
resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7"
@@ -13441,11 +13349,6 @@ which-module@^2.0.0:
1344113349
resolved "https://registry.yarnpkg.com/which-module/-/which-module-2.0.0.tgz#d9ef07dce77b9902b8a3a8fa4b31c3e3f7e6e87a"
1344213350
integrity sha1-2e8H3Od7mQK4o6j6SzHD4/fm6Ho=
1344313351

13444-
which-pm-runs@^1.0.0:
13445-
version "1.0.0"
13446-
resolved "https://registry.yarnpkg.com/which-pm-runs/-/which-pm-runs-1.0.0.tgz#670b3afbc552e0b55df6b7780ca74615f23ad1cb"
13447-
integrity sha1-Zws6+8VS4LVd9rd4DKdGFfI60cs=
13448-
1344913352
which@^1.2.9, which@^1.3.1:
1345013353
version "1.3.1"
1345113354
resolved "https://registry.yarnpkg.com/which/-/which-1.3.1.tgz#a45043d54f5805316da8d62f9f50918d3da70b0a"
@@ -13592,7 +13495,7 @@ yallist@^4.0.0:
1359213495
resolved "https://registry.yarnpkg.com/yallist/-/yallist-4.0.0.tgz#9bb92790d9c0effec63be73519e11a35019a3a72"
1359313496
integrity sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A==
1359413497

13595-
yaml@^1.10.0, yaml@^1.7.2:
13498+
yaml@^1.7.2:
1359613499
version "1.10.0"
1359713500
resolved "https://registry.yarnpkg.com/yaml/-/yaml-1.10.0.tgz#3b593add944876077d4d683fee01081bd9fff31e"
1359813501
integrity sha512-yr2icI4glYaNG+KWONODapy2/jDdMSDnrONSjblABjD9B4Z5LgiircSt8m8sRZFNi08kG9Sm0uSHtEmP3zaEGg==
@@ -13634,11 +13537,6 @@ yargs@^15.3.1:
1363413537
y18n "^4.0.0"
1363513538
yargs-parser "^18.1.2"
1363613539

13637-
yocto-queue@^0.1.0:
13638-
version "0.1.0"
13639-
resolved "https://registry.yarnpkg.com/yocto-queue/-/yocto-queue-0.1.0.tgz#0294eb3dee05028d31ee1a5fa2c556a6aaf10a1b"
13640-
integrity sha512-rVksvsnNCdJ/ohGc6xgPwyN8eheCxsiLM8mxuE/t/mOVqJewPuO1miLpTHQiRgTKCLexL4MeAFVagts7HmNZ2Q==
13641-
1364213540
zwitch@^1.0.0:
1364313541
version "1.0.5"
1364413542
resolved "https://registry.yarnpkg.com/zwitch/-/zwitch-1.0.5.tgz#d11d7381ffed16b742f6af7b3f223d5cd9fe9920"

0 commit comments

Comments
 (0)