do not fetch from cache every time

Author: Jimbolino

src/Unleash.php

@@ -23,6 +23,7 @@ class Unleash
     protected $config;
     protected $request;
     protected $features;
+    protected $expires;
 
     public function __construct(ClientInterface $client, Cache $cache, Config $config, Request $request)
     {
@@ -34,13 +35,17 @@ public function __construct(ClientInterface $client, Cache $cache, Config $confi
 
     public function getFeatures(): array
     {
+        if ($this->isFresh()) {
+            return $this->features;
+        }
+
         try {
-            $features = $this->getCachedFeatures();
+            $this->features = $this->getCachedFeatures();
 
             // Always store the failover cache, in case it is turned on during failure scenarios.
-            $this->cache->forever('unleash.features.failover', $features);
+            $this->cache->forever('unleash.features.failover', $this->features);
 
-            return $features;
+            return $this->features;
         } catch (TransferException | JsonException $e) {
             if ($this->config->get('unleash.cache.failover') === true) {
                 return $this->cache->get('unleash.features.failover', []);
@@ -110,16 +115,23 @@ public function isFeatureDisabled(string $name, ...$args): bool
         return !$this->isFeatureEnabled($name, ...$args);
     }
 
+    protected function isFresh(): bool
+    {
+        return $this->expires > time();
+    }
+
     protected function getCachedFeatures(): array
     {
         if (!$this->config->get('unleash.isEnabled')) {
             return [];
         }
 
         if ($this->config->get('unleash.cache.isEnabled')) {
+            $this->setExpires();
+
             return $this->cache->remember(
                 'unleash',
-                $this->config->get('unleash.cache.ttl', self::DEFAULT_CACHE_TTL),
+                $this->getCacheTTL(),
                 function () {
                     return $this->fetchFeatures();
                 }
@@ -129,6 +141,16 @@ function () {
         return $this->features ?? $this->features = $this->fetchFeatures();
     }
 
+    protected function getCacheTTL(): int
+    {
+        return $this->config->get('unleash.cache.ttl', self::DEFAULT_CACHE_TTL);
+    }
+
+    protected function setExpires(): void
+    {
+        $this->expires = $this->getCacheTTL() + time();
+    }
+
     protected function fetchFeatures(): array
     {
         $response = $this->client->get($this->config->get('unleash.featuresEndpoint'));
@@ -139,6 +161,8 @@ protected function fetchFeatures(): array
             throw new JsonException('Could not decode unleash response body.', $e->getCode(), $e);
         }
 
+        $this->setExpires();
+
         return $this->formatResponse($data);
     }