Skip to content

Commit a318625

Browse files
committed
fix(ci): repair broken GitHub Actions pipeline
The CI pipeline was failing on all jobs due to two issues: 1. Missing virtual environment setup - uv commands require an active venv but workflows called 'uv pip install' immediately after installing uv without creating a venv first. Added 'uv venv' step to lint, test, and coverage jobs. 2. Unused type:ignore comments - mypy strict mode was failing because type improvements made three type:ignore suppressions unnecessary. Removed comments from tests/test_component.py as they're no longer needed. This unblocks PR merges, cross-platform testing, and the 0.0.1-alpha release pipeline. Fixes #22
1 parent 08bae41 commit a318625

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,11 @@ jobs:
2020
- name: Install uv
2121
run: curl -LsSf https://astral.sh/uv/install.sh | sh
2222

23+
- name: Create virtual environment
24+
run: uv venv
25+
2326
- name: Install dependencies
24-
run: |
25-
uv venv
26-
uv pip install -e ".[dev]"
27+
run: uv pip install -e ".[dev]"
2728

2829
- name: Run ruff
2930
run: uv run ruff check python tests
@@ -58,6 +59,9 @@ jobs:
5859
- name: Install uv
5960
run: curl -LsSf https://astral.sh/uv/install.sh | sh
6061

62+
- name: Create virtual environment
63+
run: uv venv
64+
6165
- name: Install maturin
6266
run: uv pip install maturin
6367

@@ -89,6 +93,9 @@ jobs:
8993
- name: Install uv
9094
run: curl -LsSf https://astral.sh/uv/install.sh | sh
9195

96+
- name: Create virtual environment
97+
run: uv venv
98+
9299
- name: Install maturin
93100
run: uv pip install maturin
94101

tests/test_component.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ def it_can_be_applied_with_parentheses(self) -> None:
4040
"""Decorator can be applied with parentheses and scope argument."""
4141
_clear_registry()
4242

43-
@component() # type: ignore[misc]
43+
@component()
4444
class DefaultScopeService:
4545
pass
4646

47-
@component(scope=Scope.FACTORY) # type: ignore[misc]
47+
@component(scope=Scope.FACTORY)
4848
class FactoryService:
4949
pass
5050

@@ -175,7 +175,7 @@ def it_creates_new_instances_for_factory_scope(self) -> None:
175175
"""Components with factory scope create new instances each time."""
176176
_clear_registry()
177177

178-
@component(scope=Scope.FACTORY) # type: ignore[misc]
178+
@component(scope=Scope.FACTORY)
179179
class FactoryService:
180180
pass
181181

0 commit comments

Comments
 (0)