segment tracing: fix some silly exceptions when generating trace for nightly vectors indexing

Author: mikemccand

src/python/benchUtil.py

@@ -20,14 +20,14 @@
 import pickle
 import pwd
 import re
+import shlex
 import shutil
 import statistics
 import subprocess
 import sys
 import time
 import traceback
 import types
-import shlex
 from shutil import which
 
 import common

src/python/infostream_to_segments.py

@@ -238,7 +238,10 @@ def to_verbose_string(self, global_start_time, global_end_time, with_line_number
     else:
       s += " (merge: " + " ".join(self.source[1]) + ")"
     l.append(s)
-    md = f"  {self.max_doc:,} max_doc"
+    if self.max_doc is None:
+      md = "  N/A max_doc"
+    else:
+      md = f"  {self.max_doc:,} max_doc"
     if self.size_mb is not None:
       md += f" ({self.max_doc / self.size_mb:,.1f} docs/MB)"
     l.append(md)
@@ -1034,8 +1037,8 @@ def main():
         if m is not None:
           print(f"got start full flush {line_number}")
           # we should NOT be in the middle of a flush-by-RAM?  hmm but what if commit
-          # is called when we are ...?
-          assert trigger_flush_thread_name is None, f"{trigger_flush_thread_name} on line {line_number}"
+          # is called when we are ...?  Indeed, nightly benchy tickled this:
+          # assert trigger_flush_thread_name is None, f"{trigger_flush_thread_name} on line {line_number}"
           timestamp = parse_timestamp(m.group(1))
           thread_name = m.group(2)
           full_flush_events.append([timestamp, None])

src/python/segments_to_html.py

@@ -683,7 +683,11 @@ def main():
 
     assert segment.name not in segment_name_to_segment, f"segment name {segment.name} appears twice?"
     segment_name_to_segment[segment.name] = segment
-    label = f"{segment.name}: docs={segment.max_doc:,}"
+    if segment.max_doc is None:
+      max_doc_string = "N/A"
+    else:
+      max_doc_string = f"{segment.max_doc:,}"
+    label = f"{segment.name}: docs={max_doc_string}"
     if segment.size_mb is not None:
       label += f" mb={segment.size_mb:,.1f}"