Skip to content

Commit 6982440

Browse files
author
Mike Nguyen
committed
fix: correct build_args param name; remove MCPanel from Remotes; skip Suggests
- Fix build_args (underscore not hyphen) - was silently ignored, causing vignettes to be built during R CMD build and failing on Windows - Remove MCPanel from Remotes - was causing setup failures on macOS/oldrel-1 due to C++ compilation issues - Add dependencies: hard to only install Imports/Depends, skip Suggests - _R_CHECK_FORCE_SUGGESTS_=false handles missing Suggests at check time
1 parent 9fae8a2 commit 6982440

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/R-CMD-check.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,11 @@ jobs:
4545
with:
4646
extra-packages: any::rcmdcheck
4747
needs: check
48+
dependencies: '"hard"'
4849

4950
- uses: r-lib/actions/check-r-package@v2
5051
with:
5152
upload-snapshots: true
5253
error-on: '"error"'
53-
build-args: 'c("--no-build-vignettes")'
54+
build_args: 'c("--no-build-vignettes")'
5455
args: 'c("--no-manual", "--no-vignettes")'

DESCRIPTION

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,5 @@ Imports:
123123
plm (>= 2.6.3),
124124
MASS
125125
Remotes:
126-
synth-inference/synthdid@70c1ce3eac58e28c30b67435ca377bb48baa9b8a,
127-
susanathey/MCPanel
126+
synth-inference/synthdid@70c1ce3eac58e28c30b67435ca377bb48baa9b8a
128127
VignetteBuilder: knitr

0 commit comments

Comments
 (0)