update pyright configuration

Author: mikeshardmind

pyproject.toml

@@ -9,29 +9,22 @@ exclude = [
 
 pythonVersion = "3.12"
 pythonPlatform = "All"
+
+
+# strict doesn't allow turning off / downgrading severity of rules
 typeCheckingMode = "standard"
-analyzeUnannotatedFunctions = true
+
+# type issues
 disableBytesTypePromotions = true
 strictParameterNoneValue = true
-enableTypeIgnoreComments = true
-enableReachabilityAnalysis = true
-strictListInference = true
-strictDictionaryInference = true
-strictSetInference = true
-deprecateTypingAliases = false
-enableExperimentalFeatures = false
 reportMissingTypeStubs = "error"
 reportMissingModuleSource = "warning"
 reportInvalidTypeForm = "error"
 reportMissingImports = "error"
 reportUndefinedVariable = "error"
-reportAssertAlwaysTrue = "none"
-reportInvalidStringEscapeSequence = "error"
 reportInvalidTypeVarUse = "error"
 reportSelfClsParameterName = "error"
-reportUnsupportedDunderAll = "error"
-reportUnusedExpression = "warning"
-reportWildcardImportFromLibrary = "error"
+
 reportAbstractUsage = "error"
 reportArgumentType = "error"
 reportAssertTypeFailure = "error"
@@ -50,13 +43,9 @@ reportOptionalCall = "error"
 reportOptionalIterable = "error"
 reportOptionalContextManager = "error"
 reportOptionalOperand = "error"
-reportRedeclaration = "error"
 reportReturnType = "error"
 reportTypedDictNotRequiredAccess = "error"
-reportPrivateImportUsage = "warning"
-reportUnboundVariable = "error"
 reportUnhashable = "error"
-reportUnusedCoroutine = "warning"
 reportUnusedExcept = "error"
 reportFunctionMemberAccess = "error"
 reportIncompatibleMethodOverride = "error"
@@ -65,42 +54,85 @@ reportOverlappingOverload = "error"
 reportPossiblyUnboundVariable = "error"
 reportConstantRedefinition = "error"
 reportDeprecated = "warning"
-reportDuplicateImport = "none"
+
 reportIncompleteStub = "error"
 reportInconsistentConstructor = "error"
 reportInvalidStubStatement = "error"
 reportMatchNotExhaustive = "error"
 reportMissingParameterType = "error"
-reportMissingTypeArgument = "error"
-reportPrivateUsage = "warning"
-reportTypeCommentUsage = "error"
+
 reportUnknownArgumentType = "error"
 reportUnknownLambdaType = "error"
 reportUnknownMemberType = "error"
 reportUnknownParameterType = "error"
 reportUnknownVariableType = "error"
 reportUnnecessaryCast = "warning"
+
+reportCallInDefaultInitializer = "warning"
+reportMissingSuperCall = "none"
+reportPropertyTypeMismatch = "error"
+
+# other type-issues
+
+reportUntypedBaseClass = "warning"  # spec says treat this as Any
+reportUntypedClassDecorator = "warning"  # spec says (Any) -> Any
+reportUntypedFunctionDecorator = "warning"  # spec says (Any) -> Any
+reportUntypedNamedTuple = "none"  # Just no.
+
+# not type issues, even if pyright and mypy offer checks as if they were
+# by calling them "Strict mode checks"
+# these are "opinionated errors with well-defined type interpretation"
+
+reportImplicitOverride = "none"
+reportMissingTypeArgument = "none"
+deprecateTypingAliases = false
 reportUnnecessaryComparison = "none"
 reportUnnecessaryContains = "none"
 reportUnnecessaryIsInstance = "none"
+reportAssertAlwaysTrue = "none"
+reportTypeCommentUsage = "none"
+
+# reasonably preventing accidents
+
+reportUnnecessaryTypeIgnoreComment = "warning"
+
+reportUnsupportedDunderAll = "error"
+reportWildcardImportFromLibrary = "error"
+reportShadowedImports = "warning"
+
+reportUninitializedInstanceVariable = "warning"
+reportUnusedCoroutine = "warning"
+reportUnusedExpression = "warning"
+
+reportPrivateUsage = "warning"
+reportPrivateImportUsage = "warning"
+
+reportInvalidStringEscapeSequence = "error"
+reportRedeclaration = "error"
+reportUnboundVariable = "error"
+
 reportUnusedClass = "warning"
 reportUnusedImport = "warning"
 reportUnusedFunction = "warning"
 reportUnusedVariable = "warning"
-reportUntypedBaseClass = "error"
-reportUntypedClassDecorator = "error"
-reportUntypedFunctionDecorator = "error"
-reportUntypedNamedTuple = "warning"
-reportCallInDefaultInitializer = "warning"
-reportImplicitOverride = "none"
-reportImplicitStringConcatenation = "warning"
+
+# analysis behavior
+enableTypeIgnoreComments = true
+enableReachabilityAnalysis = true
+analyzeUnannotatedFunctions = true
 reportImportCycles = "error"
-reportMissingSuperCall = "none"
-reportPropertyTypeMismatch = "error"
-reportShadowedImports = "error"
-reportUninitializedInstanceVariable = "error"
-reportUnnecessaryTypeIgnoreComment = "warning"
+enableExperimentalFeatures = false
+
+# inference settings
+strictListInference = true
+strictDictionaryInference = true
+strictSetInference = true
+
+# overly-worriesome linter-esque options
+reportImplicitStringConcatenation = "none"
 reportUnusedCallResult = "none"
+reportDuplicateImport = "none"  # handled by ruff
+
 
 
 [tool.ruff]