Skip to content

Commit baf8f9e

Browse files
authored
Merge pull request #8 from iliasbhal/master
default header sets Allow-Access-Origin to '*' by default now
2 parents 65978c7 + a925f4d commit baf8f9e

File tree

3 files changed

+47
-10
lines changed

3 files changed

+47
-10
lines changed

package-lock.json

Lines changed: 11 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "serverless-express",
3-
"version": "2.0.4",
3+
"version": "2.0.5",
44
"description": "Run express apps on AWS λ easily.",
55
"main": "index.js",
66
"scripts": {
@@ -30,7 +30,8 @@
3030
"jest": "^22.2.2",
3131
"lodash": "^4.17.5",
3232
"sinon": "^4.3.0",
33-
"sinon-chai": "^2.14.0"
33+
"sinon-chai": "^2.14.0",
34+
"supertest": "^3.1.0"
3435
},
3536
"dependencies": {
3637
"aws-serverless-express": "^3.1.3",

test/express.test.js

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ let tdd = require('./_tdd')
77
let express = require('express')
88
let sls_express = require('serverless-express/express')
99
let mock = require('./src/mock')
10+
var request = require('supertest');
1011

1112
let initPlugin = require('./src/init-plugin')
1213
let aws_middle = require('../src/aws/aws_middleware')
@@ -73,4 +74,36 @@ describe("serverless-express express", function() {
7374
})
7475

7576
})
77+
78+
it('should Access-Control-Allow-Origin to everyone by defualt', function(done){
79+
80+
let testIsCompleted = false
81+
let testRunned = 0
82+
tdd.supported_providers.forEach((provider)=>{
83+
84+
initPlugin({provider: provider})
85+
let app = sls_express()
86+
app.get('*', (req, res)=>{
87+
res.json(res)
88+
}) // if we don't register a route the middleware stack is not exposed
89+
90+
request(app).get('/')
91+
.then((res)=>{
92+
testRunned += 1
93+
console.log(res)
94+
expect(res.headers['access-control-allow-origin']).to.equal('*')
95+
96+
if( testRunned == tdd.supported_providers.length - 1){
97+
done()
98+
}
99+
100+
})
101+
102+
103+
// let injected = app._router.stack.filter( layer => layer && layer.handle == aws_middle ).length == 1
104+
// expect(injected).to.equal( provider == 'aws')
105+
106+
})
107+
108+
})
76109
})

0 commit comments

Comments
 (0)