Skip to content

Commit 9d9c9cb

Browse files
committed
Moved relevant TODOs to full-blown issues.
1 parent 5698491 commit 9d9c9cb

File tree

7 files changed

+5
-8
lines changed

7 files changed

+5
-8
lines changed

src/main/scala/net/mikolak/pomisos/audio/SamplePlayer.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package net.mikolak.pomisos.audio
22

33
import javax.sound.sampled._
44

5-
//TODO: refactor to actor
65
class SamplePlayer(sampleAtStr: String) {
76

87
private lazy val sampleAt = getClass.getResource(sampleAtStr)

src/main/scala/net/mikolak/pomisos/main/PomodoroTableController.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class PomodoroTableController(
8484
items.onChange(updateComplete())
8585
cell.item.onChange(updateComplete())
8686
cell
87-
}) //TODO: this should parse w/o .value and be editable
87+
})
8888

8989
textColumn.onEditCommit = (e: CellEditEvent[Pomodoro, String]) => {
9090
dao.saveWith(_.copy(name = e.newValue))(e.rowValue.id)

src/main/scala/net/mikolak/pomisos/main/Tray.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ case class Tray(showApp: (() => Unit) @@ AppOpenFunction, exitApp: (() => Unit)
2323
trayIcon.addActionListener(new ActionListener {
2424
override def actionPerformed(e: ActionEvent) = Platform.runLater(showApp())
2525
})
26-
//FIXME: systray issue https://bugs.kde.org/show_bug.cgi?id=362941
26+
//Blocked: systray issue https://bugs.kde.org/show_bug.cgi?id=362941
2727
// trayIcon.addMouseListener(new MouseAdapter {
2828
// override def mouseClicked(e: MouseEvent) = {
2929
// log.debug("Click")

src/main/scala/net/mikolak/pomisos/prefs/task/TrelloNetworkService.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ object TrelloNetworkService {
201201
internal.update(internal.indexOf(itemToUpload), uploaded)
202202
}
203203

204-
//TODO: manage ordering
205204
internal --= itemsToDeleteLocally
206205
internal ++= itemsToDownload
207206

src/main/scala/net/mikolak/pomisos/quality/ConsecutiveQualityAdjuster.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ class ConsecutiveQualityAdjuster(db: ScalaGraphAccess) extends QualityAdjuster {
2525
if (lastQualities.isEmpty) {
2626
None
2727
} else {
28-
//TODO clean this up - breaks for LastQualitiesCount identical consecutive values (esp. 10)
2928
if (lastQualities.map(_.quality).distinct.length == 1) {
3029
Some(lastQualities.head.quality)
3130
} else {

src/main/scala/net/mikolak/pomisos/quality/TimeOfDayQualityAdjuster.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class TimeOfDayQualityAdjuster(db: ScalaGraphAccess, clock: Clock) extends Quali
2121
if (lastQualities.isEmpty) {
2222
None
2323
} else {
24-
Try { //TODO: fragile for some values
24+
Try {
2525
val OLS = ols(
2626
lastQualities.map(a => Array(toHour(a.timestamp))).toArray,
2727
lastQualities.map(_.quality.toDouble).toArray

src/test/scala/net/mikolak/pomisos/quality/QualitySpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ abstract class QualitySpec
4444
forAll(genQualityList(Quality.Max, i => choose(Quality.Min, i), _.max(Quality.Min)), minSuccessful(Tries)) { qualityList =>
4545
whenever(qualityList.size > 10) {
4646
val prediction = tested.predictWithData(qualityList)
47-
if (prediction.nonEmpty) { //TODO: defragile
47+
if (prediction.nonEmpty) {
4848
prediction.value.floor must be <= qualityList.head.quality.toDouble
4949
}
5050
}
@@ -58,7 +58,7 @@ abstract class QualitySpec
5858
forAll(genQualityList(Quality.Min, i => choose(i, Quality.Max), _.min(Quality.Max)), minSuccessful(Tries)) { qualityList =>
5959
whenever(qualityList.size > 10) {
6060
val prediction = tested.predictWithData(qualityList)
61-
if (prediction.nonEmpty) { //TODO: defragile
61+
if (prediction.nonEmpty) {
6262
prediction.value.ceil must be >= qualityList.head.quality.toDouble
6363
}
6464
}

0 commit comments

Comments
 (0)