fix: resolve sync crashes and data corruption on PHP 8.4

- Suppress PHP 8.4 deprecation warnings in worker process to prevent
  SHUTDOWN-ERROR crashes (vendor libs not yet PHP 8.4 compatible)
- Fix assignment instead of comparison in LDAP response check (= vs ===)
- Fix undefined array key: API returns 'id' not 'user_id' after save
- Validate sip_transport value before PATCH to prevent 422 errors
- Disable HTML escaping for userFilter textarea to prevent & -> &
  corruption on each save cycle

Author: jorikfon

App/Forms/LdapConfigForm.php

@@ -70,7 +70,8 @@ public function initialize($entity = null, $options = null): void
 
         // UserFilter
         $this->addTextArea('userFilter', $entity->userFilter ?? '(&(objectClass=user)(objectCategory=PERSON))', 90, [
-            'placeholder' => '(&(objectClass=user)(objectCategory=PERSON))'
+            'placeholder' => '(&(objectClass=user)(objectCategory=PERSON))',
+            'skipEscaping' => true,
         ]);
 
         // Select server type

Lib/LdapSyncMain.php

@@ -71,7 +71,7 @@ public static function syncUsersPerServer(array $ldapCredentials): AnswerStructu
         $processedUsers = [];
 
         // Check if LDAP retrieval was successful
-        if ($responseFromLdap->success = false) {
+        if ($responseFromLdap->success === false) {
             return $responseFromLdap;
         }
 
@@ -181,7 +181,9 @@ public static function updateUserData(array $ldapCredentials, array $userFromLda
                 $response->data[Constants::USER_HAD_CHANGES_ON] = Constants::HAD_CHANGES_ON_PBX;
                 $response->data[Constants::USER_SYNC_RESULT] = Constants::SYNC_RESULT_UPDATED;
                 $previousSyncUser->domainParamsHash = $domainParamsHash;
-                $previousSyncUser->user_id = $response->data['user_id'];
+                if (!empty($response->data['id'])) {
+                    $previousSyncUser->user_id = $response->data['id'];
+                }
             } else {
                 $response->data[Constants::USER_SYNC_RESULT] = Constants::SYNC_RESULT_CONFLICT;
                 $response->data[Constants::SYNC_RESULT_CONFLICT_SIDE] = Constants::PBX_UPDATE_CONFLICT;
@@ -467,9 +469,13 @@ public static function createUpdateUser(array $userDataFromLdap, ?string $curren
             $employeeData['user_avatar'] = $userDataFromLdap[Constants::USER_AVATAR_ATTR];
         }
 
-        // Trim transport value
+        // Validate sip_transport value
+        $validTransports = ['udp', 'tcp', 'tls', 'udp,tcp'];
         if (isset($employeeData['sip_transport'])) {
             $employeeData['sip_transport'] = trim($employeeData['sip_transport']);
+            if (!in_array($employeeData['sip_transport'], $validTransports, true)) {
+                $employeeData['sip_transport'] = 'udp,tcp';
+            }
         }
 
         // Remove read-only fields before saving

Lib/Workers/WorkerLdapSync.php

@@ -43,6 +43,10 @@ class WorkerLdapSync extends WorkerBase
      */
     public function start(array $argv): void
     {
+        // Suppress deprecation warnings for PHP 8.4 compatibility
+        // while maintaining support for PHP 7.4
+        error_reporting(E_ALL & ~E_DEPRECATED);
+
         $managedCache = $this->di->get(ManagedCacheProvider::SERVICE_NAME);
 
         // Retrieve the last sync timestamp from the cache