fix: resolve code review issues in phonebook module

Fix critical bug where $result.getMessages() was called on boolean instead of record object.
Add null check before accessing record properties in save action.
Optimize mass delete to use direct SQL instead of iterating over records.
Add type casting and empty row handling for Excel import.
Remove duplicate search handler in datatable JS.
Update Settings.php license header to GPL-3.0.

Author: jorikfon

App/Controllers/ModulePhoneBookController.php

@@ -168,7 +168,7 @@ public function saveAction(): void
         $record = null;
         if (stripos($dataId, 'new') === false) {
             $record = PhoneBook::findFirstById($dataId);
-            if ($record->number !== $number) {
+            if ($record !== null && $record->number !== $number) {
                 $record->delete();
                 $record = null;
             }
@@ -213,16 +213,18 @@ public function deleteAction(?string $id = null): void
      */
     public function deleteAllRecordsAction(): void
     {
-        $records = PhoneBook::find();
-        foreach ($records as $record) {
-            if (!$record->delete()) {
-                $this->flash->error(implode('<br>', $record->getMessages()));
-                $this->view->result = false;
-                return;
-            }
+        $phoneBook = new PhoneBook();
+        $connection = $phoneBook->getWriteConnection();
+        $tableName = $phoneBook->getSource();
+
+        try {
+            $connection->execute("DELETE FROM {$tableName}");
+            $this->view->result = true;
+            $this->view->reload = 'module-phone-book/module-phone-book/index';
+        } catch (\Throwable $e) {
+            $this->flash->error($e->getMessage());
+            $this->view->result = false;
         }
-        $this->view->result = true;
-        $this->view->reload = 'module-phone-book/module-phone-book/index';
     }
 
     /**

Lib/PhoneBookImport.php

@@ -65,8 +65,13 @@ public function run(string $uploadedFilePath): PBXApiResult
 
             // Iterate over rows and process each record
             for ($row = 2; $row <= $highestRow; ++$row) {
-                $callId = $sheet->getCell([1, $row])->getValue();
-                $numberRep = $sheet->getCell([2, $row])->getValue();
+                $callId = (string)($sheet->getCell([1, $row])->getValue() ?? '');
+                $numberRep = (string)($sheet->getCell([2, $row])->getValue() ?? '');
+
+                // Skip empty rows
+                if (empty($callId) && empty($numberRep)) {
+                    continue;
+                }
 
                 $res = $this->savePhonebookRecord($callId, $numberRep);
                 if (!$res->success) {

Models/Settings.php

@@ -1,15 +1,21 @@
 <?php
 
-/**
- * Copyright © MIKO LLC - All Rights Reserved
- * Unauthorized copying of this file, via any medium is strictly prohibited
- * Proprietary and confidential
- * Written by Alexey Portnov, 2 2019
- */
-
 /*
- * https://docs.phalconphp.com/3.4/ru-ru/db-models-metadata
+ * MikoPBX - free phone system for small business
+ * Copyright © 2017-2024 Alexey Portnov and Nikolay Beketov
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  *
+ * You should have received a copy of the GNU General Public License along with this program.
+ * If not, see <https://www.gnu.org/licenses/>.
  */
 
 namespace Modules\ModulePhoneBook\Models;

Setup/PbxExtensionSetup.php

@@ -46,9 +46,8 @@ public function installDB(): bool
                 $username = mb_strtolower($record->call_id);
                 // Combine all fields into a single string
                 $record->search_index =  $username . $record->number . $record->number_rep;
-                $result = $record->save();
-                if (!$result) {
-                    SystemMessages::sysLogMsg(__METHOD__, implode(' ', $result->getMessages()));
+                if (!$record->save()) {
+                    SystemMessages::sysLogMsg(__METHOD__, implode(' ', $record->getMessages()));
                     return false;
                 }
             }